From vd@datamax.bg  Wed May 18 15:43:56 2005
Return-Path: <vd@datamax.bg>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D652316A4E7
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 May 2005 15:43:56 +0000 (GMT)
Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 751B543D62
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 May 2005 15:43:56 +0000 (GMT)
	(envelope-from vd@datamax.bg)
Received: from sinanica.bg.datamax (sinanica.bg.datamax [192.168.10.1])
	by jengal.datamax.bg (Postfix) with QMQP id B28BB87F8
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 May 2005 18:43:52 +0300 (EEST)
Received: (nullmailer pid 28907 invoked by uid 1004);
	Wed, 18 May 2005 15:43:53 -0000
Message-Id: <20050518154353.GA28768@sinanica.bg.datamax>
Date: Wed, 18 May 2005 18:43:53 +0300
From: Vasil Dimov <vd@datamax.bg>
Reply-To: vd@datamax.bg
To: FreeBSD-gnats-submit@freebsd.org
Subject: Inconsistency between bsd.port.mk and porters-handbook for LIB_DEPENDS
X-Send-Pr-Version: 3.113

>Number:         81208
>Category:       docs
>Synopsis:       Inconsistency between bsd.port.mk and porters-handbook for LIB_DEPENDS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 18 15:50:01 GMT 2005
>Closed-Date:    Fri Jul 15 06:49:45 GMT 2005
>Last-Modified:  Fri Jul 15 06:49:45 GMT 2005
>Originator:     Vasil Dimov
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
DataMax
>Environment:

System: FreeBSD sinanica.bg.datamax 5.4-STABLE FreeBSD 5.4-STABLE #6: Tue May 10 12:46:25 EEST 2005     root@sinanica.bg.datamax:/usr/obj/usr/src/sys/SINANICA-SMP  i386

>Description:

Porters-handbook states that lib part in LIB_DEPENDS (in ports'
Makefiles) is passed as argument to the command:
ldconfig -r | grep -wF
which is incorrect, especially the -F flag and the state that it
may not contain regular expressions.

In bsd.port.mk
ldconfig -r | grep -vwF -e "${PKGCOMPATDIR}" | grep -qwE -e "-l$pattern"
is used and I think that grep -vwF -e "${PKGCOMPATDIR}" and the -q flag
to the second grep call can be omitted for simplicity.
$pattern is lib part of LIB_DEPENDS with dots escaped.

>How-To-Repeat:

>Fix:

--- book.sgml.patch begins here ---
--- book.sgml.orig	Wed May 18 18:03:46 2005
+++ book.sgml	Wed May 18 18:34:26 2005
@@ -3033,9 +3033,11 @@
 	    <literal>install</literal>).</para>
 
 	  <note>
-	    <para>The <replaceable>lib</replaceable> part is an argument given
-	      to <command>ldconfig -r | grep -wF</command>.  There shall be no
-	      regular expressions in this variable.</para>
+	    <para>Library existence is checked with command:
+	    <command>ldconfig -r | grep -wE -e "-l$pattern"</command>.
+	    Where <replaceable>$pattern</replaceable> is the
+	    <replaceable>lib</replaceable> part of <makevar>LIB_DEPENDS</makevar>
+	    with dots (.) escaped (\.).</para>
 	  </note>
 
 	  <para>The dependency is checked twice, once from within the
--- book.sgml.patch ends here ---
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Fri Jul 15 06:49:10 GMT 2005 
State-Changed-Why:  
I committed a similar patch, thank you for noticing this! 


Responsible-Changed-From-To: freebsd-doc->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Fri Jul 15 06:49:10 GMT 2005 
Responsible-Changed-Why:  
Pav did it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=81208 
>Unformatted:
