From nobody@FreeBSD.org  Wed Mar  2 06:01:24 2005
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8495A16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Mar 2005 06:01:24 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6586F43D31
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Mar 2005 06:01:24 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j2261O1l072179
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Mar 2005 06:01:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id j2261NEn072178;
	Wed, 2 Mar 2005 06:01:23 GMT
	(envelope-from nobody)
Message-Id: <200503020601.j2261NEn072178@www.freebsd.org>
Date: Wed, 2 Mar 2005 06:01:23 GMT
From: "Loren M. Lang" <lorenl@alzatex.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Keyword size needs to be changed to length in vinum manpage.
X-Send-Pr-Version: www-2.3

>Number:         78275
>Category:       docs
>Synopsis:       [patch] Keyword size needs to be changed to length in vinum(8) manpage.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 02 06:10:19 GMT 2005
>Closed-Date:    Sun Dec 25 10:02:12 GMT 2005
>Last-Modified:  Sun Dec 25 10:02:12 GMT 2005
>Originator:     Loren M. Lang
>Release:        5.3-RELEASE-p5
>Organization:
Alzatex, Inc.
>Environment:
FreeBSD fbsd.ddns.alzatex.cc 5.3-RELEASE-p5 FreeBSD 5.3-RELEASE-p5 #3: Fri Jan 28 16:49:59 PST 2005     root@fbsd.ddns.alzatex.cc:/usr/obj/usr/src/sys/IPSEC  i386

>Description:
      Several places in the examples used in the vinum(8) man page, the keyword size is used on the subdisk lines when it should be length.
>How-To-Repeat:
      Follow one of the examples under SIMPLIFIED CONFIGURATION and see vinum create complain when it tries to read it.
>Fix:
      Change size to length on lines like
sd name vinum0.p0.s0 drive vinumdrive0 size 0
sd name vinum0.p0.s1 drive vinumdrive1 size 0
sd name vinum0.p0.s3 drive vinumdrive3 size 0
..
Should read:
sd name vinum0.p0.s0 drive vinumdrive0 length 0
..
>Release-Note:
>Audit-Trail:

From: "Loren M. Lang" <lorenl@alzatex.com>
To: bug-followup@FreeBSD.org, lorenl@alzatex.com
Cc:  
Subject: Re: docs/78275: Keyword size needs to be changed to length in vinum manpage.
Date: Tue, 7 Jun 2005 05:47:40 -0700

 --mojUlQ0s9EVzWg2t
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Here is a patch to fix it.
 
 --=20
 I sense much NT in you.
 NT leads to Bluescreen.
 Bluescreen leads to downtime.
 Downtime leads to suffering.
 NT is the path to the darkside.
 Powerful Unix is.
 
 Public Key: ftp://ftp.tallye.com/pub/lorenl_pubkey.asc
 Fingerprint: CEE1 AAE2 F66C 59B5 34CA  C415 6D35 E847 0118 A3D2
 =20
 
 --mojUlQ0s9EVzWg2t
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="vinum.patch"
 
 --- vinum.8.orig	Tue Jun  7 05:46:42 2005
 +++ vinum.8	Tue Jun  7 05:46:45 2005
 @@ -1600,13 +1600,13 @@
  volume vinum0
    plex name vinum0.p0 org concat
  drive vinumdrive0 device /dev/da1h
 -    sd name vinum0.p0.s0 drive vinumdrive0 size 0
 +    sd name vinum0.p0.s0 drive vinumdrive0 length 0
  drive vinumdrive1 device /dev/da2h
 -    sd name vinum0.p0.s1 drive vinumdrive1 size 0
 +    sd name vinum0.p0.s1 drive vinumdrive1 length 0
  drive vinumdrive2 device /dev/da3h
 -    sd name vinum0.p0.s2 drive vinumdrive2 size 0
 +    sd name vinum0.p0.s2 drive vinumdrive2 length 0
  drive vinumdrive3 device /dev/da4h
 -    sd name vinum0.p0.s3 drive vinumdrive3 size 0
 +    sd name vinum0.p0.s3 drive vinumdrive3 length 0
  V vinum0                State: up       Plexes:       1 Size:       2134 MB
  P vinum0.p0           C State: up       Subdisks:     4 Size:       2134 MB
  S vinum0.p0.s0          State: up       D: vinumdrive0  Size:        414 MB
 @@ -1630,10 +1630,10 @@
  drive vinumdrive3 device /dev/da4h
  volume vinum0
    plex name vinum0.p0 org striped 279k
 -    sd name vinum0.p0.s0 drive vinumdrive0 size 849825b
 -    sd name vinum0.p0.s1 drive vinumdrive1 size 849825b
 -    sd name vinum0.p0.s2 drive vinumdrive2 size 849825b
 -    sd name vinum0.p0.s3 drive vinumdrive3 size 849825b
 +    sd name vinum0.p0.s0 drive vinumdrive0 length 849825b
 +    sd name vinum0.p0.s1 drive vinumdrive1 length 849825b
 +    sd name vinum0.p0.s2 drive vinumdrive2 length 849825b
 +    sd name vinum0.p0.s3 drive vinumdrive3 length 849825b
  V vinum0                State: up       Plexes:       1 Size:       1659 MB
  P vinum0.p0           S State: up       Subdisks:     4 Size:       1659 MB
  S vinum0.p0.s0          State: up       D: vinumdrive0  Size:        414 MB
 @@ -1654,11 +1654,11 @@
  drive vinumdrive3 device /dev/da4h
  volume mirror setupstate
    plex name mirror.p0 org concat
 -    sd name mirror.p0.s0 drive vinumdrive0 size 0b
 -    sd name mirror.p0.s1 drive vinumdrive2 size 0b
 +    sd name mirror.p0.s0 drive vinumdrive0 length 0b
 +    sd name mirror.p0.s1 drive vinumdrive2 length 0b
    plex name mirror.p1 org concat
 -    sd name mirror.p1.s0 drive vinumdrive1 size 0b
 -    sd name mirror.p1.s1 drive vinumdrive3 size 0b
 +    sd name mirror.p1.s0 drive vinumdrive1 length 0b
 +    sd name mirror.p1.s1 drive vinumdrive3 length 0b
  V mirror                State: up       Plexes:       2 Size:       1146 MB
  P mirror.p0           C State: up       Subdisks:     2 Size:        988 MB
  P mirror.p1           C State: up       Subdisks:     2 Size:       1146 MB
 @@ -1688,11 +1688,11 @@
  drive vinumdrive3 device /dev/da4h
  volume raid10 setupstate
    plex name raid10.p0 org striped 279k
 -    sd name raid10.p0.s0 drive vinumdrive0 size 849825b
 -    sd name raid10.p0.s1 drive vinumdrive2 size 849825b
 +    sd name raid10.p0.s0 drive vinumdrive0 length 849825b
 +    sd name raid10.p0.s1 drive vinumdrive2 length 849825b
    plex name raid10.p1 org striped 279k
 -    sd name raid10.p1.s0 drive vinumdrive1 size 1173665b
 -    sd name raid10.p1.s1 drive vinumdrive3 size 1173665b
 +    sd name raid10.p1.s0 drive vinumdrive1 length 1173665b
 +    sd name raid10.p1.s1 drive vinumdrive3 length 1173665b
  V raid10                State: up       Plexes:       2 Size:       1146 MB
  P raid10.p0           S State: up       Subdisks:     2 Size:        829 MB
  P raid10.p1           S State: up       Subdisks:     2 Size:       1146 MB
 @@ -2425,10 +2425,10 @@
  drive d4 device /dev/da4e
  volume raid
    plex org raid5 433k
 -    sd size 2g drive d1
 -    sd size 2g drive d2
 -    sd size 2g drive d3
 -    sd size 2g drive d4
 +    sd length 2g drive d1
 +    sd length 2g drive d2
 +    sd length 2g drive d3
 +    sd length 2g drive d4
  .Ed
  .Pp
  With this configuration file, we get:
 
 --mojUlQ0s9EVzWg2t--
State-Changed-From-To: open->closed 
State-Changed-By: remko 
State-Changed-When: Sun Dec 25 10:00:00 UTC 2005 
State-Changed-Why:  
Actually the printed output is correct.  When looking 
into the commands.c file (used for vinum) you will 
see a lot of lines with: 

commands.c:         printf("    sd name %s.p0.s%d drive %s size %lldbn", 

those statements, which tells me the output should be correct. 
On the other hand, the length statements are used to configure 
vinum from a file. 

I do not believe we should correct this, but thanks 
for taking the time to investigate/patch and report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=78275 
>Unformatted:
