From flz@xbsd.org  Mon Feb 21 11:57:46 2005
Return-Path: <flz@xbsd.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C525A16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Feb 2005 11:57:46 +0000 (GMT)
Received: from smtp.xbsd.org (xbsd.org [82.233.2.192])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6C92243D53
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Feb 2005 11:57:46 +0000 (GMT)
	(envelope-from flz@xbsd.org)
Received: from localhost (localhost.xbsd.org [127.0.0.1])
	by smtp.xbsd.org (Postfix) with ESMTP id 0A8EA1162D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 21 Feb 2005 12:59:21 +0100 (CET)
Received: from smtp.xbsd.org ([127.0.0.1])
 by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
 id 81236-07 for <FreeBSD-gnats-submit@freebsd.org>;
 Mon, 21 Feb 2005 12:59:15 +0100 (CET)
Received: by smtp.xbsd.org (Postfix, from userid 2001)
	id 8BB0C1161B; Mon, 21 Feb 2005 12:59:15 +0100 (CET)
Message-Id: <20050221115915.8BB0C1161B@smtp.xbsd.org>
Date: Mon, 21 Feb 2005 12:59:15 +0100 (CET)
From: Florent Thoumie <flz@xbsd.org>
Reply-To: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: articles/committers-guide: change Approved -> Reviewed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         77851
>Category:       docs
>Synopsis:       articles/committers-guide: change Approved -> Reviewed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 21 12:00:38 GMT 2005
>Closed-Date:    Tue Feb 22 12:59:02 GMT 2005
>Last-Modified:  Tue Feb 22 12:59:02 GMT 2005
>Originator:     Florent Thoumie
>Release:        FreeBSD 5.3-RELEASE i386
>Organization:
Xbsd.org
>Environment:
System: FreeBSD srv1.xbsd.org 5.3-RELEASE FreeBSD 5.3-RELEASE #2: Wed Nov 24 16:35:34 CET 2004 root@gate.xbsd.org:/usr/src/sys/i386/compile/GATE i386


	
>Description:

These are two different statements of the Committer's Guide. I think the
second one is erroneous.

"Approved by" is only acceptable from non-mentored src committers -- mentored
committers can provide a "Reviewed by" but not an "Approved by".

Until your mentor decides (and announces with a forced commit to access) that
you have learned the ropes and are ready to commit on your own, you should not
commit anything without first getting your mentor's review and approval, and
you should document that approval with an Approved by: line in the commit
message.

>How-To-Repeat:
	
>Fix:

--- article.sgml.diff begins here ---

Index: article.sgml
===================================================================
RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v
retrieving revision 1.219
diff -u -r1.219 article.sgml
--- article.sgml        22 Dec 2004 07:54:15 -0000      1.219
+++ article.sgml        21 Feb 2005 11:47:19 -0000
@@ -1148,7 +1148,7 @@
       ropes and are ready to commit on your own, you should not commit
       anything without first getting your mentor's review and
       approval, and you should document that approval with an
-      <literal>Approved by:</literal> line in the commit
+      <literal>Reviewed by:</literal> line in the commit
       message.</para>

     <para>All <filename>src</filename> commits should go to

--- article.sgml.diff ends here---
>Release-Note:
>Audit-Trail:

From: "Simon L. Nielsen" <simon@FreeBSD.org>
To: Florent Thoumie <flz@xbsd.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed
Date: Mon, 21 Feb 2005 13:19:23 +0100

 --UFHRwCdBEJvubb2X
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote:
 
 > These are two different statements of the Committer's Guide. I think the
 > second one is erroneous.
 
 It isn't, it's different topics.
 
 > "Approved by" is only acceptable from non-mentored src committers -- ment=
 ored
 > committers can provide a "Reviewed by" but not an "Approved by".
 
 This is from the "2.1 Policy for doc/ committer activity in src/"
 section, ie. only for doc committers (if they are mentored or not)
 and only wrt. commtting to src/.
 
 > Until your mentor decides (and announces with a forced commit to access) =
 that
 > you have learned the ropes and are ready to commit on your own, you shoul=
 d not
 > commit anything without first getting your mentor's review and approval, =
 and
 > you should document that approval with an Approved by: line in the commit
 > message.
 
 This is general for all committers being mentored and is correct
 (though not entirely at least wrt. to doc/ people but that's another
 matter).
 
 --=20
 Simon L. Nielsen
 
 --UFHRwCdBEJvubb2X
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (FreeBSD)
 
 iD8DBQFCGdHLh9pcDSc1mlERAgvuAJwL7zeZRWgc3TdLxdvLDV734YIilACggth6
 e9e27XmdwsDVoPTOPDh77tE=
 =vMZf
 -----END PGP SIGNATURE-----
 
 --UFHRwCdBEJvubb2X--

From: Florent Thoumie <flz@xbsd.org>
To: "Simon L. Nielsen" <simon@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed
Date: Mon, 21 Feb 2005 13:24:59 +0100

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig652565EE2E8C582CE3347021
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Simon L. Nielsen wrote:
 > On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote:
 >
 >
 >>These are two different statements of the Committer's Guide. I think the
 >>second one is erroneous.
 >
 >
 > It isn't, it's different topics.
 >
 >
 >>"Approved by" is only acceptable from non-mentored src committers -- mentored
 >>committers can provide a "Reviewed by" but not an "Approved by".
 >
 >
 > This is from the "2.1 Policy for doc/ committer activity in src/"
 > section, ie. only for doc committers (if they are mentored or not)
 > and only wrt. commtting to src/.
 >
 >
 >>Until your mentor decides (and announces with a forced commit to access) that
 >>you have learned the ropes and are ready to commit on your own, you should not
 >>commit anything without first getting your mentor's review and approval, and
 >>you should document that approval with an Approved by: line in the commit
 >>message.
 >
 >
 > This is general for all committers being mentored and is correct
 > (though not entirely at least wrt. to doc/ people but that's another
 > matter).
 
 	Ok this was a bit unclear, though i read these parts 2 or 3
 	times.
 
 	Thanks.
 
 --------------enig652565EE2E8C582CE3347021
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
 
 iD8DBQFCGdMfMxEkbVFH3PQRArFEAJ46jgRVamwzkW7V2PjSi4a9gI/2KQCcCGyY
 pXAFsZZl0J2qvkdZuDaWjR4=
 =Nqs4
 -----END PGP SIGNATURE-----
 
 --------------enig652565EE2E8C582CE3347021--

From: Florent Thoumie <flz@xbsd.org>
To: FreeBSD-gnats-submit@FreeBSD.org, simon@FreeBSD.org
Cc:  
Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed
Date: Tue, 22 Feb 2005 13:19:50 +0100

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig6FB585B0C27D3DCA27F61D63
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 	You can close this PR, I thought you already did it.
 
 --------------enig6FB585B0C27D3DCA27F61D63
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
 
 iD8DBQFCGyNqMxEkbVFH3PQRAiB/AJ0RMALmgmYFYKkxn8KWPZJmm5rwiwCfU7K3
 /e1BxtPI4Ud9MuG+nYyQeuw=
 =3F1b
 -----END PGP SIGNATURE-----
 
 --------------enig6FB585B0C27D3DCA27F61D63--
State-Changed-From-To: open->closed 
State-Changed-By: keramida 
State-Changed-When: Tue Feb 22 12:58:33 GMT 2005 
State-Changed-Why:  
Closed at submitter's request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=77851 
>Unformatted:
