From rodrigc@crodrigues.org  Mon Dec 13 15:50:50 2004
Return-Path: <rodrigc@crodrigues.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 53D7116A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Dec 2004 15:50:50 +0000 (GMT)
Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 048CD43D1D
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Dec 2004 15:50:50 +0000 (GMT)
	(envelope-from rodrigc@crodrigues.org)
Received: from h00609772adf0.ne.client2.attbi.com ([66.30.114.143])
          by comcast.net (sccrmhc13) with ESMTP
          id <20041213155043016007jdnie>; Mon, 13 Dec 2004 15:50:47 +0000
Received: from h00609772adf0.ne.client2.attbi.com (localhost [127.0.0.1])
	by h00609772adf0.ne.client2.attbi.com (8.13.1/8.13.1) with ESMTP id iBDFohjs003964
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 13 Dec 2004 10:50:43 -0500 (EST)
	(envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com)
Received: (from rodrigc@localhost)
	by h00609772adf0.ne.client2.attbi.com (8.13.1/8.13.1/Submit) id iBDFohcn003963;
	Mon, 13 Dec 2004 10:50:43 -0500 (EST)
	(envelope-from rodrigc)
Message-Id: <200412131550.iBDFohcn003963@h00609772adf0.ne.client2.attbi.com>
Date: Mon, 13 Dec 2004 10:50:43 -0500 (EST)
From: Craig Rodrigues <rodrigc@crodrigues.org>
Reply-To: Craig Rodrigues <rodrigc@crodrigues.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: hw.ata.atapi_dma patch for ata(4) man page
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         75021
>Category:       docs
>Synopsis:       hw.ata.atapi_dma patch for ata(4) man page
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    roam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 13 16:00:57 GMT 2004
>Closed-Date:    Sun Feb 27 14:23:28 GMT 2005
>Last-Modified:  Sun Feb 27 14:23:28 GMT 2005
>Originator:     Craig Rodrigues
>Release:        FreeBSD 6.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD dibbler.crodrigues.org 6.0-CURRENT FreeBSD 6.0-CURRENT #49: Tue Dec 7 16:03:32 EST 2004 rodrigc@dibbler.crodrigues.org:/usr/obj/usr/src/sys/MYKERNEL1 i386


	
>Description:

In ata(4), it states:

 hw.ata.atapi_dma
     set to 1 for DMA access, 0 for PIO (default is PIO).

In src/sys/dev/ata/ata-all.c, this sysctl is by default
set to 1 (on -CURRENT, and also on 5.3-RELEASE).

Perhaps this patch is in order?

>How-To-Repeat:
	
>Fix:

--- share/man/man4/ata.4.orig   Thu Dec  9 19:07:53 2004
+++ share/man/man4/ata.4        Thu Dec  9 19:08:08 2004
@@ -86,7 +86,7 @@
 .It Va hw.ata.ata_dma
 set to 1 for DMA access, 0 for PIO (default is DMA).
 .It Va hw.ata.atapi_dma
-set to 1 for DMA access, 0 for PIO (default is PIO).
+set to 1 for DMA access, 0 for PIO (default is DMA).
 .It Va hw.ata.wc
 set to 1 to enable Write Caching, 0 to disable (default is enabled).
 .Em WARNING :



>Release-Note:
>Audit-Trail:

From: Joel Dahl <joel@automatvapen.se>
To: Craig Rodrigues <rodrigc@crodrigues.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/75021: hw.ata.atapi_dma patch for ata(4) man page
Date: Sun, 19 Dec 2004 12:32:27 +0100

 On Mon, 2004-12-13 at 10:50 -0500, Craig Rodrigues wrote:	
 > >Description:
 > 
 > In ata(4), it states:
 > 
 >  hw.ata.atapi_dma
 >      set to 1 for DMA access, 0 for PIO (default is PIO).
 > 
 > In src/sys/dev/ata/ata-all.c, this sysctl is by default
 > set to 1 (on -CURRENT, and also on 5.3-RELEASE).
 > 
 > Perhaps this patch is in order?
 > 	
 > >Fix:
 > 
 > --- share/man/man4/ata.4.orig   Thu Dec  9 19:07:53 2004
 > +++ share/man/man4/ata.4        Thu Dec  9 19:08:08 2004
 > @@ -86,7 +86,7 @@
 >  .It Va hw.ata.ata_dma
 >  set to 1 for DMA access, 0 for PIO (default is DMA).
 >  .It Va hw.ata.atapi_dma
 > -set to 1 for DMA access, 0 for PIO (default is PIO).
 > +set to 1 for DMA access, 0 for PIO (default is DMA).
 >  .It Va hw.ata.wc
 >  set to 1 to enable Write Caching, 0 to disable (default is enabled).
 >  .Em WARNING :
 
 There is another part in ata(4) that also requires a correction,
 (assuming Craig's patch is correct):
 
 "
 ATAPI devices are set to PIO mode by default because severe DMA problems
 are common even if the device capabilities indicate support.
 "
 
 ATAPI devices are set to DMA mode by default (as Craig mentions), so
 someone should probably reword this part a bit.
 
State-Changed-From-To: open->closed 
State-Changed-By: roam 
State-Changed-When: Tue Dec 21 20:02:58 GMT 2004 
State-Changed-Why:  
Both the hw.ata.atapi_dma default and the discussion further down the page 
were fixed in -CURRENT.  I'll merge the changes into 5.x in a week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75021 
State-Changed-From-To: closed->patched 
State-Changed-By: roam 
State-Changed-When: Tue Dec 21 20:05:21 GMT 2004 
State-Changed-Why:  
Not my day, is it... 


Responsible-Changed-From-To: freebsd-doc->roam 
Responsible-Changed-By: roam 
Responsible-Changed-When: Tue Dec 21 20:05:21 GMT 2004 
Responsible-Changed-Why:  
I'll take care of the MFC to 5.x. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75021 
State-Changed-From-To: patched->closed 
State-Changed-By: roam 
State-Changed-When: Sun Feb 27 14:12:50 GMT 2005 
State-Changed-Why:  
The fixes were merged to the RELENG_5 branch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=75021 
>Unformatted:
