From nobody@FreeBSD.org  Fri Nov  5 19:31:59 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D521416A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  5 Nov 2004 19:31:59 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CA6BF43D46
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  5 Nov 2004 19:31:59 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id iA5JVvSw045001
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 5 Nov 2004 19:31:57 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id iA5JVvEq045000;
	Fri, 5 Nov 2004 19:31:57 GMT
	(envelope-from nobody)
Message-Id: <200411051931.iA5JVvEq045000@www.freebsd.org>
Date: Fri, 5 Nov 2004 19:31:57 GMT
From: Pierre-Paul Lavoie <ppl@nbnet.nb.ca>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Extra cat(1) in example section of samba
X-Send-Pr-Version: www-2.3

>Number:         73577
>Category:       docs
>Synopsis:       Extra cat(1) in example section of samba
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 05 19:40:35 GMT 2004
>Closed-Date:    Fri Nov 05 20:21:29 GMT 2004
>Last-Modified:  Fri Nov 05 20:21:29 GMT 2004
>Originator:     Pierre-Paul Lavoie
>Release:        
>Organization:
>Environment:
>Description:
Section "23.10.2.3 Security Settings" of the FreeBSD handbook.

      http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/network-samba.html

The example is

# cat /etc/passwd | grep -v "^#" | make_smbpasswd > /usr/local/private/smbpasswd
# chmod 600 /usr/local/private/smbpasswd

The first command should be

# grep -v "^#" /etc/passwd | make_smbpasswd > /usr/local/private/smbpasswd

    or

# grep -v "^#" < /etc/passwd | make_smbpasswd > /usr/local/private/smbpasswd

I would think that the former is better.
>How-To-Repeat:
      
>Fix:
      
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: roam 
State-Changed-When: Fri Nov 5 20:20:40 GMT 2004 
State-Changed-Why:  
Yep, you are right - this was indeed a useless use of 'cat'. 
I committed the first version of your patch.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=73577 
>Unformatted:
