From sascha@ws111.noc.celox.de  Thu Jul 22 11:47:59 2004
Return-Path: <sascha@ws111.noc.celox.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1573E16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Jul 2004 11:47:59 +0000 (GMT)
Received: from ws111.noc.celox.de (ws111.noc.celox.de [217.146.128.167])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C39D543D3F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Jul 2004 11:47:58 +0000 (GMT)
	(envelope-from sascha@ws111.noc.celox.de)
Received: from sascha by ws111.noc.celox.de with local (Exim 4.40 (FreeBSD))
	id 1Bnc3F-000OmW-MD
	for FreeBSD-gnats-submit@freebsd.org; Thu, 22 Jul 2004 13:47:53 +0200
Message-Id: <E1Bnc3F-000OmW-MD@ws111.noc.celox.de>
Date: Thu, 22 Jul 2004 13:47:53 +0200
From: Sascha Schneider <suntsu@suntsu.org>
Reply-To: Sascha Schneider <suntsu@suntsu.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] Wrong symbolic constant in getrusage(2) on 4.10-STABLE
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         69428
>Category:       docs
>Synopsis:       [patch] Wrong symbolic constant in getrusage(2) on 4.10-STABLE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    roam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 22 11:50:25 GMT 2004
>Closed-Date:    Mon Aug 23 11:11:30 GMT 2004
>Last-Modified:  Mon Aug 23 11:11:30 GMT 2004
>Originator:     Sascha Schneider
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
>Environment:
System: FreeBSD ws111.noc.celox.de 4.10-STABLE FreeBSD 4.10-STABLE #0: Mon Jul 5 15:45:06 CEST 2004 root@ws111.noc.celox.de:/usr/obj/usr/src/sys/WS111 i386
	$FreeBSD: src/lib/libc/sys/getrusage.2,v 1.10.2.5 2001/12/14 18:34:00 ru Exp $
	$FreeBSD: src/lib/libc/gen/sysconf.3,v 1.8.2.6 2001/12/14 18:33:51 ru Exp $
	$FreeBSD: src/sys/sys/unistd.h,v 1.22.2.3 2003/11/11 07:26:33 das Exp $

>Description:
	getrusage(2) states that sysconf(_SC_CLOCK_TCK) would return the
	frequency of the statistic clock. According to sysconf(3) and
	/usr/include/sys/unistd.h this is wrong: 
	sysconf(_SC_CLK_TCK) is the way to do it.
>How-To-Repeat:
	[user@ws111] [~]$ zgrep TCK /usr/share/man/man2/getrusage.2.gz
	.Fn sysconf _SC_CLOCK_TCK
	[user@ws111] [~]$ zgrep TCK /usr/share/man/man3/sysconf.3.gz
	.It Li _SC_CLK_TCK
	[user@ws111] [~]$ zgrep TCK /usr/include/sys/unistd.h
	#define _SC_CLK_TCK
	[user@ws111] [~dc/stuff]$ cat getrusage-wrong.c
	#include <stdio.h>
	#include <unistd.h>

	int main(void)
	{
		printf("Frequency: %d\n", sysconf(_SC_CLOCK_TCK));
	}
	[user@ws111] [~dc/stuff]$ make getrusage-wrong
	cc -O -pipe -march=pentium  getrusage-wrong.c  -o getrusage-wrong
	getrusage-wrong.c: In function `main':
	getrusage-wrong.c:6: `_SC_CLOCK_TCK' undeclared (first use in this function)
	getrusage-wrong.c:6: (Each undeclared identifier is reported only once
	getrusage-wrong.c:6: for each function it appears in.)
	*** Error code 1

	Stop in /home/user/development/c/stuff.
	[user@ws111] [~dc/stuff]$ cat getrusage-right.c
	#include <stdio.h>
	#include <unistd.h>

	int main(void)
	{
		printf("Frequency: %d\n", sysconf(_SC_CLK_TCK));
	}
	[user@ws111] [~dc/stuff]$ make getrusage-right
	cc -O -pipe -march=pentium  getrusage-right.c  -o getrusage-right
	[user@ws111] [~dc/stuff]$ ./getrusage-right
	Frequency: 128


>Fix:
patch patch-getrusage.2 attached.
>Release-Note:
>Audit-Trail:

From: Sascha Schneider <suntsu@suntsu.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/69428: [patch] Wrong symbolic constant in getrusage(2) on 4.10-STABLE
Date: Thu, 22 Jul 2004 17:19:29 +0200

 --YiEDa0DAkWCtVeE4
 Content-Type: text/plain; charset=iso-8859-1
 Content-Disposition: inline
 
 Hello,
 
 seems like attaching the patch to a prewritten PR, that is included by
 -f does not work. So, here it is.
 
 Kind regards,
 
 Sascha Schneider
 
 --YiEDa0DAkWCtVeE4
 Content-Type: text/plain; charset=iso-8859-1
 Content-Disposition: attachment; filename="patch-getrusage.2"
 
 --- getrusage.2.orig   Thu Jul 22 12:44:13 2004
 +++ getrusage.2 Thu Jul 22 12:43:48 2004
 @@ -101,7 +101,7 @@
  in units of kilobytes * ticks-of-execution.
  Ticks are statistics clock ticks.
  The statistics clock has a frequency of
 -.Fn sysconf _SC_CLOCK_TCK
 +.Fn sysconf _SC_CLK_TCK
  ticks per second.
  .It Fa ru_idrss
  an integral value of the amount of unshared memory residing in the
 
 --YiEDa0DAkWCtVeE4--
State-Changed-From-To: open->patched 
State-Changed-By: roam 
State-Changed-When: Fri Aug 6 14:49:16 GMT 2004 
State-Changed-Why:  
Fixed in -CURRENT, will be merged into -STABLE in two weeks. 
Thanks! 


Responsible-Changed-From-To: freebsd-doc->roam 
Responsible-Changed-By: roam 
Responsible-Changed-When: Fri Aug 6 14:49:16 GMT 2004 
Responsible-Changed-Why:  
I'll take care of the MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69428 
State-Changed-From-To: patched->closed 
State-Changed-By: roam 
State-Changed-When: Mon Aug 23 11:11:08 GMT 2004 
State-Changed-Why:  
The misspelling was also fixed in 4-STABLE, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=69428 
>Unformatted:
