From marcs@riffraff.plig.net  Fri Apr  2 03:55:32 2004
Return-Path: <marcs@riffraff.plig.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4E42516A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  2 Apr 2004 03:55:32 -0800 (PST)
Received: from riffraff.plig.net (riffraff.plig.net [195.40.6.40])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1E25443D2D
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  2 Apr 2004 03:55:32 -0800 (PST)
	(envelope-from marcs@riffraff.plig.net)
Received: from localhost (localhost [127.0.0.1])
	by riffraff.plig.net (Postfix) with ESMTP id 3C9A3FA3BA
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  2 Apr 2004 12:55:31 +0100 (BST)
Received: from riffraff.plig.net ([127.0.0.1])
 by localhost (riffraff.plig.net [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 85357-01-8 for <FreeBSD-gnats-submit@freebsd.org>;
 Fri,  2 Apr 2004 12:55:26 +0100 (BST)
Received: by riffraff.plig.net (Postfix, from userid 3010)
	id 794B3FA37F; Fri,  2 Apr 2004 12:55:23 +0100 (BST)
Message-Id: <20040402115523.794B3FA37F@riffraff.plig.net>
Date: Fri,  2 Apr 2004 12:55:23 +0100 (BST)
From: Marc Silver <marcs@draenor.org>
Reply-To: Marc Silver <marcs@draenor.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: acct(2) patch
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         65070
>Category:       docs
>Synopsis:       acct(2) patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 02 04:00:40 PST 2004
>Closed-Date:    Fri Apr 16 22:34:13 CEST 2004
>Last-Modified:  Fri Apr 16 22:34:13 CEST 2004
>Originator:     Marc Silver
>Release:        FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD riffraff.plig.net 4.9-STABLE FreeBSD 4.9-STABLE #5: Wed Mar 3 16:21:56 GMT 2004 keet@riffraff.plig.net:/usr/src/sys/compile/RIFFRAFF i386


>Description:
	The man page for acct(2) is missing information on certain
	sysctl(8) variables which affect process accounting.  It's also
	missing a link to the accton(8) command, which should be
	included, imho.

>How-To-Repeat:
	man 2 acct

>Fix:
	Apply the following patch:

--- acct.2-orig	Fri Apr  2 12:35:55 2004
+++ acct.2	Fri Apr  2 12:38:16 2004
@@ -75,9 +75,27 @@
 .Pp
 This call is permitted only to the super-user.
 .Sh NOTES
-Accounting is automatically disabled when the file system the
-accounting file resides on runs out of space; it is enabled when
-space once again becomes available.
+Accounting is automatically disabled when the file system the accounting
+file resides on runs out of space; it is enabled when space once
+again becomes available.  These values can be controlled using the
+following
+.Xr sysctl 8
+variables:
+.Pp
+.Bl -ohang -offset indent
+.It kern.acct_chkfreq
+.Pq Vt int
+Specifies the frequency (in minutes) with which free disk
+space should be checked.
+.It kern.acct_resume
+.Pq Vt int
+The percentage of free disk space above which process
+accounting will resume.
+.It kern.acct_suspend
+.Pq Vt int
+The percentage of free disk space below which process
+accounting will suspend.
+.El
 .Sh RETURN VALUES
 On error -1 is returned.
 The file must exist and the call may be exercised only by the super-user.
@@ -112,7 +130,8 @@
 .El
 .Sh SEE ALSO
 .Xr acct 5 ,
-.Xr sa 8
+.Xr sa 8 ,
+.Xr accton 8
 .Sh HISTORY
 The
 .Fn acct
>Release-Note:
>Audit-Trail:

From: Christian Brueffer <chris@unixpages.org>
To: Marc Silver <marcs@draenor.org>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: docs/65070: acct(2) patch
Date: Fri, 16 Apr 2004 02:38:02 +0200

 --D6IIOQQv2Iwyp54J
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, Apr 02, 2004 at 12:55:23PM +0100, Marc Silver wrote:
 
 A few comments:
 
 >=20
 > --- acct.2-orig	Fri Apr  2 12:35:55 2004
 > +++ acct.2	Fri Apr  2 12:38:16 2004
 > @@ -75,9 +75,27 @@
 >  .Pp
 >  This call is permitted only to the super-user.
 >  .Sh NOTES
 > -Accounting is automatically disabled when the file system the
 > -accounting file resides on runs out of space; it is enabled when
 > -space once again becomes available.
 > +Accounting is automatically disabled when the file system the accounting
 > +file resides on runs out of space; it is enabled when space once
 > +again becomes available.  These values can be controlled using the
 
 New sentences should start on new lines.  Also "these values" is a bit
 misleading, we haven't talked about any values before.
 
 > +following
 > +.Xr sysctl 8
 > +variables:
 > +.Pp
 > +.Bl -ohang -offset indent
 > +.It kern.acct_chkfreq
 > +.Pq Vt int
 > +Specifies the frequency (in minutes) with which free disk
 > +space should be checked.
 > +.It kern.acct_resume
 > +.Pq Vt int
 > +The percentage of free disk space above which process
 > +accounting will resume.
 > +.It kern.acct_suspend
 > +.Pq Vt int
 > +The percentage of free disk space below which process
 > +accounting will suspend.
 > +.El
 
 This is not very in line with the sysctl lists in other manpages.
 What do you think about the following patch?
 
 Index: acct.2
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /usr/home/ncvs/freebsd/src/lib/libc/sys/acct.2,v
 retrieving revision 1.15
 diff -u -r1.15 acct.2
 --- acct.2      10 Sep 2003 19:24:33 -0000      1.15
 +++ acct.2      16 Apr 2004 00:29:56 -0000
 @@ -78,6 +78,21 @@
  Accounting is automatically disabled when the file system the
  accounting file resides on runs out of space; it is enabled when
  space once again becomes available.
 +The values controlling this behaviour can be modified using the
 following
 +.Xr sysctl 8
 +variables:
 +.Pp
 +.Bl -tag -width ".Va kern.acct_chkfreq"
 +.It Va kern.acct_chkfreq
 +Specifies the frequency (in minutes) with which free disk
 +space should be checked.
 +.It Va kern.acct_resume
 +The percentage of free disk space above which process
 +accounting will resume.
 +.It Va kern.acct_suspend
 +The percentage of free disk space below which process
 +accounting will suspend.
 +.El
  .Sh RETURN VALUES
  On error -1 is returned.
  The file must exist and the call may be exercised only by the
 super-user.
 @@ -112,6 +127,7 @@
  .El
  .Sh SEE ALSO
  .Xr acct 5 ,
 +.Xr accton 8 ,
  .Xr sa 8
  .Sh HISTORY
  The
 
 
 - Christian
 
 --=20
 Christian Brueffer	chris@unixpages.org	brueffer@FreeBSD.org
 GPG Key:	 http://people.freebsd.org/~brueffer/brueffer.key.asc
 GPG Fingerprint: A5C8 2099 19FF AACA F41B  B29B 6C76 178C A0ED 982D
 
 --D6IIOQQv2Iwyp54J
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAfyrqbHYXjKDtmC0RAi8QAKCtcVQA9+kDPNEoQykVxMSVyEzFOwCgkKqN
 VPLca3U5wVx8/TeBdCIzx5A=
 =yKy3
 -----END PGP SIGNATURE-----
 
 --D6IIOQQv2Iwyp54J--
 

From: Marc Silver <marcs@draenor.org>
To: Christian Brueffer <chris@unixpages.org>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: docs/65070: acct(2) patch
Date: Fri, 16 Apr 2004 13:05:13 +0200

 On Friday, April 16, 2004 2:38 AM +0200 Christian Brueffer 
 <chris@unixpages.org> wrote:
 > New sentences should start on new lines.  Also "these values" is a bit
 > misleading, we haven't talked about any values before.
 
 Noted, thanks.
 
 > This is not very in line with the sysctl lists in other manpages.
 
 My apologies for that.  I used the layout from the sysctl (doctune) manual 
 pages that I was helping Tom Rhodes with.
 
 > What do you think about the following patch?
 
 Fine with me.  :)  Thanks for looking at my submission.
 
 Cheers,
 Marc
 
 -- 
 Marc Silver         | OpenPGP fingerprint:       | DSA KeyID:
 marcs@draenor.org   | 4622 621C C95F D2B5 EFDB   | 0x8BA8C548
                     | 6B75 EB16 C264 8BA8 C548   |
State-Changed-From-To: open->closed 
State-Changed-By: brueffer 
State-Changed-When: Fri Apr 16 22:33:08 CEST 2004 
State-Changed-Why:  
Committed the patch from the followup. 

Thanks for the work! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=65070 
>Unformatted:
