From fullermd@over-yonder.net  Sat Feb 14 03:17:35 2004
Return-Path: <fullermd@over-yonder.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1A50D16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Feb 2004 03:17:35 -0800 (PST)
Received: from praetor.linc-it.com (adsl-068-157-070-217.sip.jan.bellsouth.net [68.157.70.217])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E8A3943D1F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Feb 2004 03:17:34 -0800 (PST)
	(envelope-from fullermd@over-yonder.net)
Received: from mortis.over-yonder.net (adsl-81-244-89.jan.bellsouth.net [65.81.244.89])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by praetor.linc-it.com (Postfix) with ESMTP id A22E1155E4
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Feb 2004 05:17:33 -0600 (CST)
Received: by mortis.over-yonder.net (Postfix, from userid 100)
	id 5D33520F2D; Sat, 14 Feb 2004 05:17:31 -0600 (CST)
Message-Id: <20040214111731.5D33520F2D@mortis.over-yonder.net>
Date: Sat, 14 Feb 2004 05:17:31 -0600 (CST)
From: Matthew D.Fuller <fullermd@over-yonder.net>
Reply-To: Matthew D.Fuller <fullermd@over-yonder.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Login class isn't unused
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         62830
>Category:       docs
>Synopsis:       Login class isn't unused
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dannyboy
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 14 03:20:08 PST 2004
>Closed-Date:    Sun Mar 21 16:47:02 PST 2004
>Last-Modified:  Sun Mar 21 16:47:02 PST 2004
>Originator:     Matthew D. Fuller
>Release:        FreeBSD 5.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD mortis.sighup.org 5.1-RELEASE FreeBSD 5.1-RELEASE #1: Fri Jun 27 22:00:18 CDT 2003 fullermd@mortis.sighup.org:/usr/obj/usr/src/sys/MORTIS i386


	
>Description:
    Despite what passwd(5) suggests, login classes ARE actually used.
    The manpage even mentions it a few lines later  :)

>How-To-Repeat:
    man 5 passwd

>Fix:

Index: passwd.5
===================================================================
RCS file: /usr/cvs/src/share/man/man5/passwd.5,v
retrieving revision 1.40
diff -u -r1.40 passwd.5
--- passwd.5	15 Jan 2003 08:24:45 -0000	1.40
+++ passwd.5	14 Feb 2004 11:16:58 -0000
@@ -79,7 +79,7 @@
 .It gid
 User's login group id.
 .It class
-User's general classification (unused).
+User's login class.
 .It change
 Password change time.
 .It expire
>Release-Note:
>Audit-Trail:

From: Marc Silver <marcs@draenor.org>
To: freebsd-gnats-submit@FreeBSD.org, fullermd@over-yonder.net
Cc:  
Subject: Re: docs/62830: Login class isn't unused
Date: Mon, 16 Feb 2004 09:07:43 +0000

 Hi there,
 
 It may be wise to mention in your patch that the login classes are not
 used *by default*.  I would also add a reference to cap_mkdb(1) in the
 'SEE ALSO' section, as this is required to build the login class
 information.
 
 Cheers,
 Marc
 
 -- 
 Success is never final. Failure is never fatal. It is courage that
 counts.  
   -- Winston Churchill

From: "Matthew D. Fuller" <fullermd@over-yonder.net>
To: Marc Silver <marcs@draenor.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/62830: Login class isn't unused
Date: Mon, 16 Feb 2004 04:08:21 -0600

 On Mon, Feb 16, 2004 at 09:07:43AM +0000 I heard the voice of
 Marc Silver, and lo! it spake thus:
 > 
 > It may be wise to mention in your patch that the login classes are not
 > used *by default*.  I would also add a reference to cap_mkdb(1) in the
 > 'SEE ALSO' section, as this is required to build the login class
 > information.
 
 passwd(5) already mentions login.conf a few lines later when it's
 describing the class:
 
      The class field is a key for a user's login class. Login classes
      are defined in login.conf(5), which is a termcap(5) style
      database of user attributes, accounting, resource, and
      environment settings.
 
 But perhaps a cross-reference to login.conf(5) might be in order;
 xref'ing cap_mkdb doesn't really make sense, since it's used to any
 number of such databases.  So, this might be better:
 
 Index: passwd.5
 ===================================================================
 RCS file: /usr/cvs/src/share/man/man5/passwd.5,v
 retrieving revision 1.40
 diff -u -r1.40 passwd.5
 --- passwd.5	15 Jan 2003 08:24:45 -0000	1.40
 +++ passwd.5	16 Feb 2004 10:06:05 -0000
 @@ -79,7 +79,7 @@
  .It gid
  User's login group id.
  .It class
 -User's general classification (unused).
 +User's login class.
  .It change
  Password change time.
  .It expire
 @@ -311,6 +311,7 @@
  .Xr login 1 ,
  .Xr passwd 1 ,
  .Xr getpwent 3 ,
 +.Xr login.conf 5 ,
  .Xr netgroup 5 ,
  .Xr adduser 8 ,
  .Xr pwd_mkdb 8 ,
 
 
 
 -- 
 Matthew Fuller     (MF4839)   |  fullermd@over-yonder.net
 Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
 
 "The only reason I'm burning my candle at both ends, is because I
       haven't figured out how to light the middle yet"
State-Changed-From-To: open->patched 
State-Changed-By: dannyboy 
State-Changed-When: Sun Mar 21 11:37:02 PST 2004 
State-Changed-Why:  
Fixed in HEAD. 


Responsible-Changed-From-To: freebsd-doc->dannyboy 
Responsible-Changed-By: dannyboy 
Responsible-Changed-When: Sun Mar 21 11:37:02 PST 2004 
Responsible-Changed-Why:  
Fixed in HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62830 
State-Changed-From-To: patched->closed 
State-Changed-By: dannyboy 
State-Changed-When: Sun Mar 21 16:46:40 PST 2004 
State-Changed-Why:  
These changes are already in RELENG_4. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=62830 
>Unformatted:
