From hsn@netmag.cz  Thu Jan 22 03:43:00 2004
Return-Path: <hsn@netmag.cz>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B443A16A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Jan 2004 03:43:00 -0800 (PST)
Received: from mail.tiscali.cz (stateless3.tiscali.cz [213.235.135.72])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 393CC43D53
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Jan 2004 03:42:59 -0800 (PST)
	(envelope-from hsn@netmag.cz)
Received: from asura.bsd (213.235.69.120) by mail.tiscali.cz (6.7.018)
        id 3FB969350109DAC2 for FreeBSD-gnats-submit@freebsd.org; Thu, 22 Jan 2004 12:42:58 +0100
Received: from hsn by asura.bsd with local (Exim 4.24 #4 (Debian))
	id 1Ajcb4-0000Uh-Ep
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Jan 2004 12:02:02 +0100
Message-Id: <E1Ajcb4-0000Uh-Ep@asura.bsd>
Date: Thu, 22 Jan 2004 12:02:02 +0100
From: Radim Kolar <hsn@netmag.cz>
Reply-To: Radim Kolar <hsn@netmag.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: newfs: code and manpage are out of sync
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         61716
>Category:       docs
>Synopsis:       [patch] newfs(8) code and manpage are out of sync
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gjb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 22 03:50:11 PST 2004
>Closed-Date:    Mon Feb 07 19:13:51 UTC 2011
>Last-Modified:  Mon Feb  7 19:20:07 UTC 2011
>Originator:     Radim Kolar
>Release:        FreeBSD 5.2-RELEASE i386
>Organization:
Sanatana Dharma
>Environment:
System: FreeBSD asura.bsd 5.2-RELEASE FreeBSD 5.2-RELEASE #0: Thu Jan 15 18:35:03 CET 2004 root@asura.bsd:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Manual page newfs(8) says that default size of max-entent-size (option -d)
is 16*blocksize. 
/usr/src/sbin/newfs/newfs.c line 338-339 sets default 
max-entent-size to blocksize. This leads to poor admin confusion.

>How-To-Repeat:
>Fix:
I do not know what extent size is better for performance.
Newfs should create filesystems with best performance options set as default,
since very few people are playing with various newfs flags.
Please update code or manpage.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mckusick 
Responsible-Changed-By: cperciva 
Responsible-Changed-When: Fri Jan 23 18:00:58 PST 2004 
Responsible-Changed-Why:  
Assign to Mr. UFS2 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61716 
State-Changed-From-To: open->analyzed 
State-Changed-By: arundel 
State-Changed-When: Fri Aug 20 23:13:12 UTC 2010 
State-Changed-Why:  
The originator of the PR described the problem very accurately. 

However the location where the default max-extent-size gets set has moved from 
/usr/src/sbin/newfs/newfs.c to usr.sbin/newfs/mkfs.c: 

224 	if (maxbsize == 0) 
225 		maxbsize = bsize; 
226 	if (maxbsize < bsize || !POWEROF2(maxbsize)) { 
227 		sblock.fs_maxbsize = sblock.fs_bsize; 
228 		printf("Extent size set to %dn", sblock.fs_maxbsize); 
229 	} else if (sblock.fs_maxbsize > FS_MAXCONTIG * sblock.fs_bsize) { 
230 		sblock.fs_maxbsize = FS_MAXCONTIG * sblock.fs_bsize; 
231 		printf("Extent size reduced to %dn", sblock.fs_maxbsize); 
232 	} else { 
233 		sblock.fs_maxbsize = maxbsize; 
234 	} 

I'll submit a patch for newfs(8) right away. 


Responsible-Changed-From-To: mckusick->freebsd-fs 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Fri Aug 20 23:13:12 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61716 

From: Alexander Best <arundel@freebsd.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: docs/61716: newfs(8) code and manpage are out of sync
Date: Fri, 20 Aug 2010 23:39:38 +0000

 --opJtzjQTFsWo+cga
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 This patch should sync the newfs code with newfs(8).
 
 cheers.
 alex
 
 -- 
 a13x
 
 --opJtzjQTFsWo+cga
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="newfs.8.diff"
 
 Index: /usr/src/sbin/newfs/newfs.8
 ===================================================================
 --- /usr/src/sbin/newfs/newfs.8	(revision 211393)
 +++ /usr/src/sbin/newfs/newfs.8	(working copy)
 @@ -125,8 +125,9 @@
  .It Fl d Ar max-extent-size
  The file system may choose to store large files using extents.
  This parameter specifies the largest extent size that may be used.
 -It is presently limited to its default value which is 16 times
 -the file system blocksize.
 +The default value is the file system blocksize.
 +It is presently limited to a maximum value of 16 times the
 +file system blocksize and a minimum value of the file system blocksize.
  .It Fl e Ar maxbpg
  Indicate the maximum number of blocks any single file can
  allocate out of a cylinder group before it is forced to begin
 
 --opJtzjQTFsWo+cga--
Class-Changed-From-To: sw-bug->doc-bug 
Class-Changed-By: arundel 
Class-Changed-When: Sat Aug 21 11:05:10 UTC 2010 
Class-Changed-Why:  
This is not a sw-bug. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=61716 

From: Alexander Best <arundel@freebsd.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: docs/61716: [patch] newfs(8) code and manpage are out of sync
Date: Tue, 24 Aug 2010 23:40:24 +0000

 to the person committing the patch to the newfs(8) manual:
 
 please bump the date to "August 20, 2010".
 
 thanks.
 alex
 
 -- 
 a13x
Responsible-Changed-From-To: freebsd-fs->gjb 
Responsible-Changed-By: gjb 
Responsible-Changed-When: Mon Sep 13 12:59:45 UTC 2010 
Responsible-Changed-Why:  
I'll take this. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=61716 
State-Changed-From-To: analyzed->patched 
State-Changed-By: gjb 
State-Changed-When: Tue Sep 14 12:12:22 UTC 2010 
State-Changed-Why:  
Patched in HEAD.  MFC in 1 week. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=61716 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/61716: commit references a PR
Date: Tue, 14 Sep 2010 12:12:13 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Tue Sep 14 12:12:07 2010
 New Revision: 212610
 URL: http://svn.freebsd.org/changeset/base/212610
 
 Log:
   Synchronize newfs(8) manual with code.
   
   PR:		61716
   Submitted by:	Radim Kolar <hsn at netmag cz>
   Patch by:	arundel
   Approved by:	keramida (mentor)
   MFC after:	1 week
 
 Modified:
   head/sbin/newfs/newfs.8
 
 Modified: head/sbin/newfs/newfs.8
 ==============================================================================
 --- head/sbin/newfs/newfs.8	Tue Sep 14 11:42:07 2010	(r212609)
 +++ head/sbin/newfs/newfs.8	Tue Sep 14 12:12:07 2010	(r212610)
 @@ -28,7 +28,7 @@
  .\"     @(#)newfs.8	8.6 (Berkeley) 5/3/95
  .\" $FreeBSD$
  .\"
 -.Dd March 21, 2008
 +.Dd September 14, 2010
  .Dt NEWFS 8
  .Os
  .Sh NAME
 @@ -125,8 +125,9 @@ and the number of bytes per inode.
  .It Fl d Ar max-extent-size
  The file system may choose to store large files using extents.
  This parameter specifies the largest extent size that may be used.
 -It is presently limited to its default value which is 16 times
 -the file system blocksize.
 +The default value is the file system blocksize.
 +It is presently limited to a maximum value of 16 times the
 +file system blocksize and a minimum value of the file system blocksize.
  .It Fl e Ar maxbpg
  Indicate the maximum number of blocks any single file can
  allocate out of a cylinder group before it is forced to begin
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gjb 
State-Changed-When: Mon Feb 7 19:13:28 UTC 2011 
State-Changed-Why:  
MFC'd to stable/8 and stable/7.  Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=61716 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/61716: commit references a PR
Date: Mon,  7 Feb 2011 19:12:35 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Mon Feb  7 19:12:30 2011
 New Revision: 218412
 URL: http://svn.freebsd.org/changeset/base/218412
 
 Log:
   MFC 212610:
   Synchronize newfs(8) manual with code.
   
   PR:		61716
   Approved by:	keramida (mentor)
 
 Modified:
   stable/8/sbin/newfs/newfs.8
 Directory Properties:
   stable/8/sbin/newfs/   (props changed)
 
 Modified: stable/8/sbin/newfs/newfs.8
 ==============================================================================
 --- stable/8/sbin/newfs/newfs.8	Mon Feb  7 18:10:18 2011	(r218411)
 +++ stable/8/sbin/newfs/newfs.8	Mon Feb  7 19:12:30 2011	(r218412)
 @@ -125,8 +125,9 @@ and the number of bytes per inode.
  .It Fl d Ar max-extent-size
  The file system may choose to store large files using extents.
  This parameter specifies the largest extent size that may be used.
 -It is presently limited to its default value which is 16 times
 -the file system blocksize.
 +The default value is the file system blocksize.
 +It is presently limited to a maximum value of 16 times the
 +file system blocksize and a minimum value of the file system blocksize.
  .It Fl e Ar maxbpg
  Indicate the maximum number of blocks any single file can
  allocate out of a cylinder group before it is forced to begin
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/61716: commit references a PR
Date: Mon,  7 Feb 2011 19:13:26 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Mon Feb  7 19:13:20 2011
 New Revision: 218413
 URL: http://svn.freebsd.org/changeset/base/218413
 
 Log:
   MFC 212610:
   Synchronize newfs(8) manual with code.
   
   PR:		61716
   Approved by:	keramida (mentor)
 
 Modified:
   stable/7/sbin/newfs/newfs.8
 Directory Properties:
   stable/7/sbin/newfs/   (props changed)
 
 Modified: stable/7/sbin/newfs/newfs.8
 ==============================================================================
 --- stable/7/sbin/newfs/newfs.8	Mon Feb  7 19:12:30 2011	(r218412)
 +++ stable/7/sbin/newfs/newfs.8	Mon Feb  7 19:13:20 2011	(r218413)
 @@ -28,7 +28,7 @@
  .\"     @(#)newfs.8	8.6 (Berkeley) 5/3/95
  .\" $FreeBSD$
  .\"
 -.Dd March 21, 2008
 +.Dd September 14, 2010
  .Dt NEWFS 8
  .Os
  .Sh NAME
 @@ -116,8 +116,9 @@ and the number of bytes per inode.
  .It Fl d Ar max-extent-size
  The file system may choose to store large files using extents.
  This parameter specifies the largest extent size that may be used.
 -It is presently limited to its default value which is 16 times
 -the file system blocksize.
 +The default value is the file system blocksize.
 +It is presently limited to a maximum value of 16 times the
 +file system blocksize and a minimum value of the file system blocksize.
  .It Fl e Ar maxbpg
  Indicate the maximum number of blocks any single file can
  allocate out of a cylinder group before it is forced to begin
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
