From maneo@staff.seccuris.com  Sun Oct 26 17:20:57 2003
Return-Path: <maneo@staff.seccuris.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7D6B316A4B3
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 26 Oct 2003 17:20:57 -0800 (PST)
Received: from staff.seccuris.com (staff.seccuris.com [204.112.0.40])
	by mx1.FreeBSD.org (Postfix) with SMTP id 98A7343F93
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 26 Oct 2003 17:20:54 -0800 (PST)
	(envelope-from maneo@staff.seccuris.com)
Received: (qmail 46048 invoked by uid 1006); 27 Oct 2003 01:20:53 -0000
Message-Id: <20031027012053.46047.qmail@staff.seccuris.com>
Date: 27 Oct 2003 01:20:53 -0000
From: Chris S.J.Peron <maneo@bsdpro.com>
Reply-To: Chris S.J.Peron <maneo@bsdpro.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] ng_one2many interface status requirements
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         58586
>Category:       docs
>Synopsis:       [patch] ng_one2many interface status requirements
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wes
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 26 17:30:15 PST 2003
>Closed-Date:    Tue Feb 17 21:34:56 PST 2004
>Last-Modified:  Tue Feb 17 21:34:56 PST 2004
>Originator:     Chris S.J. Peron
>Release:        FreeBSD 4.8-RELEASE-p13 i386
>Organization:
>Environment:
System: FreeBSD staff 4.8-RELEASE-p13 FreeBSD 4.8-RELEASE-p13 #1: Sat Oct 25 16:45:55 UTC 2003 yboily@staff:/usr/src/sys/compile/STAFF i386


	
>Description:
ng_one2many(4) does not tell the users their network
interface must be ``up'' before they can link them
into a group properly.


	
>How-To-Repeat:
	N/A
Fix:

--- share/man/man4/ng_one2many.4.0	Sun Oct 26 02:38:51 2003
+++ share/man/man4/ng_one2many.4	Sun Oct 26 02:15:05 2003
@@ -71,6 +71,17 @@
 Packets are never delivered out a many hook that is down.
 How a link is determined to be up or down depends on the node's
 configured link failure detection algorithm.
+.Pp
+Before an interface or link can be plumbed into a group, its status
+must be marked as being
+.Dq up .
+This is normally setup during the initial boot stages by
+.Xr rc.conf 5 . 
+It's also possible to change an interfaces status to
+.Dq up 
+by using the
+.Xr ifconfig 8
+utility. 
 .Sh TRANSMIT ALGORITHMS
 .Bl -tag -width foo
 .It NG_ONE2MANY_XMIT_ROUNDROBIN
@@ -179,22 +190,29 @@
 .Dv fxp3 :
 .Bd -literal -offset 0n
   # Plumb nodes together
+
   ngctl mkpeer fxp0: one2many upper one
   ngctl connect fxp0: fxp0:upper lower many0
   ngctl connect fxp1: fxp0:upper lower many1
   ngctl connect fxp2: fxp0:upper lower many2
   ngctl connect fxp3: fxp0:upper lower many3
+
   # Allow fxp1 through fxp3 to xmit/recv fxp0 frames
+
   ngctl msg fxp1: setpromisc 1
   ngctl msg fxp2: setpromisc 1
   ngctl msg fxp3: setpromisc 1
   ngctl msg fxp1: setautosrc 0
   ngctl msg fxp2: setautosrc 0
   ngctl msg fxp3: setautosrc 0
+
   # Configure all four links as up
+
   ngctl msg fxp0:upper \\
     setconfig "{ xmitAlg=1 failAlg=1 enabledLinks=[ 1 1 1 1 ] }"
+
   # Bring up interface
+
   ifconfig fxp0 192.168.1.1 netmask 0xfffffffc
 .Ed
 .Pp
@@ -206,6 +224,7 @@
 More transmit and link failure algorithms should be supported.
 A good candidate is Cisco's Etherchannel.
 .Sh SEE ALSO
+.Xr ifconfig 8 ,
 .Xr netgraph 4 ,
 .Xr ng_bridge 4 ,
 .Xr ng_ether 4 ,
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: wes 
State-Changed-When: Thu Jan 22 21:24:36 PST 2004 
State-Changed-Why:  
Fix from PR committed: 

wes         2004/01/22 21:24:06 PST

  FreeBSD src repository

  Modified files:
    share/man/man4       ng_one2many.4 
  Log:
  PR:             docs/58586
  Submitted by:   Chris S.J. Peron <maneo@bsdpro.com>
  
  Revision  Changes    Path
  1.13      +19 -0     src/share/man/man4/ng_one2many.4


Responsible-Changed-From-To: freebsd-doc->wes 
Responsible-Changed-By: wes 
Responsible-Changed-When: Thu Jan 22 21:24:36 PST 2004 
Responsible-Changed-Why:  
Fixed it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=58586 
State-Changed-From-To: closed->feedback 
State-Changed-By: wes 
State-Changed-When: Thu Jan 22 21:34:26 PST 2004 
State-Changed-Why:  
Oops, we usually put these in feedback first, right? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=58586 
State-Changed-From-To: feedback->closed 
State-Changed-By: wes 
State-Changed-When: Tue Feb 17 21:33:56 PST 2004 
State-Changed-Why:  
Nobody has freaked yet, this one MUST have been OK. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=58586 
>Unformatted:
