From simon@comsys.ntu-kpi.kiev.ua  Mon Sep  8 00:15:08 2003
Return-Path: <simon@comsys.ntu-kpi.kiev.ua>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6C3E116A4BF
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Sep 2003 00:15:08 -0700 (PDT)
Received: from relay1.ntu-kpi.kiev.ua (oberon.ntu-kpi.kiev.ua [195.245.194.35])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E276143FE3
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Sep 2003 00:15:05 -0700 (PDT)
	(envelope-from simon@comsys.ntu-kpi.kiev.ua)
Received: from comsys.ntu-kpi.kiev.ua (eth0.comsys.ntu-kpi.kiev.ua [10.0.1.184])
	by relay1.ntu-kpi.kiev.ua (Postfix) with ESMTP id 46F7219CEA
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Sep 2003 10:15:01 +0300 (EEST)
Received: from pm514-9.comsys.ntu-kpi.kiev.ua (pm514-9.comsys.ntu-kpi.kiev.ua [10.18.54.109])
	by comsys.ntu-kpi.kiev.ua (8.11.6/8.11.6) with ESMTP id h887Jc451118
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 8 Sep 2003 10:19:38 +0300 (EEST)
Received: by pm514-9.comsys.ntu-kpi.kiev.ua (Postfix, from userid 1000)
	id 6136B225; Mon,  8 Sep 2003 10:14:58 +0300 (EEST)
Message-Id: <20030908071458.GA197@pm514-9.comsys.ntu-kpi.kiev.ua>
Date: Mon, 8 Sep 2003 10:14:58 +0300
From: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Updates for VOP_GETPAGES(9) and VOP_PUTPAGES(9)

>Number:         56584
>Category:       docs
>Synopsis:       Updates for VOP_GETPAGES(9) and VOP_PUTPAGES(9)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    hmp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 08 00:20:07 PDT 2003
>Closed-Date:    Mon May 10 15:47:17 PDT 2004
>Last-Modified:  Mon May 10 15:47:17 PDT 2004
>Originator:     Andrey Simonenko
>Release:        FreeBSD 4.8-STABLE and 5.1-RELEASE
>Organization:
>Environment:
>Description:

I suppose that VOP_GETPAGES(9) and VOP_PUTPAGES(9) contain mistakes,
also following patch adds descriptions for not described previously
arguments.

Comments?

>How-To-Repeat:
>Fix:
--- VOP_GETPAGES.9.orig	Thu Jun  5 04:56:16 2003
+++ VOP_GETPAGES.9	Sun Sep  7 23:04:59 2003
@@ -40,29 +40,33 @@
 .In sys/vnode.h
 .In vm/vm.h
 .Ft int
-.Fn VOP_GETPAGES "struct vnode *vp" "vm_page_t *m" "int count" "int reqpage" "vm_ooffset_t offset"
+.Fn VOP_GETPAGES "struct vnode *vp" "vm_page_t *m" "int bytecount" "int reqpage" "vm_ooffset_t offset"
 .Ft int
-.Fn VOP_PUTPAGES "struct vnode *vp" "vm_page_t *m" "int count" "int sync" "int *rtvals" "vm_ooffset_t offset"
+.Fn VOP_PUTPAGES "struct vnode *vp" "vm_page_t *m" "int bytecount" "int sync" "int *rtvals" "vm_ooffset_t offset"
 .Sh DESCRIPTION
+These entry points read and write VM pages from a file respectively.
+.Pp
 The arguments are:
 .Bl -tag -width reqpage
 .It Ar vp
 The file to access.
 .It Ar m
-A page ???
-.It Ar count
-How many pages to access.
+The array of vm_page_t.
+.It Ar bytecount
+How many bytes to access (multiple of the page size), should be
+divided by the page size to get the number of elements in the array
+.Ar m .
 .It Ar sync
 Nonzero if the write should be synchronous.
 .It Ar rtvals
-???
+The array of return values for corresponding pages in the array
+.Ar m .
 .It Ar reqpage
-???
+The index of the requested page in the array
+.Ar m .
 .It Ar offset
 Offset in the file to start accessing.
 .El
-.Pp
-Not quite sure about this one.
 .Sh RETURN VALUES
 Zero is returned on success, otherwise an error is returned.
 .Sh SEE ALSO
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->hmp 
Responsible-Changed-By: hmp 
Responsible-Changed-When: Sun Sep 14 15:58:02 PDT 2003 
Responsible-Changed-Why:  
I will deal with this sometime soon. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=56584 
State-Changed-From-To: open->closed 
State-Changed-By: hmp 
State-Changed-When: Mon May 10 15:47:01 PDT 2004 
State-Changed-Why:  
Some or most changes have been committed.  Thanks. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=56584 
>Unformatted:
 To: FreeBSD-gnats-submit@freebsd.org
 From: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
 Reply-To: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
 Cc: 
 X-send-pr-version: 3.113
 X-GNATS-Notify: 
 
 
