From mreimer@bilbo.vpop.net  Fri Aug  8 09:59:44 2003
Return-Path: <mreimer@bilbo.vpop.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1D56A37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  8 Aug 2003 09:59:44 -0700 (PDT)
Received: from bilbo.vpop.net (bilbo.vpop.net [65.103.33.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3134E43F75
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  8 Aug 2003 09:59:43 -0700 (PDT)
	(envelope-from mreimer@bilbo.vpop.net)
Received: from bilbo.vpop.net (localhost [127.0.0.1])
	by bilbo.vpop.net (8.12.9/8.12.9) with ESMTP id h78GxuHI062452
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 8 Aug 2003 11:59:57 -0500 (CDT)
	(envelope-from mreimer@bilbo.vpop.net)
Received: (from mreimer@localhost)
	by bilbo.vpop.net (8.12.9/8.12.9/Submit) id h78GxtW2062451;
	Fri, 8 Aug 2003 11:59:55 -0500 (CDT)
Message-Id: <200308081659.h78GxtW2062451@bilbo.vpop.net>
Date: Fri, 8 Aug 2003 11:59:55 -0500 (CDT)
From: Matthew Reimer <mreimer@bilbo.vpop.net>
Reply-To: Matthew Reimer <mreimer@bilbo.vpop.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: plist generation instructions incorrect
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         55391
>Category:       docs
>Synopsis:       plist generation instructions incorrect
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tom
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 08 10:00:33 PDT 2003
>Closed-Date:    Wed Sep 10 03:21:35 PDT 2003
>Last-Modified:  Wed Sep 10 03:21:35 PDT 2003
>Originator:     Matthew Reimer
>Release:        FreeBSD 4.8-STABLE i386
>Organization:
VPOP Technologies, Inc.
>Environment:
System: FreeBSD bilbo.vpop.net 4.8-STABLE FreeBSD 4.8-STABLE #8: Mon Jul 28 16:56:35 CDT 2003 mreimer@bilbo.vpop.net:/usr/obj/usr/src/sys/BILBO i386



>Description:

	The instructions in the Porter's handbook (porting-autoplist.html)
	on how to generate a plist are incorrect. Twice on this page the
	-r argument is passed to sort which breaks the use of comm in the
	last command.

>How-To-Repeat:
	
>Fix:

	Don't pass -r to sort either time sort is used.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->tom 
Responsible-Changed-By: tom 
Responsible-Changed-When: Wed Aug 27 07:05:51 PDT 2003 
Responsible-Changed-Why:  
I'll take this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55391 

From: Tom Hukins <tom@FreeBSD.org>
To: Matthew Reimer <mreimer@bilbo.vpop.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/55391: plist generation instructions incorrect
Date: Thu, 28 Aug 2003 19:57:34 +0100

 --xHFwDpU9dbj6ez1V
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Fri, Aug 08, 2003 at 11:59:55AM -0500, Matthew Reimer wrote:
 > 
 > 	The instructions in the Porter's handbook (porting-autoplist.html)
 > 	on how to generate a plist are incorrect. Twice on this page the
 > 	-r argument is passed to sort which breaks the use of comm in the
 > 	last command.
 
 Please take a look at this patch and let me know if it fixes the
 problem.
 
 Tom
 
 --xHFwDpU9dbj6ez1V
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="plist.patch"
 
 ? book.html
 ? index.sgml
 Index: book.sgml
 ===================================================================
 RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
 retrieving revision 1.322
 diff -u -r1.322 book.sgml
 --- book.sgml	19 Aug 2003 16:32:20 -0000	1.322
 +++ book.sgml	28 Aug 2003 18:56:16 -0000
 @@ -6160,7 +6160,7 @@
  
        <para>Store the directory structure in a new file.</para>
  
 -      <screen>&prompt.root; <userinput>(cd /var/tmp/<replaceable>port-name</replaceable> && find -d * -type d) | sort -r &gt; OLD-DIRS</userinput></screen>
 +      <screen>&prompt.root; <userinput>(cd /var/tmp/<replaceable>port-name</replaceable> && find -d * -type d) | sort &gt; OLD-DIRS</userinput></screen>
  
        <para>If your port honors <makevar>PREFIX</makevar> (which it should)
          you can then install the port and create the package list.</para>
 @@ -6171,7 +6171,7 @@
        <para>You must also add any newly created directories to the packing
          list.</para>
  
 -      <screen>&prompt.root; <userinput>(cd /var/tmp/<replaceable>port-name</replaceable> && find -d * -type d) | sort -r | comm -13 OLD-DIRS - | sed -e 's#^#@dirrm #' &gt;&gt; pkg-plist</userinput></screen>
 +      <screen>&prompt.root; <userinput>(cd /var/tmp/<replaceable>port-name</replaceable> && find -d * -type d) | sort | comm -13 OLD-DIRS - | sort -r | sed -e 's#^#@dirrm #' &gt;&gt; pkg-plist</userinput></screen>
  
        <para>Finally, you need to tidy up the packing list by hand; it is not
          <emphasis>all</emphasis> automated.  Manual pages should be listed in
 
 --xHFwDpU9dbj6ez1V--
State-Changed-From-To: open->closed 
State-Changed-By: tom 
State-Changed-When: Wed Sep 10 03:21:04 PDT 2003 
State-Changed-Why:  
Committed in revision 1.327 of porters-handbook/book.sgml 

http://www.freebsd.org/cgi/query-pr.cgi?pr=55391 
>Unformatted:
