From mwm@mired.org  Sat Apr 26 08:34:54 2003
Return-Path: <mwm@mired.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 84BF437B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Apr 2003 08:34:54 -0700 (PDT)
Received: from mired.org (ip68-97-54-220.ok.ok.cox.net [68.97.54.220])
	by mx1.FreeBSD.org (Postfix) with SMTP id B367D43F93
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 Apr 2003 08:34:53 -0700 (PDT)
	(envelope-from mwm@mired.org)
Received: (qmail 13429 invoked by uid 100); 26 Apr 2003 15:34:52 -0000
Message-Id: <20030426153452.13414.qmail@mired.org>
Date: 26 Apr 2003 15:34:52 -0000
From: Mike Meyer <mwm@mired.org>
Reply-To: Mike Meyer <mwm@mired.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] The handbook script for dealing with postscript is broken
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         51444
>Category:       docs
>Synopsis:       [PATCH] The handbook script for dealing with postscript is broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    hrs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 26 08:40:11 PDT 2003
>Closed-Date:    Sun Apr 27 02:18:55 PDT 2003
>Last-Modified:  Sun Apr 27 02:18:55 PDT 2003
>Originator:     Mike Meyer
>Release:        FreeBSD 4.8-PRERELEASE i386
>Organization:
Meyer Consulting
>Environment:
System: FreeBSD guru.mired.org 4.8-PRERELEASE FreeBSD 4.8-PRERELEASE #18: Mon Feb 24 12:02:57 CST 2003 mwm@guru.mired.org:/sharetmp/obj/usr/src/sys/GURU i386

>Description:
	The handbook script for filtering postscript through gs is
	broken. It includes a second, unneeded invocation of gs that was
	probably meant to be commented out without explanation, and is
	missing a continuation mark on one command.
>How-To-Repeat:
	Read the handbook chapter on advanced printing, looking for
	"gs ".
>Fix:
	The attached patch removes the extra invocation, and adds in
	the  line continuation needed to make the script work properly.

--- chapter.sgml	Mon Feb 24 09:52:54 2003
+++ /tmp/chapter.sgml	Sat Apr 26 10:11:47 2003
@@ -1928,13 +1928,10 @@
     #  capture the stderr output from Ghostscript and mail it back to
     #  the user originating the print job.
     #
-    exec 3&gt;&amp;1 1&gt;&amp;2
+    exec 3&gt;&amp;1 1&gt;&amp;2 \
     /usr/local/bin/gs -dSAFER -dNOPAUSE -q -sDEVICE=djet500 \
         -sOutputFile=/dev/fd/3 - &amp;&amp; exit 0
 
-    #
-    /usr/local/bin/gs -dSAFER -dNOPAUSE -q -sDEVICE=djet500 -sOutputFile=- - \
-        &amp;&amp; exit 0
 else
     #
     #  Plain text or HP/PCL, so just print it directly; print a form feed



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->hrs 
Responsible-Changed-By: hrs 
Responsible-Changed-When: Sun Apr 27 01:29:31 PDT 2003 
Responsible-Changed-Why:  
I'll work on this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51444 
State-Changed-From-To: open->closed 
State-Changed-By: hrs 
State-Changed-When: Sun Apr 27 02:14:40 PDT 2003 
State-Changed-Why:  
Your patch was committed, but the continuation mark was not added. 
If the mark exists, the script does not exit "2" (needed for 
lpd(8)) when an error occurs.  And I think it does not break 
the functionality.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51444 
>Unformatted:
