From henrik.motakef@web.de  Fri Mar 21 18:02:57 2003
Return-Path: <henrik.motakef@web.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0AEA037B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 21 Mar 2003 18:02:57 -0800 (PST)
Received: from smtp.web.de (smtp03.web.de [217.72.192.158])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 33E2743F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 21 Mar 2003 18:02:56 -0800 (PST)
	(envelope-from henrik.motakef@web.de)
Received: from [213.23.208.86] (helo=interim.henrik-motakef.de)
	by smtp.web.de with esmtp (WEB.DE(Exim) 4.97 #53)
	id 18wYLW-0007NR-00
	for FreeBSD-gnats-submit@freebsd.org; Sat, 22 Mar 2003 03:02:55 +0100
Received: by interim.henrik-motakef.de (Postfix, from userid 1000)
	id 0D4BC2309; Sat, 22 Mar 2003 03:06:59 +0100 (CET)
Message-Id: <20030322020659.0D4BC2309@interim.henrik-motakef.de>
Date: Sat, 22 Mar 2003 03:06:59 +0100 (CET)
From: Henrik Motakef <henrik.motakef@web.de>
Sender: henrik.motakef@web.de
Reply-To: Henrik Motakef <henrik.motakef@web.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Broken examples for WRKSRC usage in porter's handbook
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         50182
>Category:       docs
>Synopsis:       Broken examples for WRKSRC usage in porter's handbook
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ceri
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 21 18:10:11 PST 2003
>Closed-Date:    Wed Apr 02 13:12:41 PST 2003
>Last-Modified:  Wed Apr 02 13:12:41 PST 2003
>Originator:     Henrik Motakef
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD interim.henrik-motakef.de 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Sun Feb 16 11:53:08 CET 2003 henrik@interim.henrik-motakef.de:/usr/obj/usr/src/sys/INTERIM i386
>Description:
	The examples given in section 4.8.1. "WRKSRC" of The Porter's Handbook
	don't work in practice: They set the WRKSRC variable to the name of a
	relative directory, but it has to be an absolute path.

	This patch updates the examples to set WRKSRC relative ${WRKDIR}. This
	is in line with the default set in bsd.port.mk, where WRKSRC is 
	initialized to ${WRKDIR}/${DISTNAME}.

>How-To-Repeat:
	- Read http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-wrkdir.html#AEN1877
	- Try to set WRKSRC to ${PORTNAME} in a port makefile, like the
	  example suggests.

>Fix:
--- book.sgml.orig	Sat Mar 22 02:48:09 2003
+++ book.sgml	Sat Mar 22 02:50:21 2003
@@ -2996,11 +2996,11 @@
 	  extracted into a directory called <filename>foo</filename> (and not
 	  <filename>foo-1.0</filename>) you would write:</para>
 
-	<programlisting>WRKSRC=      foo</programlisting>
+	<programlisting>WRKSRC=      ${WRKDIR}/foo</programlisting>
 
 	<para>or possibly</para>
 
-	<programlisting>WRKSRC=      ${PORTNAME}</programlisting>
+	<programlisting>WRKSRC=      ${WRKDIR}/${PORTNAME}</programlisting>
       </sect2>
 
       <sect2>
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->ceri 
Responsible-Changed-By: ceri 
Responsible-Changed-When: Sat Mar 22 01:17:47 PST 2003 
Responsible-Changed-Why:  
I'll take care of this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50182 
State-Changed-From-To: open->closed 
State-Changed-By: ceri 
State-Changed-When: Wed Apr 2 13:12:20 PST 2003 
State-Changed-Why:  
Your patch was committed; thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=50182 
>Unformatted:
