From mwm@mired.org  Sun Feb  9 10:13:32 2003
Return-Path: <mwm@mired.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 77D7337B405
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  9 Feb 2003 10:13:32 -0800 (PST)
Received: from mired.org (ip68-97-54-220.ok.ok.cox.net [68.97.54.220])
	by mx1.FreeBSD.org (Postfix) with SMTP id 5E21F43FB1
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  9 Feb 2003 10:13:31 -0800 (PST)
	(envelope-from mwm@mired.org)
Received: (qmail 16894 invoked by uid 100); 9 Feb 2003 18:13:30 -0000
Message-Id: <20030209181330.16893.qmail@mired.org>
Date: 9 Feb 2003 18:13:30 -0000
From: Mike Meyer <mwm@mired.org>
Reply-To: Mike Meyer <mwm@mired.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] Porters handbook uses wrong macro for strip
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         48111
>Category:       docs
>Synopsis:       [PATCH] Porters handbook uses wrong macro for strip
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 09 10:20:07 PST 2003
>Closed-Date:    Tue Feb 11 05:38:53 PST 2003
>Last-Modified:  Tue Feb 11 05:38:53 PST 2003
>Originator:     Mike Meyer
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
Meyer Consulting
>Environment:
System: FreeBSD guru.mired.org 4.7-STABLE FreeBSD 4.7-STABLE #17: Wed Oct 30 09:13:02 CST 2002 mwm@guru.mired.org:/sharetmp/obj/usr/src/sys/GURU i386

>Description:
	The porters handbook says to use the ${STRIP} macro to strip binaries
	(assuming you aren't using ${INSTALL_PROGRAM} to do it), but it
	really should use $(STRIP_CMD).
>How-To-Repeat:
	Read the porters handbook, and then try using it.
>Fix:

This patch fixes the porters handbook to recommend the proper macro.

--- book.sgml-orig	Sun Feb  9 12:10:13 2003
+++ book.sgml	Sun Feb  9 12:10:46 2003
@@ -4586,12 +4586,12 @@
 
         <para>If you need to strip a file, but do not wish to use the
           <makevar>INSTALL_PROGRAM</makevar> macro,
-          <makevar>${STRIP}</makevar> will strip your program.  This is
+          <makevar>${STRIP_CMD}</makevar> will strip your program.  This is
           typically done within the <literal>post-install</literal>
           target.  For example:</para>
 
         <programlisting>post-install:
-        ${STRIP} ${PREFIX}/bin/xdl</programlisting>
+        ${STRIP_CMD} ${PREFIX}/bin/xdl</programlisting>
 
         <para>Use the &man.file.1; command on the installed executable to
           check whether the binary is stripped or not.  If it does not say



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Tue Feb 11 05:17:57 PST 2003 
State-Changed-Why:  
I just can't believe that.  I had this change for more than three 
months sitting in my tree, and the day I decide to commit it, you 
stumble upon it too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=48111 
>Unformatted:
