From adamw@FreeBSD.org  Tue Oct 22 15:35:13 2002
Return-Path: <adamw@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D84237B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 22 Oct 2002 15:35:13 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0610A43E3B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 22 Oct 2002 15:35:13 -0700 (PDT)
	(envelope-from adamw@FreeBSD.org)
Received: from freefall.freebsd.org (adamw@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9MMZCx3040834
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 22 Oct 2002 15:35:12 -0700 (PDT)
	(envelope-from adamw@freefall.freebsd.org)
Received: (from adamw@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9MMZCSt040833;
	Tue, 22 Oct 2002 15:35:12 -0700 (PDT)
Message-Id: <200210222235.g9MMZCSt040833@freefall.freebsd.org>
Date: Tue, 22 Oct 2002 15:35:12 -0700 (PDT)
From: Adam Weinberger <adamw@freebsd.org>
Reply-To: Adam Weinberger <adamw@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Section 15.1 of the Porter's Handbook is no longer applicable
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         44396
>Category:       docs
>Synopsis:       Section 15.1 of the Porter's Handbook is no longer applicable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 22 15:40:02 PDT 2002
>Closed-Date:    Tue Oct 29 08:17:47 PST 2002
>Last-Modified:  Tue Oct 29 08:17:47 PST 2002
>Originator:     Adam Weinberger
>Release:        FreeBSD 4.7-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 4.7-STABLE FreeBSD 4.7-STABLE #6: Tue Oct 15 17:20:55 PDT 2002 peter@freefall.freebsd.org:/c/src/sys/compile/FREEFALL i386


	
>Description:
	Section 15.1 of the Porter's Handbook instructs people to create a post-install:
	target to strip binaries if the port doesn't do it. However, INSTALL_PROGRAM does
	this automatically, and that macro is described in the very next section.
	
>How-To-Repeat:
	
>Fix:
	Whack section 15.1 of the Porter's Handbook.

root@smacky:/usr/doc/en_US.ISO8859-1/books/porters-handbook# diff -u book.sgml.orig book.sgml
--- book.sgml.orig      Tue Oct 22 15:32:33 2002
+++ book.sgml   Tue Oct 22 15:32:47 2002
@@ -3938,22 +3938,6 @@
         doing.</para>
 
       <sect1>
-        <title>Strip Binaries</title>
-
-        <para>Do strip binaries.  If the original source already strips the
-          binaries, fine; otherwise you should add a
-          <literal>post-install</literal> rule to it yourself.  Here is an
-          example:</para>
-
-        <programlisting>post-install:
-        strip ${PREFIX}/bin/xdl</programlisting>
-
-        <para>Use the &man.file.1; command on the installed executable to
-          check whether the binary is stripped or not.  If it does not say
-          <literal>not stripped</literal>, it is stripped.</para>
-      </sect1>
-
-      <sect1>
         <title>INSTALL_* macros</title>
 
         <para>Do use the macros provided in <filename>bsd.port.mk</filename>

	


>Release-Note:
>Audit-Trail:

From: Tom Hukins <tom@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, adamw@freebsd.org
Cc:  
Subject: Re: docs/44396: Section 15.1 of the Porter's Handbook is no longer applicable
Date: Thu, 24 Oct 2002 20:59:19 +0100

 Adam,
 
 From an SGML perspective, your patch looks fine.  INSTALL_PROGRAM
 strips binaries, but are you sure there are no special cases when
 binaries might be installed some other way?  I'm not familiar enough
 with Ports to be certain this is the case.
 
 If you're happy that the patch is technically correct, feel free to
 commit it, although be sure to "make lint" after applying the patch.
 I'm also happy to commit this, if you'd prefer.
 
 Tom

From: Adam Weinberger <adamw@FreeBSD.org>
To: Tom Hukins <tom@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/44396: Section 15.1 of the Porter's Handbook is no longer applicable
Date: Thu, 24 Oct 2002 13:40:07 -0700

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 >> (10.24.2002 @ 1259 PST): Tom Hukins said, in 0.4K: <<
 > From an SGML perspective, your patch looks fine.  INSTALL_PROGRAM
 > strips binaries, but are you sure there are no special cases when
 > binaries might be installed some other way?  I'm not familiar enough
 > with Ports to be certain this is the case.
 
 If somebody is making a port complex enough that they cannot use the
 INSTALL_PROGRAM macro, they will know enough to figure out how to strip
 it themself.
 
 The section could stay around, and just become a Don't... "Don't strip
 unless you have to."
 
 > If you're happy that the patch is technically correct, feel free to
 > commit it, although be sure to "make lint" after applying the patch.
 > I'm also happy to commit this, if you'd prefer.
 
 Is the porter's handbook part of the ports commit bit or the doc commit
 bit?
 
 - -Adam
 
 - --
 Adam Weinberger
 adam@vectors.cx
 adamw@FreeBSD.ORG
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.0 (FreeBSD)
 
 iD8DBQE9uFqno8KM2ULHQ/0RAno2AKCTvfqoOnhan+z0vWaB9XoX+1xWqwCgwXZK
 DSHALjXglRFuUyLEjKp6oaQ=
 =goAj
 -----END PGP SIGNATURE-----

From: Tom Hukins <tom@FreeBSD.org>
To: Adam Weinberger <adamw@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/44396: Section 15.1 of the Porter's Handbook is no longer applicable
Date: Thu, 24 Oct 2002 21:59:20 +0100

 On Thu, Oct 24, 2002 at 01:40:07PM -0700, Adam Weinberger wrote:
 > 
 > If somebody is making a port complex enough that they cannot use the
 > INSTALL_PROGRAM macro, they will know enough to figure out how to strip
 > it themself.
 
 I agree.  I still think it's worth reminding people that it needs to
 be done, though.
 
 > The section could stay around, and just become a Don't... "Don't strip
 > unless you have to."
 
 That makes sense.
 
 > Is the porter's handbook part of the ports commit bit or the doc commit
 > bit?
 
 Technically it's part of the doc tree, although ports committers can
 better determine the accuracy of its content.  Maybe someone else has
 a more useful answer.
 
 Tom
State-Changed-From-To: open->closed 
State-Changed-By: tom 
State-Changed-When: Tue Oct 29 08:16:57 PST 2002 
State-Changed-Why:  
adamw's commit in revision 1.249 deals with this problem 

http://www.freebsd.org/cgi/query-pr.cgi?pr=44396 
>Unformatted:
