From pepper@reppep.com  Mon Jul 22 19:35:46 2002
Return-Path: <pepper@reppep.com>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AD5EB37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Jul 2002 19:35:46 -0700 (PDT)
Received: from guest.reppep.com (guest.reppep.com [64.81.19.110])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 547B743E31
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Jul 2002 19:35:46 -0700 (PDT)
	(envelope-from pepper@reppep.com)
Received: by guest.reppep.com (Postfix, from userid 501)
	id D1489A970; Mon, 22 Jul 2002 22:36:22 -0400 (EDT)
Message-Id: <20020723023622.D1489A970@guest.reppep.com>
Date: Mon, 22 Jul 2002 22:36:22 -0400 (EDT)
From: Chris Pepper <pepper@rockefeller.edu>
Reply-To: Chris Pepper <pepper@rockefeller.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] Typos in /usr/share/man/man4/ukbd.4.gz
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         40909
>Category:       docs
>Synopsis:       [PATCH] Typos in /usr/share/man/man4/ukbd.4.gz
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 22 19:40:01 PDT 2002
>Closed-Date:    Tue Aug 27 09:20:06 PDT 2002
>Last-Modified:  Tue Aug 27 09:20:06 PDT 2002
>Originator:     Chris Pepper
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
>Environment:
System: FreeBSD guest.reppep.com 4.6-STABLE FreeBSD 4.6-STABLE #6: Mon Jul 15 21:04:43 EDT 2002 root@guest.reppep.com:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
	ukbd.4 has infelicities.
>How-To-Repeat:
	man ukbd
>Fix:
	Suggested patch follows.

--- ukbd.4.diff begins here ---
--- ukbd.4	Mon Jul  8 23:50:47 2002
+++ ukbd.4.fixed	Mon Jul 22 22:29:34 2002
@@ -62,7 +62,7 @@
 .Pp
 .Dl "sh MAKEDEV kbd0 kbd1"
 .Pp
-If both an AT keyboard and one or more USB keyboards are used at the same time, the
+If both an AT keyboard as well as USB keyboards are used at the same time, the
 AT keyboard will appear as
 .Pa kbd0
 in
@@ -86,14 +86,14 @@
 .Pp
 .Dl "kbdcontrol -k /dev/kbd1"
 .Pp
-From this point onwards, the first USB keyboard will be the keyboard
-used for the console.
+From this point on onwards, the first USB keyboard will be the keyboard
+to be used as the console.
 .Pp
 If you want to use a USB keyboard as your default and not use an AT keyboard at
 all, you will have to remove the
 .Cd "device atkbd"
 line from the kernel configuration file.
-Because of the order of device
+Because of the order of the device
 initialization, the USB keyboard will be detected
 .Em after
 the console driver
--- ukbd.4.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Ceri Davies <ceri@FreeBSD.org>
To: Chris Pepper <pepper@rockefeller.edu>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/40909: [PATCH] Typos in /usr/share/man/man4/ukbd.4.gz
Date: Tue, 23 Jul 2002 10:02:55 +0100

 On Mon, Jul 22, 2002 at 10:36:22PM -0400, Chris Pepper said:
 > 	
 > >Description:
 > 	ukbd.4 has infelicities.
 
 Hi Chris,
 
 I'm sorry but I'm not keen on any of the changes presented below -
 is it possible that the patch is reversed, as each of these three
 changes seems to introduce, rather than fix, grammatical error.
 
 > -If both an AT keyboard and one or more USB keyboards are used at the same time, the
 > +If both an AT keyboard as well as USB keyboards are used at the same time, the
 >  AT keyboard will appear as
 
 The original text scans better - "both" and "as well as" should probably
 never appear in the same sentence.
 
 > -From this point onwards, the first USB keyboard will be the keyboard
 > -used for the console.
 > +From this point on onwards, the first USB keyboard will be the keyboard
 > +to be used as the console.
 
 The change in the first line introduces an error - "on" is repeated.
 The change in the second line stirs the pedant in me, since "all the
 console is not a keyboard" to paraphrase a popular saying.
 
 > -Because of the order of device
 > +Because of the order of the device
 >  initialization, the USB keyboard will be detected
 >  .Em after
 >  the console driver
 
 "The order of device initialization" is correct here.
 
 Sorry for seemingly jumping on this with teeth bared.
 
 Ceri

From: dannyboy@freebsd.org
To: freebsd-gnats-submit@FreeBSD.org, pepper@rockefeller.edu
Cc:  
Subject: Re: docs/40909: [PATCH] Typos in /usr/share/man/
Date: Tue, 23 Jul 2002 08:28:28 -0400 (EDT)

 A check in cvs reveals that this patch is indeed reversed.
 

From: parv <parv@subdimension.com>
To: Ceri Davies <ceri@FreeBSD.org>
Cc: f-gnats-submit <freebsd-gnats-submit@freebsd.org>
Subject: Re: docs/40909: [PATCH] Typos in /usr/share/man/man4/ukbd.4.gz
Date: Tue, 23 Jul 2002 17:29:23 -0400

 in message <200207230910.g6N9A7rH020574@freefall.freebsd.org>,
 wrote Ceri Davies thusly...
 >
 > The following reply was made to PR docs/40909
 ...
 >  - is it possible that the patch is reversed, as each of these
 >  three changes seems to introduce, rather than fix, grammatical
 >  error.
 
 i agree w/ ceri fwiw.
 
 
 -- 
  
State-Changed-From-To: open->closed 
State-Changed-By: trhodes 
State-Changed-When: Tue Aug 27 09:19:22 PDT 2002 
State-Changed-Why:  
I committed a different patch than the one you submitted.  Thanks alot for 
pointing these out to us! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40909 
>Unformatted:
 	
