From danfe@regency.nsu.ru  Thu Jun 27 04:09:15 2002
Return-Path: <danfe@regency.nsu.ru>
Received: from mail.nsu.ru (mx.nsu.ru [193.124.215.71])
	by hub.freebsd.org (Postfix) with ESMTP id B03DF37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Jun 2002 04:09:09 -0700 (PDT)
Received: from drweb by mail.nsu.ru with drweb-scanned (Exim 3.20 #1)
	id 17NX95-0002wn-00
	for FreeBSD-gnats-submit@freebsd.org; Thu, 27 Jun 2002 18:09:03 +0700
Received: from regency.nsu.ru ([193.124.210.26])
	by mail.nsu.ru with esmtp (Exim 3.20 #1)
	id 17NX94-0002wb-00
	for FreeBSD-gnats-submit@freebsd.org; Thu, 27 Jun 2002 18:09:02 +0700
Received: from regency.nsu.ru (localhost [127.0.0.1])
	by regency.nsu.ru (8.12.4/8.12.4) with ESMTP id g5RB98EY058979
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Jun 2002 18:09:08 +0700 (NOVST)
	(envelope-from danfe@regency.nsu.ru)
Received: (from danfe@localhost)
	by regency.nsu.ru (8.12.4/8.12.4/Submit) id g5RB97qs058934;
	Thu, 27 Jun 2002 18:09:07 +0700 (NOVST)
Message-Id: <200206271109.g5RB97qs058934@regency.nsu.ru>
Date: Thu, 27 Jun 2002 18:09:07 +0700 (NOVST)
From: Alexey Dokuchaev <danfe@regency.nsu.ru>
Reply-To: Alexey Dokuchaev <danfe@regency.nsu.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ata(4) man pages wrongly states that only IBM DPTA and IBM DTLA support TQ
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         39920
>Category:       docs
>Synopsis:       ata(4) man pages wrongly states that only IBM DPTA and IBM DTLA support TQ
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    trhodes
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 27 04:10:01 PDT 2002
>Closed-Date:    Mon Jul 15 08:39:00 PDT 2002
>Last-Modified:  Mon Jul 15 08:39:00 PDT 2002
>Originator:     Alexey Dokuchaev
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
CNIT NSU
>Environment:
System: FreeBSD regency.nsu.ru 4.6-STABLE FreeBSD 4.6-STABLE #2: Wed Jun 26 20:44:35 NOVST 2002 root@regency.nsu.ru:/usr/obj/usr/src/sys/REGENCY i386
>Description:
ata(4) manual pages does not reflect that, from /usr/src/sys/dev/ata/ata-disk.c,
it is clear that not only IBM DPTA and IBM DTLA drives support tagged
queuing, but recent (obscuredly named) ICxxxxxxAT and ICxxxxxxAV drives
do that as well.  If someone, before going out and buying a drive of
those, reads the manpage, (s)he might get confused and believe that
disk of their choice does not support TQ while it, if fact, does ;-)
>How-To-Repeat:
man 4 ata
>Fix:

--- ata.4.orig	Thu Jun 27 17:40:35 2002
+++ ata.4	Thu Jun 27 17:44:50 2002
@@ -76,7 +76,7 @@
 (WARNING might cause data loss on power failures)
 .It Va hw.ata.tags
 set to 1 to enable Tagged Queuing support, 0 to disable (default is disabled)
-(only IBM DPTA and DTLA drives support that)
+(only IBM DPTA, DTLA, ICxxxxxxAT and ICxxxxxxAV drives support that)
 .El
 .Sh DESCRIPTION
 This driver provides access to disk drives, ATAPI CD-ROM and DVD drives,

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->freebsd-doc 
Responsible-Changed-By: johan 
Responsible-Changed-When: Thu Jun 27 19:18:50 PDT 2002 
Responsible-Changed-Why:  
Missfilled PR -> docs 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39920 
State-Changed-From-To: open->patched 
State-Changed-By: trhodes 
State-Changed-When: Tue Jul 2 13:29:12 PDT 2002 
State-Changed-Why:  
I've fixed this in CURRENT, and will handle the MFC.  However, could you 
perhaps give me some more information on these drives?  Perhaps the 
model name, manufacturer name, etc.  Like: Wester Digital WD1040.  That 
information would be very helpful.  Thanks for the information! 


Responsible-Changed-From-To: freebsd-doc->trhodes 
Responsible-Changed-By: trhodes 
Responsible-Changed-When: Tue Jul 2 13:29:12 PDT 2002 
Responsible-Changed-Why:  
I've fixed this in CURRENT, and will handle the MFC.  However, could you 
perhaps give me some more information on these drives?  Perhaps the 
model name, manufacturer name, etc.  Like: Wester Digital WD1040.  That 
information would be very helpful.  Thanks for the information! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39920 

From: Alexey Dokuchaev <danfe@regency.nsu.ru>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: docs/39920: ata(4) man pages wrongly states that only IBM DPTA and IBM DTLA support TQ
Date: Mon, 8 Jul 2002 14:08:45 +0700

 On Tue, Jul 02, 2002 at 01:31:41PM -0700, Tom Rhodes wrote:
 > Synopsis: ata(4) man pages wrongly states that only IBM DPTA and IBM DTLA support TQ
 > 
 > State-Changed-From-To: open->patched
 > State-Changed-By: trhodes
 > State-Changed-When: Tue Jul 2 13:29:12 PDT 2002
 > State-Changed-Why: 
 > I've fixed this in CURRENT, and will handle the MFC.  However, could you
 > perhaps give me some more information on these drives?  Perhaps the
 > model name, manufacturer name, etc.  Like: Wester Digital WD1040.  That
 > information would be very helpful.  Thanks for the information!
 
 Yes, I should had stated it a bit more accurately, that is, instead of
 stating model numbers like I did (ICxxxxxxAT and ICxxxxxxAV) judging
 from the source code and imprinting on that brand-new 120G I bought :)
 HDD family name major designation should probably be used.
 
 As seen on IBM's website:
 
 	http://www.storage.ibm.com/hdd/support/table.htm
 
 This is "Deskstar" family, and ICxxxxxxAV models are only these ones:
 
 120GXP	| IC35L120AVVA07 | 123.52G | ata100 | 7200rpm
 	| IC35L100AVVA07 | 102.93G | ata100 | 7200rpm
 	| IC35L080AVVA07 |  82.34G | ata100 | 7200rpm
 	| IC35L060AVVA07 |  61.49G | ata100 | 7200rpm
 	| IC35L040AVVA07 |  41.17G | ata100 | 7200rpm
 	| IC35L020AVVA07 |  20.57G | ata100 | 7200rpm
 --------+----------------+---------+--------+--------
 60GXP	| IC35L060AVER07 |  61.49G | ata100 | 7200rpm
 	| IC35L040AVER07 |  41.17G | ata100 | 7200rpm
 	| IC35L030AVER07 |  30.73G | ata100 | 7200rpm
 	| IC35L020AVER07 |  20.57G | ata100 | 7200rpm
 	| IC35L010AVER07 |  10.27G | ata100 | 7200rpm
 
 There are no other GXP models listed in their sheets.
 Speaking of ICxxxxxxAV models, I believe that docs/38290 
 PR originator was not as accurate as I was (as he forgot about
 ICxxxxxxAT series), but his patch looks nicer (does not have all
 those ugly xxxxxx thingies).
 
 As for ICxxxxxxAT series, the family that matches this model
 numbering is "Travelstar".  That's what they got:
 
 60GH	| IC25T060ATCS05 | 60.01G | ide | 5400rpm
 	| IC25T060ATCX05 | 60.01G | ide | 5400rpm
 --------+----------------+--------+-----+--------
 48GH	| IC25T048ATDA05 | 48.00G | ide | 5400rpm
 --------+----------------+--------+-----+--------
 40GN	| IC25N040ATCS04 | 40.00G | ide | 4200rpm
 	| IC25N030ATCS04 | 30.00G | ide | 4200rpm
 	| IC25N020ATCS04 | 20.00G | ide | 4200rpm
 	| IC25N010ATCS04 | 10.05G | ide | 4200rpm
 --------+----------------+--------+-----+--------
 40GNX	| IC25N040ATCS05 | 40.00G | ide | 5400rpm
 	| IC25N020ATCS05 | 20.00G | ide | 5400rpm
 	| IC25N040ATCX05 | 40.00G | ide | 5400rpm
 	| IC25N020ATCX05 | 20.00G | ide | 5400rpm
 --------+----------------+--------+-----+--------
 30GN	| IC25N030ATDA04 | 30.00G | ide | 4200rpm
 	| IC25N020ATDA04 | 20.00G | ide | 4200rpm
 --------+----------------+--------+-----+--------
 15GN	| IC25N015ATDA04 | 15.00G | ide | 4200rpm
 	| IC25N010ATDA04 | 10.05G | ide | 4200rpm
 	| IC25N006ATDA04 | 06.00G | ide | 4200rpm
 
 This one is a bit tougher, because we cannot simply use model main
 suffix (GH, GN) like we did above with GXP models, since there are
 number of GH and GN models that do not support TQ according to Soren's
 code (as they do not fit ICxxxxxxAT mask):
 
         /*
          * check IBM's new obscure way of naming drives
          * we want "IC" (IBM CORP) and "AT" or "AV" (ATA interface)
          * but doesn't care about the other info (size, capacity etc)
          */
         if (!strncmp(adp->device->param->model, "IC", 2) &&
             (!strncmp(adp->device->param->model + 8, "AT", 2) ||
              !strncmp(adp->device->param->model + 8, "AV", 2)))
                 return 1;
 
 Frankly, I do not see a clear way of stating what drives support TQ, in
 the manual page.  From one point, we could have write something like
 this:
 
 	(only IBM DPTA, DTLA, all GXP, 60GH, 48GH, 40GN, 40GNX,
 	30GN, and 30GN drives support that)
 
 OTOH, this looks obscure and somewhat inconsistent, since DPTA and DTLA
 are model numbers, while GXP, 60GH, 48GH, 40GN, 40GNX, etc. are drive
 family names. *sigh*
 
 In fact, I do not see any direct indication in IBM's specs whether some
 drive supports TQ or not :-(  I mean, in general.  I do not have time
 for reading every *.pdf I could find there.
 
 I'm CCing this to docs/38290, the similar PR originator, in hope that
 together we can find a better solution.
 
 AFAIK, Linux 2.5 supports TQ as well, so we might take a look how linux
 folks document this. *grin*
 
 ./danfe
 
State-Changed-From-To: patched->closed 
State-Changed-By: trhodes 
State-Changed-When: Mon Jul 15 08:38:18 PDT 2002 
State-Changed-Why:  
Updated in -stable and -current.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39920 
>Unformatted:
