From nobody@www.freebsd.org  Thu May 16 17:10:59 2002
Return-Path: <nobody@www.freebsd.org>
Received: from nwww.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by hub.freebsd.org (Postfix) with ESMTP id 1BB5037B403
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 May 2002 17:10:59 -0700 (PDT)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by nwww.freebsd.org (8.12.2/8.12.2) with ESMTP id g4H0AwhG084525
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 May 2002 17:10:58 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.2/8.12.2/Submit) id g4H0Awl1084524;
	Thu, 16 May 2002 17:10:58 -0700 (PDT)
Message-Id: <200205170010.g4H0Awl1084524@www.freebsd.org>
Date: Thu, 16 May 2002 17:10:58 -0700 (PDT)
From: Andy Farkas <andyf@speednet.com.au>
To: freebsd-gnats-submit@FreeBSD.org
Subject: missing word in src/usr.bin/uniq/uniq.1
X-Send-Pr-Version: www-1.0

>Number:         38161
>Category:       docs
>Synopsis:       missing word in src/usr.bin/uniq/uniq.1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    trhodes
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 16 17:20:01 PDT 2002
>Closed-Date:    Wed May 29 10:02:24 PDT 2002
>Last-Modified:  Wed May 29 10:02:24 PDT 2002
>Originator:     Andy Farkas
>Release:        HEAD
>Organization:
>Environment:
>Description:
Grammar check uniq(1) man page      
>How-To-Repeat:
man 1 uniq      
>Fix:
--- src/usr.bin/uniq/uniq.1-orig        Wed May  8 12:41:07 2002
+++ src/usr.bin/uniq/uniq.1     Wed May  8 12:42:01 2002
@@ -71,7 +71,7 @@
 .It Fl f Ar fields
 Ignore the first
 .Ar fields
-in each input line when doing comparisons.
+fields in each input line when doing comparisons.
 A field is a string of non-blank characters separated from adjacent fields
 by blanks.
 Field numbers are one based, i.e. the first field is field one.
      
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: trhodes 
State-Changed-When: Thu May 16 17:34:19 PDT 2002 
State-Changed-Why:  
I cannot reproduce this error in -current or -stable, please rebuild 
your sources and let me know.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=38161 

From: Tom Rhodes <trhodes@FreeBSD.org>
To: Andy Farkas <andyf@speednet.com.au>,
	freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Thu, 16 May 2002 20:34:46 -0400

 On Thu, 16 May 2002 17:10:58 -0700 (PDT)
 Andy Farkas <andyf@speednet.com.au> wrote:
 
 I cannot reproduce the missing ``fields'' word as you point out,
 in -stable and -current.  Now, quick question.  Do you see
 the .Ar fields text in the patch, that should display the word
 ``fields'' in an underlined form, and if you cannot see it, then
 you may need to resup and rebuild.
 
 Let me know please.
 
 -- 
 Tom (Darklogik) Rhodes
 www.FreeBSD.org  -The Power To Serve
 www.Pittgoth.com -Pittgoth Discussion Portal
 trhodes@{Pittgoth.com, FreeBSD.org}
 PGP key by www:
 http://www.pittgoth.com/~darklogik/darklogik.key

From: Andy Farkas <andyf@speednet.com.au>
To: Tom Rhodes <trhodes@FreeBSD.org>
Cc: <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Fri, 17 May 2002 11:08:34 +1000 (EST)

 > I cannot reproduce the missing ``fields'' word as you point out,
 > in -stable and -current.  Now, quick question.  Do you see
 > the .Ar fields text in the patch, that should display the word
 > ``fields'' in an underlined form, and if you cannot see it, then
 > you may need to resup and rebuild.
 
 In the man page the description for "-s chars" reads:
 
   Ignore the first chars characters in each input line...
 
 but for "-f fields" it reads:
 
   Ignore the first fields in each input line...
 
 It should read:
 
   Ignore the first fields fields in each input line...
 
 --
 
  :{ andyf@speednet.com.au
 
         Andy Farkas
     System Administrator
    Speednet Communications
  http://www.speednet.com.au/
 
 
 

From: Tom Rhodes <trhodes@FreeBSD.org>
To: Andy Farkas <andyf@speednet.com.au>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Thu, 16 May 2002 21:17:47 -0400

 On Thu, 16 May 2002 18:10:03 -0700 (PDT)
 Andy Farkas <andyf@speednet.com.au> wrote:
 
 fields fields just does not sound right when I read it though,
 and I will agree that chars characters should most likly be
 changed as it took around 2 reads for me to interpret it.
 
 Anyone else care to comment?
 
 -- 
 Tom (Darklogik) Rhodes
 www.FreeBSD.org  -The Power To Serve
 www.Pittgoth.com -Pittgoth Discussion Portal
 trhodes@{Pittgoth.com, FreeBSD.org}
 PGP key by www:
 http://www.pittgoth.com/~darklogik/darklogik.key

From: Andy Farkas <andyf@speednet.com.au>
To: Tom Rhodes <trhodes@FreeBSD.org>
Cc: <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Fri, 17 May 2002 11:22:50 +1000 (EST)

 Read the second sentance in "-s chars" :)
 
 --
 
  :{ andyf@speednet.com.au
 
         Andy Farkas
     System Administrator
    Speednet Communications
  http://www.speednet.com.au/
 
 
 

From: Ceri Davies <setantae@submonkey.net>
To: trhodes@freebsd.org
Cc: Andy Farkas <andyf@speednet.com.au>,
	freebsd-gnats-submit@freebsd.org
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Fri, 17 May 2002 08:46:12 +0100

 I think the patch is good.
 
 Ceri
 
 -- 
 get the cool shoe shine

From: Tom Rhodes <trhodes@FreeBSD.org>
To: Ceri Davies <setantae@submonkey.net>
Cc: freebsd-doc@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Fri, 17 May 2002 11:40:13 -0400

 On Fri, 17 May 2002 00:50:03 -0700 (PDT)
 Ceri Davies <setantae@submonkey.net> wrote:
 
 >  I think the patch is good.
 
 This is the comment I was waiting for.  Thanks Ceri ;)
 
 >  
 >  Ceri
 >  
 >  -- 
 >  get the cool shoe shine
 > 
 
 -- 
 Tom (Darklogik) Rhodes
 www.FreeBSD.org  -The Power To Serve
 www.Pittgoth.com -Pittgoth Discussion Portal
 trhodes@{Pittgoth.com, FreeBSD.org}
 PGP key by www:
 http://www.pittgoth.com/~darklogik/darklogik.key

From: Giorgos Keramidas <keramida@FreeBSD.ORG>
To: Tom Rhodes <trhodes@FreeBSD.ORG>
Cc: Ceri Davies <setantae@submonkey.net>, bug-followup@FreeBSD.ORG
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Sat, 18 May 2002 15:33:09 +0300

 On 2002-05-17 11:40, Tom Rhodes wrote:
 > On Fri, 17 May 2002 00:50:03 -0700 (PDT)
 > Ceri Davies <setantae@submonkey.net> wrote:
 > >  I think the patch is good.
 >
 > This is the comment I was waiting for.  Thanks Ceri ;)
 
 For what it's worth, I don't like having two identical words, one
 right after the other.  Perhaps rewording might help?  By reading the
 text of uniq.1 I can see that the `fields' option of -f is actually
 the number of fields that is ignored when -f is passed.  I would
 really prefer this written in such a way that duplication of a word is
 not needed.  Something like:
 
 %%%
 --- uniq.1.orig	Sat May 18 15:30:58 2002
 +++ uniq.1	Sat May 18 15:31:14 2002
 @@ -68,9 +68,9 @@
  occurred in the input, followed by a single space.
  .It Fl d
  Only output lines that are repeated in the input.
 -.It Fl f Ar fields
 +.It Fl f Ar num
  Ignore the first
 -.Ar fields
 +.Ar num
  in each input line when doing comparisons.
  A field is a string of non-blank characters separated from adjacent fields
  by blanks.
 %%%
 
 If you like this better, then you're welcome to use it, instead of the
 word duplication.
 
 - Giorgos
 
State-Changed-From-To: feedback->patched 
State-Changed-By: trhodes 
State-Changed-When: Tue May 21 09:56:20 PDT 2002 
State-Changed-Why:  
Slightly different patch committed to -current, MFC in 3 days and re approval. 
Thanks! 


Responsible-Changed-From-To: freebsd-doc->trhodes 
Responsible-Changed-By: trhodes 
Responsible-Changed-When: Tue May 21 09:56:20 PDT 2002 
Responsible-Changed-Why:  
Slightly different patch committed to -current, MFC in 3 days and re approval. 
Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=38161 

From: Andy Farkas <andyf@speednet.com.au>
To: Tom Rhodes <trhodes@FreeBSD.org>
Cc: <freebsd-gnats-submit@FreeBSD.org>
Subject: Re: docs/38161: missing word in src/usr.bin/uniq/uniq.1
Date: Fri, 24 May 2002 07:35:42 +1000 (EST)

 Its still missing a word; it should read:
 
  Ignore the first num fields in each input line when doing comparisons.
                       ^^^^^^
 
 Also, the SYNOPSIS needs to be updated....
 
 --
 
  :{ andyf@speednet.com.au
 
         Andy Farkas
     System Administrator
    Speednet Communications
  http://www.speednet.com.au/
 
 
 
State-Changed-From-To: patched->closed 
State-Changed-By: trhodes 
State-Changed-When: Wed May 29 10:01:26 PDT 2002 
State-Changed-Why:  
Rebuilt patch committed to -stable today.  Thanks for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=38161 
>Unformatted:
