From nobody@FreeBSD.org  Mon Jan 14 23:19:43 2002
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 1A77F37B400
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 14 Jan 2002 23:19:43 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g0F7JhS80413;
	Mon, 14 Jan 2002 23:19:43 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200201150719.g0F7JhS80413@freefall.freebsd.org>
Date: Mon, 14 Jan 2002 23:19:43 -0800 (PST)
From: Ted Mittelstaedt <tedm@toybox.placo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: GNATS webinterface isn't wrapping lines
X-Send-Pr-Version: www-1.0

>Number:         33913
>Category:       docs
>Synopsis:       GNATS webinterface isn't wrapping lines
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 14 23:20:00 PST 2002
>Closed-Date:    Tue Jan 15 07:28:45 PST 2002
>Last-Modified:  Wed Jan 16 21:40:01 PST 2002
>Originator:     Ted Mittelstaedt
>Release:        
>Organization:
>Environment:
>Description:
This URL http://www.freebsd.org/send-pr.html is not wrapping lines when you type in a PR description in the window and you just let the window wrap the cursor, it makes them hard to read, arggggg!!


>How-To-Repeat:
      
>Fix:
      
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Tue Jan 15 07:28:45 PST 2002 
State-Changed-Why:  
This is not a problem with interface, but rather with your 
client software (I guess that was IE or Mozilla?).  Both 
lynx(1) and links(1) I've tried as well correctly display 
line wrapping by hiding the beginning of the line and not 
automatically wrapping the rest to the next line. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33913 

From: "Ted Mittelstaedt" <tedm@toybox.placo.com>
To: <ru@FreeBSD.org>, <freebsd-doc@FreeBSD.org>
Cc: <freebsd-gnats-submit@FreeBSD.org>
Subject: RE: docs/33913: GNATS webinterface isn't wrapping lines
Date: Tue, 15 Jan 2002 22:32:38 -0800

 This is not a brower problem, it is because
 the GNATS interface HTML has a coding error.
 
 The relevant HTML on http://www.freebsd.org/send-pr.html SHOULD BE as follows:
 
  <textarea name="environment" rows="3" cols="72">
       </textarea><br>
        <b>Full Description</b>:<br>
        <textarea wrap="hard" name="description" rows="6" cols="72">
       </textarea><br>
        <b>How to repeat the problem</b>:<br>
        <textarea wrap="hard" name="howtorepeat" rows="6" cols="72">
       </textarea><br>
        <b>Fix to the problem if known</b>:<br>
        <textarea wrap="hard" name="fix" rows="6" cols="72">
       </textarea><br>
        <input type="SUBMIT" value="Submit Problem Report"> <input
       type="RESET" value="Reset">
 
 Note the addition of the "wrap" directive.
 
 
 Ted Mittelstaedt
 

From: Jim Mock <mij@soupnazi.org>
To: Ted Mittelstaedt <tedm@toybox.placo.com>
Cc: ru@FreeBSD.org, freebsd-doc@FreeBSD.org,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
Date: Tue, 15 Jan 2002 23:55:45 -0800

 On Tue, 15 Jan 2002 at 22:32:38 -0800, Ted Mittelstaedt wrote:
 > This is not a brower problem, it is because
 > the GNATS interface HTML has a coding error.
 > 
 > The relevant HTML on http://www.freebsd.org/send-pr.html SHOULD BE as follows:
 > 
 >  <textarea name="environment" rows="3" cols="72">
 >       </textarea><br>
 >        <b>Full Description</b>:<br>
 >        <textarea wrap="hard" name="description" rows="6" cols="72">
 >       </textarea><br>
 >        <b>How to repeat the problem</b>:<br>
 >        <textarea wrap="hard" name="howtorepeat" rows="6" cols="72">
 >       </textarea><br>
 >        <b>Fix to the problem if known</b>:<br>
 >        <textarea wrap="hard" name="fix" rows="6" cols="72">
 >       </textarea><br>
 >        <input type="SUBMIT" value="Submit Problem Report"> <input
 >       type="RESET" value="Reset">
 > 
 > Note the addition of the "wrap" directive.
 
 The wrap attribute is not valid in HTML 4.01.
 
 - jim
 
 -- 
 jim mock <mij@soupnazi.org>   http://soupnazi.org/ | jim@FreeBSD.org

From: "Ted Mittelstaedt" <tedm@toybox.placo.com>
To: <mij@soupnazi.org>
Cc: <ru@FreeBSD.org>, <freebsd-doc@FreeBSD.org>,
	<freebsd-gnats-submit@FreeBSD.org>
Subject: RE: docs/33913: GNATS webinterface isn't wrapping lines
Date: Wed, 16 Jan 2002 01:06:48 -0800

 >-----Original Message-----
 >From: Jim Mock [mailto:mij@soupnazi.org]
 >Sent: Tuesday, January 15, 2002 11:56 PM
 >To: Ted Mittelstaedt
 >Cc: ru@FreeBSD.org; freebsd-doc@FreeBSD.org;
 >freebsd-gnats-submit@FreeBSD.org
 >Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
 >
 >>
 >> Note the addition of the "wrap" directive.
 >
 >The wrap attribute is not valid in HTML 4.01.
 >
 
 It was not my intent to start a religious argument.  User input
 code that doesen't massage the input is a coding error - what
 happens if some joker decides to put in a javascript in a PR
 that does something nasty?  Are we checking for that?
 
 The wrap attribute was NEVER valid in any HTML spec.  It is and
 remains a quick hack to get out of massaging user input.
 
 Obviously the best way to solve this would be to further process
 the user input on the webform to insert linebreaks in case someone
 uses a browser that doesen't do what the code expects is "right"
 
 But if nobody writes one then what's wrong with a quick hack?
 
 The PR database already has a lot of these unwrapped entries with lines that
 scroll off the side of the screen.  Which is more important - making PR's
 readable or being "right"?
 
 Ted
 

From: Jim Mock <mij@soupnazi.org>
To: Ted Mittelstaedt <tedm@toybox.placo.com>
Cc: ru@FreeBSD.org, freebsd-doc@FreeBSD.org,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
Date: Wed, 16 Jan 2002 01:15:33 -0800

 On Wed, 16 Jan 2002 at 01:06:48 -0800, Ted Mittelstaedt wrote:
 > >-----Original Message-----
 > >From: Jim Mock [mailto:mij@soupnazi.org]
 > >Sent: Tuesday, January 15, 2002 11:56 PM
 > >To: Ted Mittelstaedt
 > >Cc: ru@FreeBSD.org; freebsd-doc@FreeBSD.org;
 > >freebsd-gnats-submit@FreeBSD.org
 > >Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
 > >
 > >>
 > >> Note the addition of the "wrap" directive.
 > >
 > >The wrap attribute is not valid in HTML 4.01.
 > >
 > 
 > It was not my intent to start a religious argument.  User input code
 > that doesen't massage the input is a coding error - what happens if
 > some joker decides to put in a javascript in a PR that does something
 > nasty?  Are we checking for that?
 
 You'd have to check dosendpr.cgi.
 
 > The wrap attribute was NEVER valid in any HTML spec.  It is and
 > remains a quick hack to get out of massaging user input.
 > 
 > Obviously the best way to solve this would be to further process the
 > user input on the webform to insert linebreaks in case someone uses a
 > browser that doesen't do what the code expects is "right"
 > 
 > But if nobody writes one then what's wrong with a quick hack?
 
 What's wrong with it is that when the web site is built, the code is
 validated, and if non-existant stuff is found, the build fails.  If we
 add the wrap attribute, the build will fail because it isn't valid.
 
 > The PR database already has a lot of these unwrapped entries with
 > lines that scroll off the side of the screen.  Which is more important
 > - making PR's readable or being "right"?
 
 That's what horizontal scroll is for :-)  Seriously though, patches are
 welcome to make things readable, but yes, it also must be "right" or
 there will be problems with the build.
 
 - jim
 
 -- 
 jim mock <mij@soupnazi.org>   http://soupnazi.org/ | jim@FreeBSD.org

From: "Ted Mittelstaedt" <tedm@toybox.placo.com>
To: <mij@soupnazi.org>
Cc: <ru@FreeBSD.org>, <freebsd-doc@FreeBSD.org>,
	<freebsd-gnats-submit@FreeBSD.org>
Subject: RE: docs/33913: GNATS webinterface isn't wrapping lines
Date: Wed, 16 Jan 2002 01:35:45 -0800

 >-----Original Message-----
 >From: Jim Mock [mailto:mij@soupnazi.org]
 >Sent: Wednesday, January 16, 2002 1:16 AM
 >To: Ted Mittelstaedt
 >Cc: ru@FreeBSD.org; freebsd-doc@FreeBSD.org;
 >freebsd-gnats-submit@FreeBSD.org
 >Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
 >
 >
 >That's what horizontal scroll is for :-)
 
 Or I could always put the monitor on it's side...
 
 >Seriously though, patches are
 >welcome to make things readable, but yes, it also must be "right" or
 >there will be problems with the build.
 
 Then can we at least put a sentence on the entry page there
 that says:
 
 "Note: Lines entered are NOT automatically wrapped!"
 
 preferably in between the "Full Description:" and the textbox,
 the "How to repeat the problem: and the textbox, and the
 "Fix to the problem if known: line and the textbox.
 
 That, at least, might catch a few entries.
 
 Ted

From: Murray Stokely <murray@FreeBSD.org>
To: Jim Mock <mij@soupnazi.org>
Cc: Ted Mittelstaedt <tedm@toybox.placo.com>, ru@FreeBSD.org,
	freebsd-doc@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
Date: Wed, 16 Jan 2002 21:39:22 -0800

 --rFUhhEVnhEf/dYhU
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Wed, Jan 16, 2002 at 01:15:33AM -0800, Jim Mock wrote:
 > > The wrap attribute was NEVER valid in any HTML spec.  It is and
 > > remains a quick hack to get out of massaging user input.
 > ...
 >=20
 > What's wrong with it is that when the web site is built, the code is
 > validated, and if non-existant stuff is found, the build fails.  If we
 > add the wrap attribute, the build will fail because it isn't valid.
 
   I ran into this problem a lot over the last several weeks as I was
 frantically trying to put up http://www.FreeBSDMall.com.
 
   Basically we're using the stock FreeBSD Web infrastructure with the
 following small additions to web/share/mk/web.site.mk :
 
   * Addition of a 'spellcheck' target, so that we can check the
     formatted output for errors before committing changes.
 
   * Addition of a 'POSTPROCESS' target, so that invalid HTML can be
     specified with something like=20
 
       "<body class=3D'FreeBSDMall-bodystyle1'>"=20
 
     A variable is set in the individual Makefiles to specify what
     replacement should be done.  In this case, the class attribute is
     replaced with the invalid but highly implemented margin
     attributes.
 
     web.site.mk then contains the Perl or sed command line to run the
     regexp specified in this variable over the generated HTML file.
 
   * Various other installation tweaks for our local.
 
 The problem gets more complex for us, because we're using an
 application server that embeds new invalid tags to the HTML.
 
 We can use CDATA sections for some of this stuff, but that has the
 side effect of changing < into &lt; and other problems that will
 certainly confuse the application server.  If anyone is interested, I
 can post the diffs for the above functionality, although it is really
 quite trivial.
 
 I would be very interested in hearing how other people deal with these
 problems.  In particular, I know the POSTPROCESS stuff is a big ugly
 hack, so I'd like to find a more SGML-friendly way to solve this problem.
 
 	  - Murray
 
 --rFUhhEVnhEf/dYhU
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.6 (SunOS)
 Comment: For info see http://www.gnupg.org
 
 iD8DBQE8RmOJtNcQog5FH30RAvwpAKCg9pRD4TwQRYMiQmN/3OSpD1/fIgCgo+zG
 jaQglJb7x8IGiYGth5K69Dw=
 =94ya
 -----END PGP SIGNATURE-----
 
 --rFUhhEVnhEf/dYhU--
>Unformatted:
