From edwin@mavetju.org  Mon Jan  7 02:28:38 2002
Return-Path: <edwin@mavetju.org>
Received: from topaz.mdcc.cx (topaz.mdcc.cx [212.204.230.141])
	by hub.freebsd.org (Postfix) with ESMTP id 3BF6D37B404
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Jan 2002 02:28:38 -0800 (PST)
Received: from k7.mavetju.org (topaz.mdcc.cx [212.204.230.141])
	by topaz.mdcc.cx (Postfix) with ESMTP id 5AF962B791
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Jan 2002 11:28:36 +0100 (CET)
Received: by k7.mavetju.org (Postfix, from userid 1001)
	id 73F6F5B3; Mon,  7 Jan 2002 21:28:33 +1100 (EST)
Message-Id: <20020107102833.73F6F5B3@k7.mavetju.org>
Date: Mon,  7 Jan 2002 21:28:33 +1100 (EST)
From: Edwin Groothuis <edwin@mavetju.org>
Reply-To: Edwin Groothuis <edwin@mavetju.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: http://www.freebsd.org/cgi/gallery.cgi gives weird preview
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         33641
>Category:       docs
>Synopsis:       http://www.freebsd.org/cgi/gallery.cgi gives weird preview
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 07 02:30:01 PST 2002
>Closed-Date:    Tue Jan 8 07:32:16 PST 2002
>Last-Modified:  Tue Jan 08 07:32:36 PST 2002
>Originator:     Edwin Groothuis
>Release:        FreeBSD 4.4-RELEASE i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju.org 4.4-RELEASE FreeBSD 4.4-RELEASE #0: Tue Dec 25 02:20:13 EST 2001 edwin@k7.mavetju.org:/usr/src/sys/compile/k7 i386

http://www.freebsd.org/cgi/gallery.cgi

>Description:

If you fill in an organisation, description and URL and press
preview, the </a> at thge end of the Organization goes though on
the description.

>How-To-Repeat:

See description

>Fix:

none
>Release-Note:
>Audit-Trail:

From: Tom Rhodes <darklogik@pittgoth.com>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re:docs/33641  Was it not designed to work this way?
Date: Mon, 07 Jan 2002 20:32:51 -0500

 Reading over this pr, I always thought this was how the FreeBSD team 
 wanted it to work.  However, I have tried this, its true that after the 
 preview button is pressed, the next page links the description as part 
 of the link (ie clickable).  Maybe it should stay like that, cause final 
 processing looks fine to me (under the gallery.html) and the only person 
 who sees this is the submitter.
 
 Tom (Darklogik) Rhodes
 www.Pittgoth.com -Gothic Liberation Front
 www.FreeBSD.org -The Power To Serve
 

From: Peter Pentchev <roam@ringlet.net>
To: Tom Rhodes <darklogik@pittgoth.com>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: docs/33641  Was it not designed to work this way?
Date: Tue, 8 Jan 2002 14:23:40 +0200

 On Mon, Jan 07, 2002 at 05:30:01PM -0800, Tom Rhodes wrote:
 > The following reply was made to PR docs/33641; it has been noted by GNATS.
 > 
 > From: Tom Rhodes <darklogik@pittgoth.com>
 > To: freebsd-gnats-submit@FreeBSD.org
 > Cc:  
 > Subject: Re:docs/33641  Was it not designed to work this way?
 > Date: Mon, 07 Jan 2002 20:32:51 -0500
 > 
 >  Reading over this pr, I always thought this was how the FreeBSD team 
 >  wanted it to work.  However, I have tried this, its true that after the 
 >  preview button is pressed, the next page links the description as part 
 >  of the link (ie clickable).  Maybe it should stay like that, cause final 
 >  processing looks fine to me (under the gallery.html) and the only person 
 >  who sees this is the submitter.
 
 Still, no harm in fixing gallery.cgi so that it displays the entry
 exactly as it would be posted later :)  Patch attached.
 
 G'luck,
 Peter
 
 -- 
 If the meanings of 'true' and 'false' were switched, then this sentence wouldn't be false.
 
 Index: www/en/cgi/gallery.cgi
 ===================================================================
 RCS file: /home/ncvs/www/en/cgi/gallery.cgi,v
 retrieving revision 1.19
 diff -u -r1.19 gallery.cgi
 --- www/en/cgi/gallery.cgi	24 Oct 2001 17:29:39 -0000	1.19
 +++ www/en/cgi/gallery.cgi	8 Jan 2002 12:03:37 -0000
 @@ -22,8 +22,8 @@
  require 'cgi-style.pl';
  
  # Construct the gallery entry in HTML form
 -$entry = "<li><a href=\"$in{'url'}\"><strong>$in{'organization'}</strong> " .
 -    "-- $in{'description'}</a></li>";
 +$entry = "<li><a href=\"$in{'url'}\"></a><strong>$in{'organization'}</strong>".
 +    " -- $in{'description'}</li>";
  
  # Try and figure out where the person came from so we can provide
  # links back to the correct place.
State-Changed-From-To: open->closed 
State-Changed-By: phantom 
State-Changed-When: Tue Jan 8 07:32:16 PST 2002 
State-Changed-Why:  
Fixed. Thanks! 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33641 
>Unformatted:
