From nobody@FreeBSD.org  Thu Dec  6 12:30:38 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 21A7F37B41A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Dec 2001 12:30:24 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id fB6KUOD78491;
	Thu, 6 Dec 2001 12:30:24 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200112062030.fB6KUOD78491@freefall.freebsd.org>
Date: Thu, 6 Dec 2001 12:30:24 -0800 (PST)
From: Hiten Pandya <hiten@uk.freebsd.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] MAKEDEV.8 (i386) - wd# is replaced by ad#
X-Send-Pr-Version: www-1.0

>Number:         32564
>Category:       docs
>Synopsis:       [PATCH] MAKEDEV.8 (i386) - wd# is replaced by ad#
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 06 12:40:01 PST 2001
>Closed-Date:    Mon Jan 21 10:13:08 PST 2002
>Last-Modified:  Mon Jan 21 10:14:06 PST 2002
>Originator:     Hiten Pandya
>Release:        5.0-CURRENT
>Organization:
>Environment:
FreeBSD hpdi.ath.cx 5.0-CURRENT FreeBSD 5.0-CURRENT #10: Sat Dec 1 15:09:09 GMT 2001 
hitenp@hpdi.ath.cx:/usr/obj/data/dev/src/sys/CURRENT5 i386
>Description:
The flaw in the MAKEDEV.8 (i386) man page says the wd# disk names still
exist.. while they have been completely changed to ad#.

The patch below resolves the issue by changing the wd# into ad# and the
patch also provide's a note to pre FreeBSD 4.3 Users that ad# needs to
be changed to wd#.
>How-To-Repeat:
Visit the MAKEDEV.8 (i386) Man Page
>Fix:
*** MAKEDEV.8.old Thu Dec 6 19:48:53 2001
--- MAKEDEV.8 Thu Dec 6 20:00:11 2001
***************
*** 87,97 ****
SCSI tape drives
.It vty#
set of 12 virtual console devices for syscons/pcvt/codrv
! .It wd#
.Dq winchester
disk drives (ST506, IDE, ESDI, RLL etc.)
.It wt#
QIC-interfaced (e.g. not SCSI) 3M cartridge tape
.El
.Sh FILES
.Bl -tag -width /dev/xxxx -compact
--- 87,103 ----
SCSI tape drives
.It vty#
set of 12 virtual console devices for syscons/pcvt/codrv
! .It ad#
.Dq winchester
disk drives (ST506, IDE, ESDI, RLL etc.)
.It wt#
QIC-interfaced (e.g. not SCSI) 3M cartridge tape
+ .Sh NOTE
+ Please change
+ .Dq ad#
+ to
+ .Dq wd#
+ on systems older than FreeBSD 4.3.
.El
.Sh FILES
.Bl -tag -width /dev/xxxx -compact

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: dd 
State-Changed-When: Sun Jan 6 21:52:54 PST 2002 
State-Changed-Why:  
This can probably be closed unless the originator feels strongly that 
his last change should be applied. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=32564 

From: Dima Dorfman <dima@trit.org>
To: Hiten Pandya <hiten@uk.freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: docs/32564: [PATCH] MAKEDEV.8 (i386) - wd# is replaced by ad# 
Date: Mon, 07 Jan 2002 05:52:46 +0000

 Hiten Pandya <hiten@uk.freebsd.org> wrote:
 > *** MAKEDEV.8.old Thu Dec 6 19:48:53 2001
 > --- MAKEDEV.8 Thu Dec 6 20:00:11 2001
 
 This patch is corrupt.  I don't know how that came about.  Also, for
 small and clean changes like this, unified diffs are much easier to
 read [1].
 
 > ***************
 > *** 87,97 ****
 > SCSI tape drives
 > .It vty#
 > set of 12 virtual console devices for syscons/pcvt/codrv
 > ! .It wd#
 > .Dq winchester
 > disk drives (ST506, IDE, ESDI, RLL etc.)
 > .It wt#
 > QIC-interfaced (e.g. not SCSI) 3M cartridge tape
 > .El
 > .Sh FILES
 > .Bl -tag -width /dev/xxxx -compact
 > --- 87,103 ----
 > SCSI tape drives
 > .It vty#
 > set of 12 virtual console devices for syscons/pcvt/codrv
 > ! .It ad#
 > .Dq winchester
 > disk drives (ST506, IDE, ESDI, RLL etc.)
 > .It wt#
 > QIC-interfaced (e.g. not SCSI) 3M cartridge tape
 
 This change is good in theory but is largely incomplete; ad# is not
 "winchester disk drives".  There's a similar, but more complete,
 change in the Alpha MAKEDEV.8 which I have merged to the i386 version.
 
 > + .Sh NOTE
 > + Please change
 > + .Dq ad#
 > + to
 > + .Dq wd#
 > + on systems older than FreeBSD 4.3.
 
 I don't particularly like this.  For one, FreeBSD 4.3 used ad# by
 default; wd# is only used on 3.x.  Further, mentioning upgrade quirks
 in a manual page seems somewhat unnatural to me.  This should probably
 be mentioned in UPDATING and/or the release notes if it isn't already.
 
 I'd like to close this PR unless somebody feels strongly that this
 last change should be made.
 
 Thanks.
 
 [1] I realize that this is my opinion, but I'm not alone in this
 preference.

From: "Hiten Pandya" <hitmaster@mysun.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: docs/32564 (close request ack.)
Date: Mon, 21 Jan 2002 17:01:36 GMT

 > This can probably be closed unless the originator feels 
 > strongly that his last change should be applied. 
 
 hmm, this PR can be closed, as it is true that this Patch is mostly
 incorrect, after dd pointed out the mistakes I made in this patch.
 
 If there is a need for another patch, I will surely submit one, but I
 am sure that the same type of change in the Alpha MAKEDEV.8 man page
 can be applied into the i386 MAKEDEV.8 man page.
 
 Otherwise, this PR can be closed without any problems. :-)
 
 regards,
 Hiten Pandya
 <hiten@uk.FreeBSD.org>
 <hitmaster@mysun.com>
 
 
State-Changed-From-To: feedback->closed 
State-Changed-By: keramida 
State-Changed-When: Mon Jan 21 10:13:08 PST 2002 
State-Changed-Why:  
By originator's request, 
after he discussed things with dd@FreeBSD.org. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=32564 
>Unformatted:
