From nobody@FreeBSD.org  Fri Aug 31 05:57:59 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2C95437B403
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 31 Aug 2001 05:57:59 -0700 (PDT)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7VCvx776057;
	Fri, 31 Aug 2001 05:57:59 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200108311257.f7VCvx776057@freefall.freebsd.org>
Date: Fri, 31 Aug 2001 05:57:59 -0700 (PDT)
From: Joseph Mallett <jmallett@xMach.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: socketvar.h comment references obsolete structure members
X-Send-Pr-Version: www-1.0

>Number:         30234
>Category:       docs
>Synopsis:       socketvar.h comment references obsolete structure members
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 31 06:00:01 PDT 2001
>Closed-Date:    Mon Sep 3 08:56:08 PDT 2001
>Last-Modified:  Mon Sep 03 08:56:17 PDT 2001
>Originator:     Joseph Mallett
>Release:        4.3
>Organization:
>Environment:
FreeBSD Dalek.xMach.ORG 4.3-STABLE FreeBSD 4.3-STABLE #0: Mon Jun 18 07:07:16 EDT 2001     jmallett@Dalek.xMach.ORG:/usr/home/jmallett/vmunix.build  i386
>Description:
/sys/sys/socketvar.h has the folllowing comment:

 * For head socket so_q0 queues partially completed connections,
 * while so_q is a queue of connections ready to be accepted.
 * If a connection is aborted and it has so_head set, then
 * it has to be pulled out of either so_q0 or so_q.
 * We allow connections to queue up based on current queue lengths
 * and limit on number of queued connections for this socket.

but q0 and q have been replaced by so_incomp and so_comp.
>How-To-Repeat:
vi /sys/sys/socketvar.h
read the comment
and then look for the structure members it references
>Fix:
just replace the old names with the new names, and possibly mention something about the use of TAILQ
>Release-Note:
>Audit-Trail:

From: Joseph Mallett <jmallett@NewGold.NET>
To: Joseph Mallett <jmallett@xMach.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: docs/30234: socketvar.h comment references obsolete structure members
Date: Fri, 31 Aug 2001 13:36:39 +0000

 Sorry, this has been fixed in current, I checked on RELENG_4...
 
 Please close this, but please MFC the comment change as well, it's been 
 two months.
 
 On Fri, Aug 31, 2001 at 05:57:59AM -0700, Joseph Mallett wrote:
 > 
 > >Number:         30234
 > >Category:       docs
 > >Synopsis:       socketvar.h comment references obsolete structure members
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-doc
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          sw-bug
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Fri Aug 31 06:00:01 PDT 2001
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Joseph Mallett
 > >Release:        4.3
 > >Organization:
 > >Environment:
 > FreeBSD Dalek.xMach.ORG 4.3-STABLE FreeBSD 4.3-STABLE #0: Mon Jun 18 07:07:16 EDT 2001     jmallett@Dalek.xMach.ORG:/usr/home/jmallett/vmunix.build  i386
 > >Description:
 > /sys/sys/socketvar.h has the folllowing comment:
 > 
 >  * For head socket so_q0 queues partially completed connections,
 >  * while so_q is a queue of connections ready to be accepted.
 >  * If a connection is aborted and it has so_head set, then
 >  * it has to be pulled out of either so_q0 or so_q.
 >  * We allow connections to queue up based on current queue lengths
 >  * and limit on number of queued connections for this socket.
 > 
 > but q0 and q have been replaced by so_incomp and so_comp.
 > >How-To-Repeat:
 > vi /sys/sys/socketvar.h
 > read the comment
 > and then look for the structure members it references
 > >Fix:
 > just replace the old names with the new names, and possibly mention something about the use of TAILQ
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:
 > 
 > To Unsubscribe: send mail to majordomo@FreeBSD.org
 > with "unsubscribe freebsd-doc" in the body of the message
 
 -- 
 --
 Joseph A. Mallett
 http://srcsys.org
 
 xMach Core Team, www.xMach.org
State-Changed-From-To: open->closed 
State-Changed-By: dd 
State-Changed-When: Mon Sep 3 08:56:08 PDT 2001 
State-Changed-Why:  
IIRC jlemon MFC'd this stuff. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=30234 
>Unformatted:
