From nobody@FreeBSD.ORG  Wed Oct 18 08:26:15 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DC0E737B4C5; Wed, 18 Oct 2000 08:26:15 -0700 (PDT)
Message-Id: <20001018152615.DC0E737B4C5@hub.freebsd.org>
Date: Wed, 18 Oct 2000 08:26:15 -0700 (PDT)
From: bigotfo@bigfoot.com
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: ppp filter documentation errors
X-Send-Pr-Version: www-1.0

>Number:         22088
>Category:       docs
>Synopsis:       ppp filter documentation errors
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 18 08:30:01 PDT 2000
>Closed-Date:    Thu Nov 23 10:08:25 GMT 2000
>Last-Modified:  Thu Nov 23 10:10:27 GMT 2000
>Originator:     John Murphy
>Release:        4.1
>Organization:
>Environment:
FreeBSD wall.my.domain 4.1-RELEASE FreeBSD 4.1-RELEASE #4: Tue Oct 17 15:45:55 BST 2000     root@wall.my.domain:/usr/src/sys/compile/WALL  i386
>Description:
Section 6.2 'Playing with PPP filters' of the pedantic ppp primer at:

http://www.freebsd.org/tutorials/ppp/x879.html

refers to filter syntax as afilter, dfilter, ifilter etc.
whereas they actually need to be filter alive, filter dial etc.

----------------------Also---------------------------------------------

/usr/share/examples/ppp/ppp.conf.sample

Shows example filter lines of the form:

    set filter alive 0 deny udp src eq 520         # routed
    set filter alive 1 deny udp dst eq 520         # routed
    set filter alive 2 deny udp src eq 513         # rwhod
    set filter alive 3 deny udp src eq 525         # timed

All of these lines fail with syntax errors like:

Warning: ParseUdpOrTcp: bad src/dst port syntax:

Apparently because of the remarks!


>How-To-Repeat:
Use 'set filter' lines in ppp.conf with trailing remarks.
>Fix:
Remove the remarks, or suggest in
/usr/share/examples/ppp/ppp.conf.sample that trailing remarks
should not be left on filter lines in a working ppp.conf.

>Release-Note:
>Audit-Trail:

From: John Murphy <john253@crosswinds.net>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: docs/22088: ppp filter documentation errors
Date: Tue, 21 Nov 2000 01:23:03 +0000

 On further investigation I found that the trailing
 remark problem applies to any line in ppp.conf but
 only if there are two or more spaces or tabs before
 the '#' eg:
 
  set speed 115200 # works
  set speed 115200  # fails
 
 Should I submit this as a problem with ppp
 rather than a documentation problem?
 
 John.
 
State-Changed-From-To: open->closed 
State-Changed-By: ben 
State-Changed-When: Thu Nov 23 10:08:25 GMT 2000 
State-Changed-Why:  
Committed, thanks! 

The PPP Primer was updated, and PPP has already been fixed to cope with 
remarks correctly, so that is no longer an issue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=22088 
>Unformatted:
