From jgh@FreeBSD.org  Wed Jan 15 19:48:29 2014
Return-Path: <jgh@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id D59D04CD
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jan 2014 19:48:29 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id C18FD1F3F
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jan 2014 19:48:29 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s0FJmTce053850
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jan 2014 19:48:29 GMT
	(envelope-from jgh@freefall.freebsd.org)
Received: (from jgh@localhost)
	by freefall.freebsd.org (8.14.7/8.14.7/Submit) id s0FJmTZA053849;
	Wed, 15 Jan 2014 19:48:29 GMT
	(envelope-from jgh)
Message-Id: <201401151948.s0FJmTZA053849@freefall.freebsd.org>
Date: Wed, 15 Jan 2014 19:48:29 GMT
From: Jason Helfman <jgh@FreeBSD.org>
Reply-To: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch][porters-handbook]: add needed whitespace in Makefile for port
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         185810
>Category:       docs
>Synopsis:       [patch][porters-handbook]: add needed whitespace in Makefile for port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wblock
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 15 19:50:00 UTC 2014
>Closed-Date:    Wed Jan 15 20:21:55 UTC 2014
>Last-Modified:  Wed Jan 15 20:30:00 UTC 2014
>Originator:     Jason Helfman
>Release:        FreeBSD 11.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r259961: Fri Dec 27 21:56:39 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64


	
>Description:
Any new port, or port in the tree is going to need a extra line before inclusion
of bsd.port.mk, so let's give committers and contributors less work by adding this
to documentation.

This passed building and testing successfully.

>How-To-Repeat:
	
>Fix:

Index: en_US.ISO8859-1/books/porters-handbook/book.xml
===================================================================
--- en_US.ISO8859-1/books/porters-handbook/book.xml	(revision 43542)
+++ en_US.ISO8859-1/books/porters-handbook/book.xml	(working copy)
@@ -156,6 +156,7 @@
 
 MAINTAINER=	youremail@example.com
 COMMENT=	Cat chasing a mouse all over the screen
+
 .include &lt;bsd.port.mk&gt;</programlisting>
 
       <note>
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->wblock 
Responsible-Changed-By: wblock 
Responsible-Changed-When: Wed Jan 15 20:05:02 UTC 2014 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185810 
State-Changed-From-To: open->closed 
State-Changed-By: wblock 
State-Changed-When: Wed Jan 15 20:21:29 UTC 2014 
State-Changed-Why:  
Embiggened patch committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=185810 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/185810: commit references a PR
Date: Wed, 15 Jan 2014 20:21:26 +0000 (UTC)

 Author: wblock
 Date: Wed Jan 15 20:21:18 2014
 New Revision: 43544
 URL: http://svnweb.freebsd.org/changeset/doc/43544
 
 Log:
   Add blank lines to delimit .include statements in Makefiles.
   
   PR:		docs/185810
   Submitted by:	Jason Helfman <jgh@FreeBSD.org>
 
 Modified:
   head/en_US.ISO8859-1/books/porters-handbook/book.xml
 
 Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml
 ==============================================================================
 --- head/en_US.ISO8859-1/books/porters-handbook/book.xml	Wed Jan 15 19:46:36 2014	(r43543)
 +++ head/en_US.ISO8859-1/books/porters-handbook/book.xml	Wed Jan 15 20:21:18 2014	(r43544)
 @@ -156,6 +156,7 @@ MASTER_SITES=	ftp://ftp.cs.columbia.edu/
  
  MAINTAINER=	youremail@example.com
  COMMENT=	Cat chasing a mouse all over the screen
 +
  .include &lt;bsd.port.mk&gt;</programlisting>
  
        <note>
 @@ -4718,7 +4719,9 @@ OPT1_CONFIGURE_OFF=	--no-test</programli
  	<para>is equivalent to:</para>
  
  	<programlisting>OPTIONS_DEFINE=	OPT1
 +
  .include &lt;bsd.port.options.mk&gt;
 +
  .if ! ${PORT_OPTIONS:MOPT1}
  CONFIGURE_ARGS+=	--no-test
  .endif</programlisting>
 @@ -12477,6 +12480,7 @@ pre-install:
  	and then some more stuff before installing, wow
  
  [and then the epilogue]
 +
  .include &lt;bsd.port.mk&gt;</programlisting>
    </chapter>
  
 _______________________________________________
 svn-doc-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-doc-all
 To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"
 
>Unformatted:
