From mandree@FreeBSD.org  Mon Jul 15 17:51:30 2013
Return-Path: <mandree@FreeBSD.org>
Received: from apollo.emma.line.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	by hub.freebsd.org (Postfix) with ESMTP id 143CBF46
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 15 Jul 2013 17:51:30 +0000 (UTC)
	(envelope-from mandree@FreeBSD.org)
Received: from mandree by apollo.emma.line.org with local (Exim 4.80.1 (FreeBSD))
	(envelope-from <mandree@FreeBSD.org>)
	id 1UymvS-000ADt-VA
	for FreeBSD-gnats-submit@freebsd.org; Mon, 15 Jul 2013 19:51:06 +0200
Message-Id: <E1UymvS-000ADt-VA@apollo.emma.line.org>
Date: Mon, 15 Jul 2013 19:51:06 +0200
From: Matthias Andree <mandree@FreeBSD.org>
Reply-To: Matthias Andree <mandree@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: committer's guide incomplete on ports removal 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         180579
>Category:       docs
>Synopsis:       committer's guide incomplete on ports removal
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wblock
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 15 18:00:00 UTC 2013
>Closed-Date:    Mon Jul 15 18:36:22 UTC 2013
>Last-Modified:  Mon Jul 15 18:40:00 UTC 2013
>Originator:     Matthias Andree
>Release:        FreeBSD 9.1-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD apollo.emma.line.org 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0: Mon Jun 17 11:42:37 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:

The Committer's Guide is incomplete with respect to removing ports.
I am looking at revision 42226 as obtained from 
<http://www.freebsd.org/doc/en/articles/committers-guide/article.html#idp74042160>

We used to use CVS, and hence section 13.2.1 "How do I remove an
existing port?" mentions, in a box:

* Then, remove the port:

1. Remove the port's files via svn remove.

2. Remove the SUBDIR listing of the port in the parent directory Makefile.

3. Add an entry to ports/MOVED.

4. Remove the port from ports/LEGAL if it is there.


This is incomplete in that step 1 mentions "remove the port's files".
This used to suffice because CVS only tracked files, and the client was
responsible for removing directories when the last contained file had
been removed.

With SVN, directories are tracked in addition to files.

I propose to change 1. to read:

Remove the port's files and its directory via svn remove.

	
>How-To-Repeat:
	
>Fix:

Change bullet 1 text from

    Remove the port's files via svn remove.

to

    Remove the port's files and its directory via svn remove.


	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->wblock 
Responsible-Changed-By: wblock 
Responsible-Changed-When: Mon Jul 15 18:22:20 UTC 2013 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180579 
State-Changed-From-To: open->closed 
State-Changed-By: wblock 
State-Changed-When: Mon Jul 15 18:35:54 UTC 2013 
State-Changed-Why:  
Correction made, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180579 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/180579: commit references a PR
Date: Mon, 15 Jul 2013 18:35:31 +0000 (UTC)

 Author: wblock
 Date: Mon Jul 15 18:35:24 2013
 New Revision: 42286
 URL: http://svnweb.freebsd.org/changeset/doc/42286
 
 Log:
   Removing a port also requires removing the directory.
   
   PR:		docs/180579
   Submitted by:	Matthias Andree <mandree@FreeBSD.org>
 
 Modified:
   head/en_US.ISO8859-1/articles/committers-guide/article.xml
 
 Modified: head/en_US.ISO8859-1/articles/committers-guide/article.xml
 ==============================================================================
 --- head/en_US.ISO8859-1/articles/committers-guide/article.xml	Mon Jul 15 15:23:13 2013	(r42285)
 +++ head/en_US.ISO8859-1/articles/committers-guide/article.xml	Mon Jul 15 18:35:24 2013	(r42286)
 @@ -3529,7 +3529,7 @@ ControlPersist yes</screen>
  
  		<procedure>
  		  <step>
 -		    <para>Remove the port's files via
 +		    <para>Remove the port's files and directory with
  		      <command>svn remove</command>.</para>
  		  </step>
  
 _______________________________________________
 svn-doc-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-doc-all
 To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"
 
>Unformatted:
