From jgh@FreeBSD.org  Tue Apr 23 06:43:51 2013
Return-Path: <jgh@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id CAFE9288;
	Tue, 23 Apr 2013 06:43:51 +0000 (UTC)
	(envelope-from jgh@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	by mx1.freebsd.org (Postfix) with ESMTP id ACCD01B67;
	Tue, 23 Apr 2013 06:43:51 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3N6hpXY033637;
	Tue, 23 Apr 2013 06:43:51 GMT
	(envelope-from jgh@freefall.freebsd.org)
Received: (from jgh@localhost)
	by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3N6hpbr033636;
	Tue, 23 Apr 2013 06:43:51 GMT
	(envelope-from jgh)
Message-Id: <201304230643.r3N6hpbr033636@freefall.freebsd.org>
Date: Tue, 23 Apr 2013 06:43:51 GMT
From: Jason Helfman <jgh@FreeBSD.org>
Reply-To: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: bapt@FreeBSD.org
Subject: [patch][porters-handbook]: add pkgconfig to USES, and drop USE_PKGCONFIG
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         178073
>Category:       docs
>Synopsis:       [patch][porters-handbook]: add pkgconfig to USES, and drop USE_PKGCONFIG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 23 06:50:00 UTC 2013
>Closed-Date:    Wed Apr 24 16:31:18 UTC 2013
>Last-Modified:  Wed Apr 24 17:00:00 UTC 2013
>Originator:     Jason Helfman
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r249172: Sat Apr 6 00:40:01 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64


	
>Description:
add USES= pkgconfig to handbook, and drop USE_PKGCONFIG
>How-To-Repeat:
	
>Fix:

Index: porters-handbook/book.xml
===================================================================
--- porters-handbook/book.xml	(revision 41472)
+++ porters-handbook/book.xml	(working copy)
@@ -5775,52 +5775,6 @@
       </sect2>
     </sect1>
 
-    <sect1 id="using-pkg-config">
-      <title>Using <literal>pkg-config</literal></title>
-
-      <para>If your ports requires <literal>pkg-config</literal>,
-	just set <makevar>USE_PKGCONFIG</makevar> to the following
-	possible values:</para>
-      <table frame="none">
-	<title>Values for <makevar>USE_PKGCONFIG</makevar></title>
-
-	<tgroup cols="2">
-	  <thead>
-	    <row>
-	      <entry>Definition</entry>
-	      <entry>Description</entry>
-	    </row>
-	  </thead>
-
-	  <tbody>
-	    <row>
-	      <entry><makevar>USE_PKGCONFIG= yes</makevar></entry>
-	      <entry>The ports uses pkg-config only at build
-		time</entry>
-	    </row>
-
-	    <row>
-	      <entry><makevar>USE_PKGCONFIG= build</makevar></entry>
-	      <entry>The ports uses pkg-config only at build
-		time</entry>
-	    </row>
-
-	    <row>
-	      <entry><makevar>USE_PKGCONFIG= run</makevar></entry>
-	      <entry>The ports uses pkg-config only at run
-		time</entry>
-	    </row>
-
-	    <row>
-	      <entry><makevar>USE_PKGCONFIG= both</makevar></entry>
-	      <entry>The ports uses pkg-config both at build and run
-		time</entry>
-	    </row>
-	  </tbody>
-	</tgroup>
-      </table>
-    </sect1>
-
     <sect1 id="using-gettext">
       <title>Using GNU <literal>gettext</literal></title>
 
Index: porters-handbook/uses.xml
===================================================================
--- porters-handbook/uses.xml	(revision 41472)
+++ porters-handbook/uses.xml	(working copy)
@@ -72,6 +72,19 @@
 </row>
 
 <row>
+  <entry><literal>pkgconfig</literal></entry>
+  <entry>none, <literal>build</literal>, <literal>run</literal>,
+    <literal>both</literal></entry>
+  <entry>Implies that the port uses <filename
+      role="package">devel/pkgconf</filename> in one way or another.  By
+    default, with no arguments or with the <literal>build</literal>
+    argument, it implies <command>pkg-config</command> as a build-time
+    dependency, <literal>run</literal> implies a run-time dependency,
+    and <literal>both</literal> implies both run-time and build-time
+    dependencies.</entry>
+</row>
+
+<row>
   <entry><literal>qmail</literal></entry>
   <entry>none, <literal>build</literal>, <literal>run</literal>,
     <literal>both</literal>, <literal>vars</literal></entry>
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Apr 23 23:57:51 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178073 

From: Benjamin Kaduk <kaduk@MIT.EDU>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: docs/178073: [patch][porters-handbook]: add pkgconfig to USES,
 and drop USE_PKGCONFIG
Date: Tue, 23 Apr 2013 21:56:02 -0400 (EDT)

 On Tue, 23 Apr 2013, eadler@freebsd.org wrote:
 
 > Synopsis: [patch][porters-handbook]: add pkgconfig to USES, and drop USE_PKGCONFIG
 >
 > Responsible-Changed-From-To: freebsd-doc->eadler
 > Responsible-Changed-By: eadler
 > Responsible-Changed-When: Tue Apr 23 23:57:51 UTC 2013
 > Responsible-Changed-Why:
 > I'll take it.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=178073
 
 % +  <entry><literal>pkgconfig</literal></entry>
 % +  <entry>none, <literal>build</literal>, <literal>run</literal>,
 % +    <literal>both</literal></entry>
 % +  <entry>Implies that the port uses <filename
 % +      role="package">devel/pkgconf</filename> in one way or another.  By
 % +    default, with no arguments or with the <literal>build</literal>
 
 This comma seems misplaced; at present it would seem to imply that the 
 no-argument or "build" behavior is the default -- logically, the default 
 is when no argument is specified and any other case is non-default.  I 
 think the comma should go after "arguments".
 
 % +    argument, it implies <command>pkg-config</command> as a build-time
 % +    dependency, <literal>run</literal> implies a run-time dependency,
 
 Semicolons to separate list items are worth considering here to reduce 
 risk of comma splice.
 
 -Ben
 
 % +    and <literal>both</literal> implies both run-time and build-time
 % +    dependencies.</entry>
 % +</row>
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Wed Apr 24 16:31:17 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178073 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/178073: commit references a PR
Date: Wed, 24 Apr 2013 16:53:18 +0000 (UTC)

 Author: eadler
 Date: Wed Apr 24 16:53:10 2013
 New Revision: 41488
 URL: http://svnweb.freebsd.org/changeset/doc/41488
 
 Log:
   Document the pkgconfig USES
   
   PR:		docs/178073
   Submitted by:	jgh
   Reviewed by:	bjk
   Approved by:	bcr
 
 Modified:
   head/en_US.ISO8859-1/books/porters-handbook/book.xml
   head/en_US.ISO8859-1/books/porters-handbook/uses.xml
 
 Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml
 ==============================================================================
 --- head/en_US.ISO8859-1/books/porters-handbook/book.xml	Wed Apr 24 16:11:15 2013	(r41487)
 +++ head/en_US.ISO8859-1/books/porters-handbook/book.xml	Wed Apr 24 16:53:10 2013	(r41488)
 @@ -5775,52 +5775,6 @@ CMAKE_SOURCE_PATH=	&dollar;{WRKSRC}/subp
        </sect2>
      </sect1>
  
 -    <sect1 id="using-pkg-config">
 -      <title>Using <literal>pkg-config</literal></title>
 -
 -      <para>If your ports requires <literal>pkg-config</literal>,
 -	just set <makevar>USE_PKGCONFIG</makevar> to the following
 -	possible values:</para>
 -      <table frame="none">
 -	<title>Values for <makevar>USE_PKGCONFIG</makevar></title>
 -
 -	<tgroup cols="2">
 -	  <thead>
 -	    <row>
 -	      <entry>Definition</entry>
 -	      <entry>Description</entry>
 -	    </row>
 -	  </thead>
 -
 -	  <tbody>
 -	    <row>
 -	      <entry><makevar>USE_PKGCONFIG= yes</makevar></entry>
 -	      <entry>The ports uses pkg-config only at build
 -		time</entry>
 -	    </row>
 -
 -	    <row>
 -	      <entry><makevar>USE_PKGCONFIG= build</makevar></entry>
 -	      <entry>The ports uses pkg-config only at build
 -		time</entry>
 -	    </row>
 -
 -	    <row>
 -	      <entry><makevar>USE_PKGCONFIG= run</makevar></entry>
 -	      <entry>The ports uses pkg-config only at run
 -		time</entry>
 -	    </row>
 -
 -	    <row>
 -	      <entry><makevar>USE_PKGCONFIG= both</makevar></entry>
 -	      <entry>The ports uses pkg-config both at build and run
 -		time</entry>
 -	    </row>
 -	  </tbody>
 -	</tgroup>
 -      </table>
 -    </sect1>
 -
      <sect1 id="using-gettext">
        <title>Using GNU <literal>gettext</literal></title>
  
 
 Modified: head/en_US.ISO8859-1/books/porters-handbook/uses.xml
 ==============================================================================
 --- head/en_US.ISO8859-1/books/porters-handbook/uses.xml	Wed Apr 24 16:11:15 2013	(r41487)
 +++ head/en_US.ISO8859-1/books/porters-handbook/uses.xml	Wed Apr 24 16:53:10 2013	(r41488)
 @@ -72,6 +72,21 @@
  </row>
  
  <row>
 +  <entry><literal>pkgconfig</literal></entry>
 +
 +  <entry>none, <literal>build</literal>, <literal>run</literal>,
 +    <literal>both</literal></entry>
 +
 +  <entry>Implies that the port uses <filename
 +      role="package">devel/pkgconf</filename> in one way or another.
 +    With no arguments or with the <literal>build</literal>
 +    argument, it implies <command>pkg-config</command> as a build-time
 +    dependency; <literal>run</literal> implies a run-time dependency;
 +    and <literal>both</literal> implies both run-time and build-time
 +    dependencies.</entry>
 +</row>
 +
 +<row>
    <entry><literal>qmail</literal></entry>
    <entry>none, <literal>build</literal>, <literal>run</literal>,
      <literal>both</literal>, <literal>vars</literal></entry>
 _______________________________________________
 svn-doc-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-doc-all
 To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"
 
>Unformatted:
