From jgh@FreeBSD.org  Mon Mar 11 06:54:22 2013
Return-Path: <jgh@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 93A2E4AE;
	Mon, 11 Mar 2013 06:54:22 +0000 (UTC)
	(envelope-from jgh@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87])
	by mx1.freebsd.org (Postfix) with ESMTP id 86311949;
	Mon, 11 Mar 2013 06:54:22 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2B6sMZh039961;
	Mon, 11 Mar 2013 06:54:22 GMT
	(envelope-from jgh@freefall.freebsd.org)
Received: (from jgh@localhost)
	by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2B6sM3I039960;
	Mon, 11 Mar 2013 06:54:22 GMT
	(envelope-from jgh)
Message-Id: <201303110654.r2B6sM3I039960@freefall.freebsd.org>
Date: Mon, 11 Mar 2013 06:54:22 GMT
From: Jason Helfman <jgh@FreeBSD.org>
Reply-To: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: bapt@freebsd.org
Subject: [patch] porters-handbook: remove information on deprecated OPTIONS framework
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         176836
>Category:       docs
>Synopsis:       [patch] porters-handbook: remove information on deprecated OPTIONS framework
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 11 07:00:00 UTC 2013
>Closed-Date:    Mon Mar 11 20:55:27 UTC 2013
>Last-Modified:  Mon Mar 11 21:00:00 UTC 2013
>Originator:     Jason Helfman
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r247807: Mon Mar 4 19:35:47 UTC 2013 peter@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64


	
>Description:
It is no longer necessary to mention old-style of port options.
This patch removes it.


>How-To-Repeat:
	
>Fix:

Index: books/porters-handbook/book.xml
===================================================================
--- books/porters-handbook/book.xml	(revision 41156)
+++ books/porters-handbook/book.xml	(working copy)
@@ -4574,27 +4574,6 @@
 .include &lt;bsd.port.mk&gt;</programlisting>
 	  </example>
 
-	  <example id="ports-options-old-style-use">
-	    <title>Old-Style Use of <makevar>OPTIONS</makevar></title>
-
-	    <programlisting>OPTIONS=	FOO "Enable option foo" On
-
-.include &lt;bsd.port.pre.mk&gt;
-
-.if defined(WITHOUT_FOO)
-CONFIGURE_ARGS+=	--without-foo
-.else
-CONFIGURE_ARGS+=	--with-foo
-.endif
-
-.include &lt;bsd.port.post.mk&gt;</programlisting>
-	  </example>
-
-	  <important>
-	    <para>This method of using <makevar>OPTIONS</makevar>
-	      is deprecated, and will be removed at some point.
-	      Do not use this method for new ports.</para>
-	  </important>
 	</sect3>
 
 	<sect3>
>Release-Note:
>Audit-Trail:

From: Baptiste Daroussin <bapt@freebsd.org>
To: bug-followup@freebsd.org, jgh@freebsd.org
Cc:  
Subject: Re: docs/176836: [patch] porters-handbook: remove information on
 deprecated OPTIONS framework
Date: Mon, 11 Mar 2013 21:19:22 +0100

 Approved, for portmgr part :)
 
 regards,
 Bapt
Responsible-Changed-From-To: freebsd-doc->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Mar 11 20:24:08 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176836 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Mon Mar 11 20:55:27 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176836 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/176836: commit references a PR
Date: Mon, 11 Mar 2013 20:55:39 +0000 (UTC)

 Author: eadler
 Date: Mon Mar 11 20:55:24 2013
 New Revision: 41165
 URL: http://svnweb.freebsd.org/changeset/doc/41165
 
 Log:
   Remove old style options from the porter's handbook.
   It is increasingly unused as most ports have been converted.
   
   PR:		docs/176836
   Submitted by:	jgh
   Reviewed by:	bapt
   Approved by:	bcr (mentor)
 
 Modified:
   head/en_US.ISO8859-1/books/porters-handbook/book.xml
 
 Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml
 ==============================================================================
 --- head/en_US.ISO8859-1/books/porters-handbook/book.xml	Mon Mar 11 20:55:21 2013	(r41164)
 +++ head/en_US.ISO8859-1/books/porters-handbook/book.xml	Mon Mar 11 20:55:24 2013	(r41165)
 @@ -4574,27 +4574,6 @@ CONFIGURE_ARGS+=	--without-examples
  .include &lt;bsd.port.mk&gt;</programlisting>
  	  </example>
  
 -	  <example id="ports-options-old-style-use">
 -	    <title>Old-Style Use of <makevar>OPTIONS</makevar></title>
 -
 -	    <programlisting>OPTIONS=	FOO "Enable option foo" On
 -
 -.include &lt;bsd.port.pre.mk&gt;
 -
 -.if defined(WITHOUT_FOO)
 -CONFIGURE_ARGS+=	--without-foo
 -.else
 -CONFIGURE_ARGS+=	--with-foo
 -.endif
 -
 -.include &lt;bsd.port.post.mk&gt;</programlisting>
 -	  </example>
 -
 -	  <important>
 -	    <para>This method of using <makevar>OPTIONS</makevar>
 -	      is deprecated, and will be removed at some point.
 -	      Do not use this method for new ports.</para>
 -	  </important>
  	</sect3>
  
  	<sect3>
 _______________________________________________
 svn-doc-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-doc-all
 To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"
 
>Unformatted:
