From nobody@FreeBSD.org  Wed Nov 28 15:40:24 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8CD5DCEA
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2012 15:40:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C1788FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2012 15:40:24 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qASFeOjU024219
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2012 15:40:24 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qASFeOaW024218;
	Wed, 28 Nov 2012 15:40:24 GMT
	(envelope-from nobody)
Message-Id: <201211281540.qASFeOaW024218@red.freebsd.org>
Date: Wed, 28 Nov 2012 15:40:24 GMT
From: Derek Wood <ddwood@outlook.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: fdp-primer quick start section makes reference to 'make lint'
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         173971
>Category:       docs
>Synopsis:       fdp-primer quick start section makes reference to 'make lint'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gabor
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 28 15:50:00 UTC 2012
>Closed-Date:    Fri May 17 18:59:25 UTC 2013
>Last-Modified:  Fri May 17 18:59:25 UTC 2013
>Originator:     Derek Wood
>Release:        
>Organization:
>Environment:
>Description:
As per eadler@, 'make lint' in the FreeBSD document tree is broken, and the reference to it in the fdp-primer book ( http://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/overview-quick-start.html ) is erroneous.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:

From: Eitan Adler <lists@eitanadler.com>
To: Derek Wood <ddwood@outlook.com>, Hiroki Sato <hrs@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: docs/173971: fdp-primer quick start section makes reference to
 'make lint'
Date: Wed, 28 Nov 2012 11:59:13 -0500

 [ccing hrs as he is the one whom added the target in the first place]
 
 On 28 November 2012 10:40, Derek Wood <ddwood@outlook.com> wrote:
 > As per eadler@, 'make lint' in the FreeBSD document tree is broken, and the reference to it in the fdp-primer book ( http://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/overview-quick-start.html ) is erroneous.
 >>How-To-Repeat:
 
 My understanding is that the "make lint" target is currently broken
 and non-useful.  If I am wrong and this target is intended to work
 please let me know.
 
 This patch removes the target and text explaining it.
 
 commit 2e984ecbace3df739ecf147c76fcd6d2645c33cb
 Author: Eitan Adler <lists@eitanadler.com>
 Date:   Wed Nov 28 11:57:26 2012 -0500
 
     Remove 'lint' make target which is currently broken and non-useful.
 
     PR:		docs/173971
     Submitted by:	Derek Wood <ddwood@outlook.com> (pr)
 
 diff --git a/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 b/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 index 2930c47..6fecb16 100644
 --- a/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 +++ b/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 @@ -257,13 +257,6 @@
        </step>
 
        <step>
 -	<para>Test the markup using the <maketarget>lint</maketarget>
 -	  target.  This will quickly find any errors in the document
 -	  without actually performing the time-consuming
 -	  transformation.</para>
 -
 -	<screen>&prompt.user; <userinput>make lint</userinput></screen>
 -
  	<para>When you are ready to actually build the document, you
  	  may specify a single format or a list of formats in the
  	  <varname>FORMATS</varname> variable.  Currently,
 diff --git a/share/mk/doc.xml.mk b/share/mk/doc.xml.mk
 index a749ae9..a4b1229 100644
 --- a/share/mk/doc.xml.mk
 +++ b/share/mk/doc.xml.mk
 @@ -373,13 +373,5 @@ ${TARGET.${_ID}}: ${XML.${_ID}} ${DEPENDS.${_ID}}
  	${XSLTPROC} ${XSLTPROCOPTS.${_ID}} \
  		-o ${.TARGET} ${PARAMS.${_ID}} \
  		${XSLT.${_ID}} ${XML.${_ID}}
 -
 -VALIDATE_DOCS+=	VALIDATE.${_ID}
 -VALIDATE.${_ID}:
 -	@${ECHO} "==>[xmllint] ${XML.${_ID}}"
 -	-@${XMLLINT} ${XMLLINTOPTS} ${XML.${_ID}} 2>&1  \
 -		| ${SED} -e 's/^/ | /'
  .  endfor
  .endfor
 -
 -lint: ${VALIDATE_DOCS}
 
 
 
 -- 
 Eitan Adler

From: Gabor Kovesdan <gabor@FreeBSD.org>
To: bug-followup@FreeBSD.org, ddwood@outlook.com
Cc:  
Subject: Re: docs/173971: fdp-primer quick start section makes reference to
 &#39;make lint&#39;
Date: Wed, 28 Nov 2012 23:22:25 +0100

 The make lint target is going to work soon. Please do not remove the
 references from fdp-primer
 
 Gabor

From: Eitan Adler <lists@eitanadler.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: docs/173971: fdp-primer quick start section makes reference to
 &#39;make lint&#39;
Date: Thu, 29 Nov 2012 21:54:11 -0500

 ---------- Forwarded message ----------
 From: Eitan Adler <lists@eitanadler.com>
 Date: 28 November 2012 21:21
 Subject: Re: docs/173971: fdp-primer quick start section makes
 reference to &#39;make lint&#39;
 To: Gabor Kovesdan <gabor@freebsd.org>
 Cc: freebsd-doc@freebsd.org
 
 
 On 28 November 2012 17:40, Gabor Kovesdan <gabor@freebsd.org> wrote:
 > The following reply was made to PR docs/173971; it has been noted by GNATS.
 >
 > From: Gabor Kovesdan <gabor@FreeBSD.org>
 > To: bug-followup@FreeBSD.org, ddwood@outlook.com
 > Cc:
 > Subject: Re: docs/173971: fdp-primer quick start section makes reference to
 >  &#39;make lint&#39;
 > Date: Wed, 28 Nov 2012 23:22:25 +0100
 >
 >  The make lint target is going to work soon. Please do not remove the
 >  references from fdp-primer
 
 okay. I'll leave this PR open as "make lint doesn't work."  Please
 close it when the fix is committed.
 
 --
 Eitan Adler
 
 
 -- 
 Eitan Adler
Responsible-Changed-From-To: freebsd-doc->gabor 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Dec 11 18:22:15 UTC 2012 
Responsible-Changed-Why:  
over to owner 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173971 
State-Changed-From-To: open->closed 
State-Changed-By: gabor 
State-Changed-When: Fri May 17 18:58:59 UTC 2013 
State-Changed-Why:  
Running make lint works again. Thanks for your report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173971 
>Unformatted:
