From mexas@bristol.ac.uk  Thu Nov  1 15:10:56 2012
Return-Path: <mexas@bristol.ac.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CA1C4282
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  1 Nov 2012 15:10:56 +0000 (UTC)
	(envelope-from mexas@bristol.ac.uk)
Received: from dirg.bris.ac.uk (dirg.bris.ac.uk [137.222.10.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 7F4E58FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  1 Nov 2012 15:10:56 +0000 (UTC)
Received: from irix.bris.ac.uk ([137.222.10.39] helo=ncs.bris.ac.uk)
	by dirg.bris.ac.uk with esmtp (Exim 4.72)
	(envelope-from <mexas@bristol.ac.uk>)
	id 1TTwPz-0007ES-LI
	for FreeBSD-gnats-submit@freebsd.org; Thu, 01 Nov 2012 15:10:54 +0000
Received: from mech-cluster241.men.bris.ac.uk ([137.222.187.241])
	by ncs.bris.ac.uk with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.72)
	(envelope-from <mexas@bris.ac.uk>)
	id 1TTwPz-0002jC-G9
	for FreeBSD-gnats-submit@freebsd.org; Thu, 01 Nov 2012 15:10:51 +0000
Received: from mech-cluster241.men.bris.ac.uk (localhost [127.0.0.1])
	by mech-cluster241.men.bris.ac.uk (8.14.5/8.14.5) with ESMTP id qA1FApMC012211
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 1 Nov 2012 15:10:51 GMT
	(envelope-from mexas@mech-cluster241.men.bris.ac.uk)
Received: (from mexas@localhost)
	by mech-cluster241.men.bris.ac.uk (8.14.5/8.14.5/Submit) id qA1FAo1u012210;
	Thu, 1 Nov 2012 15:10:50 GMT
	(envelope-from mexas)
Message-Id: <201211011510.qA1FAo1u012210@mech-cluster241.men.bris.ac.uk>
Date: Thu, 1 Nov 2012 15:10:50 GMT
From: Anton Shterenlikht <mexas@bristol.ac.uk>
Reply-To: Anton Shterenlikht <mexas@bristol.ac.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: improving <a|c|m>min option description for find(1) 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         173265
>Category:       docs
>Synopsis:       improving <a|c|m>min option description for find(1)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 01 15:20:00 UTC 2012
>Closed-Date:    Mon Feb 04 00:31:19 UTC 2013
>Last-Modified:  Mon Feb 04 00:31:19 UTC 2013
>Originator:     Anton Shterenlikht
>Release:        FreeBSD 10.0-CURRENT ia64
>Organization:
University of Bristol
>Environment:
System: FreeBSD mech-cluster241.men.bris.ac.uk 10.0-CURRENT FreeBSD 10.0-CURRENT #6 r237134: Mon Jun 18 09:02:17 BST 2012 root@mech-cluster241.men.bris.ac.uk:/usr/obj/usr/src/sys/TZAV ia64


	
>Description:

find(1) man page has:

     -amin n
             True if the difference between the file last access time and the
             time find was started, rounded up to the next full minute, is n
             minutes.

     -cmin n
             True if the difference between the time of last change of file
             status information and the time find was started, rounded up to
             the next full minute, is n minutes.

     -mmin n
             True if the difference between the file last modification time
             and the time find was started, rounded up to the next full
             minute, is n minutes.

The description is not clear enough.
It is not clear that n can be +n, -n or
just n, and that the meaning will change.

In "UNIX in a nutshell" by Arnold Robbins, 4th edition, 2006,
pages 87-88, there is, in my opinion, a more clear description:

*quote*
-amin +n | -n | n
	Find files last accessed more than n (+n),
	less that n (-n), or exactly n minutes ago.

-cmin +n | -n | n
	Find files last changed more than n (+n),
	less that n (-n), or exactly n minutes ago.

-mmin +n | -n | n
	Find files last modified more than n (+n),
	less that n (-n), or exactly n minutes ago.
*end quote*

Does anybody agree/disagree with me?

	
>How-To-Repeat:
	
>Fix:

I'll provide a patch if there is agreement.

	
>Release-Note:
>Audit-Trail:

From: Glen Barber <gjb@FreeBSD.org>
To: Anton Shterenlikht <mexas@bristol.ac.uk>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/173265: improving <a|c|m>min option description for find(1)
Date: Thu, 1 Nov 2012 22:32:36 -0400

 --Pd0ReVV5GZGQvF3a
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Thu, Nov 01, 2012 at 03:10:50PM +0000, Anton Shterenlikht wrote:
 > I'll provide a patch if there is agreement.
 
 I think this looks sane.  If you could provide a patch, that would be
 great.
 
 Glen
 
 
 --Pd0ReVV5GZGQvF3a
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (FreeBSD)
 
 iQEcBAEBCAAGBQJQkzDEAAoJEFJPDDeguUajRkAH/2F4aZjteuyjz383iHFwtgq0
 dGosivdbJ1ub57JskV4kiQjHqh+dUSjFT5QGWbKXKZjKge4AQ2yH/odQMg9zVNM2
 4fb059m8njgAaSXVT4pc0qNiLu24MhBCS5KFP82yqELDEKFTcSt1t21l+zDegk8V
 ES9dI4mA65BYc8RFeFf7K7aQW/2vPg5NUrBytqAETd6r9sSVpq78H8LTxavX5lHp
 fRnmk3D+mF0+vbLCX9KL6eH2bAjjJo6B6CJbkyc8pHdU24tYluWV+T678sSaxvcO
 8i/wRYMVeko8L7G+PWpwpO+lfNcDkyfEIATDkyPK/eOM6XQxc+CtIO3vuork7UQ=
 =ufbr
 -----END PGP SIGNATURE-----
 
 --Pd0ReVV5GZGQvF3a--

From: Anton Shterenlikht <mexas@bristol.ac.uk>
To: bug-followup@freebsd.org
Cc:  
Subject: RE: docs/173265: improving <a|c|m>min option description for find(1)
Date: Fri, 2 Nov 2012 12:41:10 GMT

 See the patch below.
 It seems the find(1) man page
 favours arguments of the form -cmin [-|+]n
 over -cmin -n | +n | n.
 So I made my patch accordingly.
 With the patch the page now renders as:
 
      -amin [-|+]n
              Find files last accessed more than n (+n), less than n (-n), or
              exactly n minutes ago.
      -cmin [-|+]n
              Find files last changed more than n (+n), less than n (-n), or
              exactly n minutes ago.
      -mmin [-|+]n
              Find files last modified more than n (+n), less than n (-n), or
              exactly n minutes ago.
 
 Anton
 
  
 Index: usr.bin/find/find.1
 ===================================================================
 --- usr.bin/find/find.1	(revision 238585)
 +++ usr.bin/find/find.1	(working copy)
 @@ -203,12 +203,16 @@
  See
  .Xr acl 3
  for more information.
 -.It Ic -amin Ar n
 -True if the difference between the file last access time and the time
 -.Nm
 -was started, rounded up to the next full minute, is
 +.It Ic -amin Oo Cm - Ns | Ns Cm + Oc Ns Ar n
 +Find files last accessed more than
  .Ar n
 -minutes.
 +.Pq + Ns Ar n ,
 +less than
 +.Ar n
 +.Pq - Ns Ar n ,
 +or exactly
 +.Ar n
 +minutes ago.
  .It Ic -anewer Ar file
  Same as
  .Ic -neweram .
 @@ -250,13 +254,16 @@
  or
  .Cm -
  modifier.
 -.It Ic -cmin Ar n
 -True if the difference between the time of last change of file status
 -information and the time
 -.Nm
 -was started, rounded up to the next full minute, is
 +.It Ic -cmin Oo Cm - Ns | Ns Cm + Oc Ns Ar n
 +Find files last changed more than
  .Ar n
 -minutes.
 +.Pq + Ns Ar n ,
 +less than
 +.Ar n
 +.Pq - Ns Ar n ,
 +or exactly
 +.Ar n
 +minutes ago.
  .It Ic -cnewer Ar file
  Same as
  .Ic -newercm .
 @@ -538,12 +545,16 @@
  not normally be evaluated.
  .Dq Ic -mindepth Li 1
  processes all but the command line arguments.
 -.It Ic -mmin Ar n
 -True if the difference between the file last modification time and the time
 -.Nm
 -was started, rounded up to the next full minute, is
 +.It Ic -mmin Oo Cm - Ns | Ns Cm + Oc Ns Ar n
 +Find files last modified more than
  .Ar n
 -minutes.
 +.Pq + Ns Ar n ,
 +less than
 +.Ar n
 +.Pq - Ns Ar n ,
 +or exactly
 +.Ar n
 +minutes ago.
  .It Ic -mnewer Ar file
  Same as
  .Ic -newer .
Responsible-Changed-From-To: freebsd-doc->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Nov 2 15:06:03 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173265 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Fri Nov 2 15:23:51 UTC 2012 
State-Changed-Why:  
awaiting approval or review prior to commit (no action needed from 
submitter)  note that I opted to only take part of the patch; in 
particular I kept the language 'True if the difference between the file 
last access time and the time...' 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173265 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Mon Nov 19 13:11:00 UTC 2012 
State-Changed-Why:  
committed in r243239 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173265 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Mon Feb 4 00:31:18 UTC 2013 
State-Changed-Why:  
due to merge conflicts I shall not be MFCing this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=173265 
>Unformatted:
