From nobody@FreeBSD.org  Fri Apr 27 23:00:53 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C62381065678
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Apr 2012 23:00:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B111D8FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Apr 2012 23:00:53 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3RN0rDU038945
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Apr 2012 23:00:53 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q3RN0rwe038944;
	Fri, 27 Apr 2012 23:00:53 GMT
	(envelope-from nobody)
Message-Id: <201204272300.q3RN0rwe038944@red.freebsd.org>
Date: Fri, 27 Apr 2012 23:00:53 GMT
From: "John W. O'Brien" <john@saltant.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: geli.8 out of sync after r226840 re: kernel threads
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         167382
>Category:       docs
>Synopsis:       geli.8 out of sync after r226840 re: kernel threads
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gjb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 27 23:10:10 UTC 2012
>Closed-Date:    Sat Apr 28 20:38:45 UTC 2012
>Last-Modified:  Sat Apr 28 20:38:45 UTC 2012
>Originator:     John W. O'Brien
>Release:        9-STABLE
>Organization:
Saltant Solutions
>Environment:
FreeBSD nippl.y.saltant.net 9.0-STABLE FreeBSD 9.0-STABLE #0: Mon Apr  9 07:44:49 EDT 2012     root@nippl.y.saltant.net:/usr/obj/usr/src/sys/NIPPL  amd64
>Description:
r226840 did not update description of affected behavior in geli(8) manpage.
>How-To-Repeat:
man geli
Search for "kern.geom.eli.threads".
Observe that following r226840, number of threads is not limited when, e.g., AESNI instructions are available.
>Fix:
Strike line stating that only one thread will be started when using hardware crypto acceleration.

Patch attached with submission follows:

Index: geli.8
===================================================================
--- geli.8	(revision 234740)
+++ geli.8	(working copy)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd March 4, 2012
+.Dd April 27, 2012
 .Dt GELI 8
 .Os
 .Sh NAME
@@ -692,7 +692,6 @@
 Specifies how many kernel threads should be used for doing software
 cryptography.
 Its purpose is to increase performance on SMP systems.
-If hardware acceleration is available, only one thread will be started.
 If set to 0, a CPU-pinned thread will be started for every active CPU.
 .It Va kern.geom.eli.batch : No 0
 When set to 1, can speed-up crypto operations by using batching.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->gjb 
Responsible-Changed-By: gjb 
Responsible-Changed-When: Sat Apr 28 01:27:06 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=167382 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/167382: commit references a PR
Date: Sat, 28 Apr 2012 20:23:23 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Sat Apr 28 20:23:13 2012
 New Revision: 234770
 URL: http://svn.freebsd.org/changeset/base/234770
 
 Log:
   As of r226840, GELI starts one thread per CPU.
   
   PR:		167382
   Submitted by:	John W. O'Brien (john%saltant.com)
   X-Needs-MFC:	r226840
 
 Modified:
   head/sbin/geom/class/eli/geli.8
 
 Modified: head/sbin/geom/class/eli/geli.8
 ==============================================================================
 --- head/sbin/geom/class/eli/geli.8	Sat Apr 28 18:57:27 2012	(r234769)
 +++ head/sbin/geom/class/eli/geli.8	Sat Apr 28 20:23:13 2012	(r234770)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd March 4, 2012
 +.Dd April 28, 2012
  .Dt GELI 8
  .Os
  .Sh NAME
 @@ -692,7 +692,6 @@ This variable should be set in
  Specifies how many kernel threads should be used for doing software
  cryptography.
  Its purpose is to increase performance on SMP systems.
 -If hardware acceleration is available, only one thread will be started.
  If set to 0, a CPU-pinned thread will be started for every active CPU.
  .It Va kern.geom.eli.batch : No 0
  When set to 1, can speed-up crypto operations by using batching.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: gjb 
State-Changed-When: Sat Apr 28 20:38:20 UTC 2012 
State-Changed-Why:  
Committed, thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=167382 
>Unformatted:
