From jhelfman@experts-exchange.com  Thu Mar 29 21:08:14 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9A56A106566B;
	Thu, 29 Mar 2012 21:08:14 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 78F968FC17;
	Thu, 29 Mar 2012 21:08:14 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id 314E96FF532;
	Thu, 29 Mar 2012 14:08:14 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id yXvl0uYAqVqC; Thu, 29 Mar 2012 14:08:14 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id 0DA8E6F3880;
	Thu, 29 Mar 2012 14:08:14 -0700 (PDT)
Received: (nullmailer pid 9901 invoked by uid 1001);
	Thu, 29 Mar 2012 21:07:19 -0000
Message-Id: <1333055239.029442.9900.nullmailer@experts-exchange.com>
Date: Thu, 29 Mar 2012 14:07:19 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: doc@FreeBSD.org
Subject: [PATCH] porters-handbook: add make readme to testing, document post-deinstall as invalid
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166502
>Category:       docs
>Synopsis:       [PATCH] porters-handbook: add make readme to testing, document post-deinstall as invalid
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bcr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 29 21:10:10 UTC 2012
>Closed-Date:    Wed Apr 18 20:02:17 UTC 2012
>Last-Modified:  Wed Apr 18 20:02:17 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
make readme should be tested as part of the porting process
post-deinstall is not a vaild target, and should be documented

Port maintainer (doc@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- .patch begins here ---
Index: book.sgml
===================================================================
RCS file: /usr/local/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
retrieving revision 1.1173
diff -u -r1.1173 book.sgml
--- book.sgml	22 Mar 2012 04:09:20 -0000	1.1173
+++ book.sgml	29 Mar 2012 21:02:50 -0000
@@ -345,6 +345,10 @@
 	<step>
 	  <para><command>make package</command></para>
 	</step>
+
+	<step>
+	  <para><command>make readme</command></para>
+	</step>
       </procedure>
 
       <para>Make sure that there are not any warnings issued in any of
@@ -576,7 +580,9 @@
 	  intended to be changed.  If you want to fix the extraction,
 	  fix <maketarget>do-extract</maketarget>, but never ever
 	  change the way <maketarget>extract</maketarget>
-	  operates!</para>
+	  operates! Additionally, the target <maketarget>post-deinstall
+	  </maketarget> is invalid and is not run by the ports
+	  infrastructure.</para>
       </note>
 
       <para>Now that you understand what goes on when the user types
--- .patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->bcr  
Responsible-Changed-By: bcr 
Responsible-Changed-When: Wed Apr 18 19:41:25 UTC 2012 
Responsible-Changed-Why:  
Grab this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166502 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/166502: commit references a PR
Date: Wed, 18 Apr 2012 19:51:12 +0000 (UTC)

 bcr         2012-04-18 19:50:58 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/porters-handbook book.sgml 
   Log:
   Advise porters that as part of the porting process, make readme
   should also be tested.
   In addition to that, document that post-deinstall is not a valid
   target and is not run by the ports infrastructure.
   
   PR:             docs/166502
   Submitted by:   jgh
   
   Revision  Changes    Path
   1.1181    +7 -1      doc/en_US.ISO8859-1/books/porters-handbook/book.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: bcr 
State-Changed-When: Wed Apr 18 20:01:28 UTC 2012 
State-Changed-Why:  
Patch committed with minor adjustments. Thanks for sending the patch! PR closed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166502 
>Unformatted:
