From jgh@FreeBSD.org  Fri Dec 30 18:25:13 2011
Return-Path: <jgh@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 937ED106566C;
	Fri, 30 Dec 2011 18:25:13 +0000 (UTC)
	(envelope-from jgh@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 828F88FC12;
	Fri, 30 Dec 2011 18:25:13 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBUIPDpF002905;
	Fri, 30 Dec 2011 18:25:13 GMT
	(envelope-from jgh@freefall.freebsd.org)
Received: (from jgh@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBUIPDgc002904;
	Fri, 30 Dec 2011 18:25:13 GMT
	(envelope-from jgh)
Message-Id: <201112301825.pBUIPDgc002904@freefall.freebsd.org>
Date: Fri, 30 Dec 2011 18:25:13 GMT
From: Jason Helfman <jgh@freebsd.org>
Reply-To: Jason Helfman <jgh@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: crees@freebsd.org
Subject: [patch] books/porters-handbook: add note regarding breakage of README.html
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         163723
>Category:       docs
>Synopsis:       [patch] books/porters-handbook: add note regarding breakage of README.html
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wblock
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 30 18:30:21 UTC 2011
>Closed-Date:    Tue Jan 03 23:09:12 UTC 2012
>Last-Modified:  Tue Jan  3 23:10:10 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
>Environment:


	
>Description:
reassignment of ECHO_MSG breaks 'make readme'.
I added a note tag to have it stand out more to the reader.

http://www.freebsd.org/cgi/query-pr-summary.cgi?category=&severity=&priority=&class=&state=&sort=none&text=readme&responsible=jgh&multitext=&originator=&closedtoo=on&release=
>How-To-Repeat:
	
>Fix:

Index: book.sgml
===================================================================
RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
retrieving revision 1.1136
diff -u -r1.1136 book.sgml
--- book.sgml	26 Dec 2011 04:46:11 -0000	1.1136
+++ book.sgml	30 Dec 2011 18:19:13 -0000
@@ -14892,6 +14892,12 @@
 	file is not part of the cvs collection but is generated using the
 	<command>make readme</command> command.
 	</para>
+
+      <note>
+        <para>Additionally, avoid reassignment of <makevar>ECHO_MSG
+	  </makevar> as this will break the <command>make readme</command>
+	  command.</para>
+      </note>
     </sect1>
 
     <sect1 id="dads-noinstall">
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->wblock 
Responsible-Changed-By: wblock 
Responsible-Changed-When: Tue Jan 3 00:37:36 UTC 2012 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163723 
State-Changed-From-To: open->closed 
State-Changed-By: wblock 
State-Changed-When: Tue Jan 3 23:08:13 UTC 2012 
State-Changed-Why:  
Committed a rewrite of the original patch submitted.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163723 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/163723: commit references a PR
Date: Tue,  3 Jan 2012 23:07:42 +0000 (UTC)

 wblock      2012-01-03 23:07:34 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/porters-handbook book.sgml 
   Log:
   Add a warning about redefining ECHO_MSG breaking make readme.  This is a
   rewrite of the patch submitted by jgh.
   
   PR:             docs/163723
   Reviewed by:    jgh
   Approved by:    gjb (mentor)
   
   Revision  Changes    Path
   1.1144    +6 -0      doc/en_US.ISO8859-1/books/porters-handbook/book.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
