From nobody@FreeBSD.org  Sat Dec 10 10:13:14 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D2D31065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Dec 2011 10:13:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id F13468FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Dec 2011 10:13:13 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBAADD8a029026
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 10 Dec 2011 10:13:13 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pBAADD9P029018;
	Sat, 10 Dec 2011 10:13:13 GMT
	(envelope-from nobody)
Message-Id: <201112101013.pBAADD9P029018@red.freebsd.org>
Date: Sat, 10 Dec 2011 10:13:13 GMT
From: Oliver Hartmann <ohartman@zedat.fu-berlin.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: make.conf(5): Update via 'svn' incomplete described.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         163162
>Category:       docs
>Synopsis:       make.conf(5): Update via 'svn' incomplete described.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gjb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 10 10:20:05 UTC 2011
>Closed-Date:    Mon Jan 02 22:27:40 UTC 2012
>Last-Modified:  Mon Jan 02 22:27:40 UTC 2012
>Originator:     Oliver Hartmann
>Release:        FreeBSD 10.0-CURRENT/amd64
>Organization:
FU Berlin
>Environment:
>Description:
make.conf(5) describes SVN_UPDATE variable to be set for usage subversion for updating and maintainig /usr/src via "make update". But as with the recent settings and even with SVN_UPDATE set to YES in make.conf a simply "make update" typed in /usr/src will fail with a "svn not found" error, since the path to svn hasn't been properly set.
The file /usr/src/Makefile.inc1 reveals that there are to flags that could be set to target mainance via svn: SVN itself targetting the path to the svn binary and SVNFLAGS setting for the repository to be targeted. None of them are mentioned in make.conf(5) and I'd like to see some notes in make.conf(5) on that. 
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:

From: Benjamin Kaduk <kaduk@MIT.EDU>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: docs/163162: make.conf(5): Update via 'svn' incomplete
 described.
Date: Sat, 10 Dec 2011 22:38:12 -0500 (EST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 ---559023410-1942965987-1323574692=:882
 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
 
 On Sat, 10 Dec 2011, Oliver Hartmann wrote:
 
 >> Description:
 > make.conf(5) describes SVN_UPDATE variable to be set for usage subversion for updating and maintainig /usr/src via "make update". But as with the recent settings and even with SVN_UPDATE set to YES in make.conf a simply "make update" typed in /usr/src will fail with a "svn not found" error, since the path to svn hasn't been properly set.
 > The file /usr/src/Makefile.inc1 reveals that there are to flags that could be set to target mainance via svn: SVN itself targetting the path to the svn binary and SVNFLAGS setting for the repository to be targeted. None of them are mentioned in make.conf(5) and I'd like to see some notes in make.conf(5) on that.
 
 The patch I sent to the thread on -current is attached.
 
 -Ben Kaduk
 ---559023410-1942965987-1323574692=:882
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=make.conf.5.diff.txt
 Content-Transfer-Encoding: BASE64
 Content-ID: <alpine.GSO.1.10.1112102238120.882@multics.mit.edu>
 Content-Description: 
 Content-Disposition: attachment; filename=make.conf.5.diff.txt
 
 LS0tIG1ha2UuY29uZi41Lm9yaWcJMjAxMS0xMi0xMCAxOTowNDoyMS4wMDAw
 MDAwMDAgLTA1MDANCisrKyBtYWtlLmNvbmYuNQkyMDExLTEyLTEwIDE5OjEw
 OjEzLjAwMDAwMDAwMCAtMDUwMA0KQEAgLTMzMyw2ICszMzMsMTIgQEANCiAu
 UGEgc3JjDQogdHJlZSB3aXRoDQogLkRxIExpICJtYWtlIHVwZGF0ZSIgLg0K
 K05vdGUgdGhhdCBzaW5jZSB0aGVyZSBpcyBub3QgYSBzdWJ2ZXJzaW9uIGNs
 aWVudCBpbiB0aGUgYmFzZSBzeXN0ZW0sDQoreW91IHdpbGwgbmVlZCB0byBz
 ZXQNCisuVmEgU1ZODQordG8gdGhlIHBhdGggdG8gYQ0KKy5YciBzdm4gMQ0K
 K2JpbmFyeS4NCiAuSXQgVmEgV1dXU1VQRklMRQ0KIC5QcSBWdCBzdHINCiBU
 aGUgd3d3DQo=
 
 ---559023410-1942965987-1323574692=:882--
Responsible-Changed-From-To: freebsd-doc->gjb 
Responsible-Changed-By: gjb 
Responsible-Changed-When: Sun Dec 11 03:46:22 UTC 2011 
Responsible-Changed-Why:  
Make this mine. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=163162 
State-Changed-From-To: open->patched 
State-Changed-By: gjb 
State-Changed-When: Sun Dec 11 19:53:28 UTC 2011 
State-Changed-Why:  
Patched in head (r228418) pending MFC. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=163162 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/163162: commit references a PR
Date: Sun, 11 Dec 2011 19:53:26 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Sun Dec 11 19:53:11 2011
 New Revision: 228418
 URL: http://svn.freebsd.org/changeset/base/228418
 
 Log:
   Document the SVN variable needs to be set in make.conf(5) when SVN_UPDATE
   is set.
   
   PR:		163162
   Submitted by:	Oliver Hartmann <ohartman!zedat.fu-berlin.de>
   Patch by:	Benjamin Kaduk <kaduk!mit.edu> (original)
   MFC after:	1 week
 
 Modified:
   head/share/man/man5/make.conf.5
 
 Modified: head/share/man/man5/make.conf.5
 ==============================================================================
 --- head/share/man/man5/make.conf.5	Sun Dec 11 19:28:04 2011	(r228417)
 +++ head/share/man/man5/make.conf.5	Sun Dec 11 19:53:11 2011	(r228418)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd June 16, 2011
 +.Dd December 11, 2011
  .Dt MAKE.CONF 5
  .Os
  .Sh NAME
 @@ -333,6 +333,12 @@ to update your
  .Pa src
  tree with
  .Dq Li "make update" .
 +Note that since a subversion client is not included in the base system,
 +you will need to set
 +.Va SVN
 +to the full path of a
 +.Xr svn 1
 +binary.
  .It Va WWWSUPFILE
  .Pq Vt str
  The www
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/163162: commit references a PR
Date: Mon,  2 Jan 2012 22:11:28 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Mon Jan  2 22:11:08 2012
 New Revision: 229320
 URL: http://svn.freebsd.org/changeset/base/229320
 
 Log:
   MFC r228418, 228419:
   
   r228418:
    - Document the SVN variable needs to be set in make.conf(5) when
      SVN_UPDATE is set [1]
   
   r228419:
    - Minor whitespace cleanup to make.conf(5)
   
   PR:		163162 [1]
 
 Modified:
   stable/9/share/man/man5/make.conf.5
 Directory Properties:
   stable/9/share/man/man5/   (props changed)
 
 Modified: stable/9/share/man/man5/make.conf.5
 ==============================================================================
 --- stable/9/share/man/man5/make.conf.5	Mon Jan  2 21:57:58 2012	(r229319)
 +++ stable/9/share/man/man5/make.conf.5	Mon Jan  2 22:11:08 2012	(r229320)
 @@ -24,7 +24,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd June 16, 2011
 +.Dd December 11, 2011
  .Dt MAKE.CONF 5
  .Os
  .Sh NAME
 @@ -333,6 +333,12 @@ to update your
  .Pa src
  tree with
  .Dq Li "make update" .
 +Note that since a subversion client is not included in the base system,
 +you will need to set
 +.Va SVN
 +to the full path of a
 +.Xr svn 1
 +binary.
  .It Va WWWSUPFILE
  .Pq Vt str
  The www
 @@ -494,7 +500,7 @@ rather than load the server's kernel.
  .Pq Vt bool
  Defining this and recompiling
  .Pa /usr/src/sys/boot/i386
 -will add 
 +will add
  .Xr dcons 4
  console driver to
  .Xr loader 8
 @@ -634,7 +640,7 @@ The default value is 0640.
  .Pq Vt str
  Additional maps to rebuild when using
  .Pa /etc/mail/Makefile .
 -The 
 +The
  .Pa access ,
  .Pa bitdomain ,
  .Pa domaintable ,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gjb 
State-Changed-When: Mon Jan 2 22:27:12 UTC 2012 
State-Changed-Why:  
MFC'd to stable/9.  Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=163162 
>Unformatted:
