From nobody@FreeBSD.org  Fri Nov 25 00:16:03 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 55B70106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Nov 2011 00:16:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 2C6388FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Nov 2011 00:16:03 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pAP0G2H0017807
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Nov 2011 00:16:02 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pAP0G2kX017806;
	Fri, 25 Nov 2011 00:16:02 GMT
	(envelope-from nobody)
Message-Id: <201111250016.pAP0G2kX017806@red.freebsd.org>
Date: Fri, 25 Nov 2011 00:16:02 GMT
From: pirat sriyotha <jotawski@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: DESTDIR environment variable setting is not correct for apache22
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162862
>Category:       docs
>Synopsis:       DESTDIR environment variable setting is not correct for apache22
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    manolis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 25 00:20:07 UTC 2011
>Closed-Date:    Sun Nov 27 16:48:23 UTC 2011
>Last-Modified:  Sun Nov 27 16:48:23 UTC 2011
>Originator:     pirat sriyotha
>Release:        FreeBSD dell.jes.or.th 8.2-RELEASE-p0 FreeBSD 8.2-RELEASE-p0 #1: Sun May 29 15:21:52 ICT 2011     root@jotawski.tint.or.th:/usr/obj/usr/src/sys/JOTAWSKI  amd64
>Organization:
-
>Environment:
FreeBSD dell.jes.or.th 8.2-RELEASE-p0 FreeBSD 8.2-RELEASE-p0 #1: Sun May 29 15:21:52 ICT 2011     root@jotawski.tint.or.th:/usr/obj/usr/src/sys/JOTAWSKI  amd64

>Description:
in chapter 8 of FDP primer section 8.3 bullet 2 wrote that DESTDIR environment variable must be given in order to install into local servers and the value is /usr/local/www

Nowaday, for apache2 web server, this value is quite far from real situation.  The most appropriate value for apache2 should be /usr/local/www/apache22 as in

# env DESTDIR=/usr/local/www/apache22 make install


>How-To-Repeat:
open your web browser and point to http://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/the-website-install.html

>Fix:
change command line from

# env DESTDIR=/usr/local/www make install

to

# env DESTDIR=/usr/local/www/apache22 make install

a patch for chapter.sgml at books/fdp-primer/the-website is attached

Patch attached with submission follows:

Index: chapter.sgml
===================================================================
RCS file: /home/motorc/Repository-motorc/doc/en_US.ISO8859-1/books/fdp-primer/the-website/chapter.sgml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- chapter.sgml	15 Nov 2011 07:30:08 -0000	1.1
+++ chapter.sgml	24 Nov 2011 23:57:34 -0000	1.2
@@ -289,7 +289,7 @@
 	  setting the <makevar>DESTDIR</makevar> variable to the name of the
 	  directory you want to install the files to.</para>
 
-	<screen>&prompt.root; <userinput><command>env</command> <makevar>DESTDIR</makevar>=<replaceable>/usr/local/www</replaceable> <command>make</command> <maketarget>install</maketarget></userinput></screen>
+	<screen>&prompt.root; <userinput><command>env</command> <makevar>DESTDIR</makevar>=<replaceable>/usr/local/www/apache22</replaceable> <command>make</command> <maketarget>install</maketarget></userinput></screen>
       </step>
 
       <step>


>Release-Note:
>Audit-Trail:

From: Manolis Kiagias <sonic2000gr@gmail.com>
To: pirat sriyotha <jotawski@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: docs/162862: DESTDIR environment variable setting is not correct
 for apache22
Date: Fri, 25 Nov 2011 17:25:32 +0200

 Hi,
 
 The example is not specific to apache22 or in fact any specific web 
 server. You don't have to use apache to serve FreeBSD web pages. The 
 /usr/local/www is used as a common preference (or hint) as /usr is the 
 largest partition on most FreeBSD systems following the default 
 installation scheme. You are supposed to know how to install / configure 
 a web server and adapt these instructions to your specific installation.
 IMHO, if we add apache specific information to this section we will also 
 have to add more sections describing  basic configuration for serving 
 the pages (like setting DocumentRoot, encoding etc.). I believe these 
 are out of scope for this document.
 
 Best,
 Manolis

From: Manolis Kiagias <sonic2000gr@gmail.com>
To: Mniyardfa Jotawski <jotawski@gmail.com>
Cc: freebsd-doc@freebsd.org, bug-followup@FreeBSD.org
Subject: Re: docs/162862: DESTDIR environment variable setting is not correct
 for apache22
Date: Sun, 27 Nov 2011 08:09:59 +0200

 This is a multi-part message in MIME format.
 --------------060207050906090607080501
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 8bit
 
 On 27/11/2011 5:33 πμ, Mniyardfa Jotawski wrote:
 >
 >
 > On Sat, Nov 26, 2011 at 6:09 PM, Manolis Kiagias 
 > <sonic2000gr@gmail.com <mailto:sonic2000gr@gmail.com>> wrote:
 >
 >     On 26/11/2011 1:07 πμ, Mniyardfa Jotawski wrote:
 >>     2011/11/25 Manolis Kiagias <sonic2000gr@gmail.com
 >>     <mailto:sonic2000gr@gmail.com>>
 >>
 >>         Hi,
 >>
 >>
 >>     Hi,
 >>
 >>         The example is not specific to apache22 or in fact any
 >>         specific web server. You don't have to use apache to serve
 >>         FreeBSD web pages. The /usr/local/www is used as a common
 >>         preference (or hint) as /usr is the largest partition on most
 >>         FreeBSD systems following the default installation scheme.
 >>         You are supposed to know how to install / configure a web
 >>         server and adapt these instructions to your specific
 >>         installation.
 >>         IMHO, if we add apache specific information to this section
 >>         we will also have to add more sections describing  basic
 >>         configuration for serving the pages (like setting
 >>         DocumentRoot, encoding etc.). I believe these are out of
 >>         scope for this document.
 >>
 >>
 >>     I did agree with your opinion but since I specifically aimed to
 >>     apache2, as I wrote in my Problem Description: , that requires
 >>     that documents to serve should be in (or under) DocumentRoot
 >>     which is /usr/local/www/apache22.  But once I follow suggestion
 >>     in FDP Primer chapter 8.3, that installs all documents to
 >>     /usr/local/www/data.  In this case, I have to create apache22
 >>     subdirectory under what DESTDIR environment variable points to
 >>     and mv all data/ into that in order for my apache2 to start quietly.
 >
 >     What you would really need to do is change the DESTDIR shown in
 >     the example to:
 >
 >     env DESTDIR=/usr/local/www/apache22 make install
 >
 >     As I said, the example is not to be taken literally.  DESTDIR
 >     should be set to your own DocumentRoot (or whatever is called by
 >     the web server used) and not copied directly from fdp-primer.
 >
 >
 >>
 >>     Anyway, I also see that there will be an endless Notes to mention
 >>     to the readers if we wrote to a  specific web-server like apache
 >>     as you said me.
 >>
 >>     May be that we put a few words to mention further  works after
 >>     ``make all install''  for some specific server or all documents
 >>     will have to be installed to ~/public_html/data otherwise.
 >>
 >
 >     Not necessary if DESTDIR is set correctly beforehand
 >
 >
 >>     Many thanks indeed for your time.
 >>
 >>     Apologized me for disturbing and apologized me for my English too.
 >>
 >>
 >>
 >
 >     You are not disturbing, you are trying to make FreeBSD better! Thanks!
 >
 >
 > Hi,
 >
 > All in all, I do agree with you but I found that the whole documents 
 > will be placed under ~/public_html/data if  DESTDIR were not passed to 
 > make command line.  Even one passed some value for DESTDIR to make 
 > command line, the whole documents still be placed under 
 > ${DESTDIR}/data regardless of any web servers used.
 >
 >
 > Should a few words mention this to the readers ?
 >
 > Really apologized me indeed.  This is my limitation, my English.
 >
 > With Best Regards,
 > psr
 >
 >
 
 Ah, I see your point now.  It's true, the actual install directory is 
 $DESTDIR/data. I'll make sure this gets mentioned in the fdp-primer.
 
 Best,
 Manolis
 
 --------------060207050906090607080501
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: 8bit
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
   <head>
     <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
   </head>
   <body text="#000000" bgcolor="#ffffff">
     On 27/11/2011 5:33 πμ, Mniyardfa Jotawski wrote:
     <blockquote
 cite="mid:CAPME81g-QdGbe3NpOW+aS=gLG-_TLHfwjJ4Raz_MvbzFrkhzEg@mail.gmail.com"
       type="cite"><br>
       <br>
       <div class="gmail_quote">On Sat, Nov 26, 2011 at 6:09 PM, Manolis
         Kiagias <span dir="ltr">&lt;<a moz-do-not-send="true"
             href="mailto:sonic2000gr@gmail.com">sonic2000gr@gmail.com</a>&gt;</span>
         wrote:<br>
         <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
           0.8ex; border-left: 1px solid rgb(204, 204, 204);
           padding-left: 1ex;">
           <div text="#000000" bgcolor="#ffffff">
             <div class="im"> On 26/11/2011 1:07 πμ, Mniyardfa Jotawski
               wrote:
               <blockquote type="cite">2011/11/25 Manolis Kiagias <span
                   dir="ltr">&lt;<a moz-do-not-send="true"
                     href="mailto:sonic2000gr@gmail.com" target="_blank">sonic2000gr@gmail.com</a>&gt;</span><br>
                 <div class="gmail_quote">
                   <blockquote class="gmail_quote" style="margin: 0pt 0pt
                     0pt 0.8ex; border-left: 1px solid rgb(204, 204,
                     204); padding-left: 1ex;"> Hi,<br>
                     <br>
                   </blockquote>
                   <div><br>
                     Hi,<br>
                     <br>
                      </div>
                   <blockquote class="gmail_quote" style="margin: 0pt 0pt
                     0pt 0.8ex; border-left: 1px solid rgb(204, 204,
                     204); padding-left: 1ex;"> The example is not
                     specific to apache22 or in fact any specific web
                     server. You don't have to use apache to serve
                     FreeBSD web pages. The /usr/local/www is used as a
                     common preference (or hint) as /usr is the largest
                     partition on most FreeBSD systems following the
                     default installation scheme. You are supposed to
                     know how to install / configure a web server and
                     adapt these instructions to your specific
                     installation.<br>
                     IMHO, if we add apache specific information to this
                     section we will also have to add more sections
                     describing  basic configuration for serving the
                     pages (like setting DocumentRoot, encoding etc.). I
                     believe these are out of scope for this document.<br>
                     <br>
                   </blockquote>
                   <div><br>
                     I did agree with your opinion but since I
                     specifically aimed to apache2, as I wrote in my
                     Problem Description: , that requires that documents
                     to serve should be in (or under) DocumentRoot which
                     is /usr/local/www/apache22.  But once I follow
                     suggestion in FDP Primer chapter 8.3, that installs
                     all documents to /usr/local/www/data.  In this case,
                     I have to create apache22 subdirectory under what
                     DESTDIR environment variable points to and mv all
                     data/ into that in order for my apache2 to start
                     quietly.<br>
                   </div>
                 </div>
               </blockquote>
               <br>
             </div>
             What you would really need to do is change the DESTDIR shown
             in the example to:<br>
             <br>
             env DESTDIR=/usr/local/www/apache22 make install<br>
             <br>
             As I said, the example is not to be taken literally. 
             DESTDIR should be set to your own DocumentRoot (or whatever
             is called by the web server used) and not copied directly
             from fdp-primer.
             <div class="im"><br>
               <br>
               <blockquote type="cite">
                 <div class="gmail_quote">
                   <div> <br>
                     Anyway, I also see that there will be an endless
                     Notes to mention to the readers if we wrote to a 
                     specific web-server like apache as you said me.<br>
                     <br>
                     May be that we put a few words to mention further 
                     works after ``make all install''  for some specific
                     server or all documents will have to be installed to
                     ~/public_html/data otherwise.<br>
                     <br>
                   </div>
                 </div>
               </blockquote>
               <br>
             </div>
             Not necessary if DESTDIR is set correctly beforehand
             <div class="im"><br>
               <br>
               <blockquote type="cite">
                 <div class="gmail_quote">
                   <div>Many thanks indeed for your time.<br>
                     <br>
                     Apologized me for disturbing and apologized me for
                     my English too.<br>
                     <br>
                     <br>
                   </div>
                   <br>
                 </div>
               </blockquote>
               <br>
             </div>
             You are not disturbing, you are trying to make FreeBSD
             better! Thanks!<br>
           </div>
         </blockquote>
       </div>
       <br>
       Hi,<br>
       <br>
       All in all, I do agree with you but I found that the whole
       documents will be placed under ~/public_html/data if  DESTDIR were
       not passed to make command line.  Even one passed some value for
       DESTDIR to make command line, the whole documents still be placed
       under ${DESTDIR}/data regardless of any web servers used.<br>
       <br>
       <br>
       Should a few words mention this to the readers ?<br>
       <br>
       Really apologized me indeed.  This is my limitation, my English.<br>
       <br clear="all">
       With Best Regards,<br>
       psr<br>
       <br>
       <br>
     </blockquote>
     <br>
     Ah, I see your point now.  It's true, the actual install directory
     is $DESTDIR/data. I'll make sure this gets mentioned in the
     fdp-primer.<br>
     <br>
     Best,<br>
     Manolis<br>
   </body>
 </html>
 
 --------------060207050906090607080501--
Responsible-Changed-From-To: freebsd-doc->manolis 
Responsible-Changed-By: manolis 
Responsible-Changed-When: Sun Nov 27 06:24:14 UTC 2011 
Responsible-Changed-Why:  
Over to me 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162862 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/162862: commit references a PR
Date: Sun, 27 Nov 2011 16:37:39 +0000 (UTC)

 manolis     2011-11-27 16:37:30 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/fdp-primer/the-website chapter.sgml 
   Log:
   Note that files from the FreeBSD website build process are actually installed under $DESTDIR/data
   
   PR:             docs/162862
   Submitted by:   Pirat Sriyotha <jotawski at gmail dot com>
   
   Revision  Changes    Path
   1.28      +4 -1      doc/en_US.ISO8859-1/books/fdp-primer/the-website/chapter.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: manolis 
State-Changed-When: Sun Nov 27 16:47:37 UTC 2011 
State-Changed-Why:  
A suitable note has been added, thanks for submitting this! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162862 
>Unformatted:
