From nobody@FreeBSD.org  Sat Nov 12 17:42:24 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD945106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Nov 2011 17:42:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id BDF0C8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Nov 2011 17:42:24 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pACHgOCu006577
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Nov 2011 17:42:24 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pACHgOUo006576;
	Sat, 12 Nov 2011 17:42:24 GMT
	(envelope-from nobody)
Message-Id: <201111121742.pACHgOUo006576@red.freebsd.org>
Date: Sat, 12 Nov 2011 17:42:24 GMT
From: Chris Rees <utisoft@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Committer's guide should probably mention mentor approval for first steps
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162504
>Category:       docs
>Synopsis:       Committer's guide should probably mention mentor approval for first steps
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 12 17:50:08 UTC 2011
>Closed-Date:    Sat Nov 12 17:57:29 UTC 2011
>Last-Modified:  Sat Nov 12 18:00:32 UTC 2011
>Originator:     Chris Rees
>Release:        
>Organization:
>Environment:
>Description:
Unless a new mentor explicitly requests review of the very first traditional patches [1], the mentee may not realise that they require approval!

[1] http://www.freebsd.org/doc/en/articles/committers-guide/conventions.html
>How-To-Repeat:

>Fix:
http://www.bayofrum.net/~crees/patches/committers-guide-mentor-approval.patch.txt

Rendered: http://www.bayofrum.net/~crees/patches/committers-guide-mentor-approval.html

[if you don't want the hassle of committing this, I'll take a bounce to me as approval]

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Sat Nov 12 17:57:28 UTC 2011 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162504 
Responsible-Changed-From-To: freebsd-doc->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Sat Nov 12 17:58:05 UTC 2011 
Responsible-Changed-Why:  
I closed it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162504 

From: Glen Barber <gjb@FreeBSD.org>
To: Chris Rees <utisoft@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: docs/162504: Committer's guide should probably mention mentor
 approval for first steps
Date: Sat, 12 Nov 2011 12:57:13 -0500

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enigE60613BB6D06C91EABF62192
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 On 11/12/11 12:42 PM, Chris Rees wrote:
 > Rendered: http://www.bayofrum.net/~crees/patches/committers-guide-mento=
 r-approval.html
 >=20
 > [if you don't want the hassle of committing this, I'll take a bounce to=
  me as approval]
 >=20
 
 Hi Chris,
 
 Good idea explicitly mentioning this.  Please commit it.
 
 Thanks.
 
 --=20
 Glen Barber | gjb@FreeBSD.org
 FreeBSD Documentation Project
 
 
 --------------enigE60613BB6D06C91EABF62192
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.11 (Darwin)
 
 iQEcBAEBCAAGBQJOvrOBAAoJEFJPDDeguUajmsMH/0BolzSJvY1zEZa8n1b55SGc
 5hAY/a5ul8UAV30c1gdEBj8YnG3qmDLFaiWUfxUWyaPGGehtf0WpLGKaQoZ+3kI4
 hWQttPYLni34cglfn460aTclrwJ1hi/sn15gPkNkGpwvzJ5afELMmbyLynmTiN4K
 B07k/W1/QjzPlTCPOZo630KgH+yxRx14OQYn4zg0uRBRPKQGyPM1oIBAbN5kawH0
 VllYZPjA3BvjlS/qp5m56+zkSbALCwu0EOlhUs+TyqAUrJ99b+PDYYmQHnffCuEc
 EyEgIfFGGs1TAETnGrzCU90Ul5/JnqSfgP+8uPvEjX9R8x8b/Pt74OnhGJIZRk0=
 =BVbK
 -----END PGP SIGNATURE-----
 
 --------------enigE60613BB6D06C91EABF62192--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/162504: commit references a PR
Date: Sat, 12 Nov 2011 17:57:23 +0000 (UTC)

 crees       2011-11-12 17:57:14 UTC
 
   FreeBSD doc repository (ports committer)
 
   Modified files:
     en_US.ISO8859-1/articles/committers-guide article.sgml 
   Log:
   Note that mentor approval is required for all patches, however trivial
   
   PR:             docs/162504
   Approved by:    gjb
   
   Revision  Changes    Path
   1.306     +5 -0      doc/en_US.ISO8859-1/articles/committers-guide/article.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
