From nobody@FreeBSD.org  Thu Nov  3 05:41:26 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C41E31065673
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Nov 2011 05:41:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B47668FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  3 Nov 2011 05:41:26 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pA35fQ4u027720
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 3 Nov 2011 05:41:26 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pA35fQSL027719;
	Thu, 3 Nov 2011 05:41:26 GMT
	(envelope-from nobody)
Message-Id: <201111030541.pA35fQSL027719@red.freebsd.org>
Date: Thu, 3 Nov 2011 05:41:26 GMT
From: Paul Procacci <pprocacci@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [Patch] [ipfw.8] Documentation clarity
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162265
>Category:       docs
>Synopsis:       [Patch] ipfw.8: Documentation clarity
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 03 05:50:07 UTC 2011
>Closed-Date:    Sun Mar 04 07:29:51 UTC 2012
>Last-Modified:  Sun Mar  4 07:30:08 UTC 2012
>Originator:     Paul Procacci
>Release:        8.x both release and stable
>Organization:
>Environment:
FreeBSD nat.myhome 8.1-RELEASE-p2 FreeBSD 8.1-RELEASE-p2 #3: Wed Mar  9 22:21:01 CST 2011     root@nat.myhome:/usr/obj/usr/src/sys/FIREWALL  i386

>Description:
Up until today I didn't realize the one could use tablearg to a nat action in a ipfw rule.  Someone was kind enough to slap me.  ;P

What I propose is a very simple and small patch which would clarify it for retards like myself.  ;P
>How-To-Repeat:
man ipfw
>Fix:
See attached patch.

Patch attached with submission follows:

--- sbin/ipfw/ipfw.8.orig       2011-11-03 00:31:29.000000000 -0500
+++ sbin/ipfw/ipfw.8    2011-11-03 00:35:47.000000000 -0500
@@ -765,7 +765,7 @@
 .Cm fwd
 a custom kernel needs to be compiled with the option
 .Cd "options IPFIREWALL_FORWARD" .
-.It Cm nat Ar nat_nr
+.It Cm nat Ar nat_nr | tablearg
 Pass packet to a
 nat instance
 (for network address translation, address redirect, etc.):


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-doc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Nov 3 11:51:07 UTC 2011 
Responsible-Changed-Why:  
reclassify. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162265 
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Thu Nov 10 12:05:47 UTC 2011 
State-Changed-Why:  
Patched in head/. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162265 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/162265: commit references a PR
Date: Thu, 10 Nov 2011 12:05:36 +0000 (UTC)

 Author: glebius
 Date: Thu Nov 10 12:05:26 2011
 New Revision: 227419
 URL: http://svn.freebsd.org/changeset/base/227419
 
 Log:
   Note that NAT instance argument can be tablearg.
   
   PR:		misc/162265
   Submitted by:	Paul Procacci <pprocacci gmail.com>
 
 Modified:
   head/sbin/ipfw/ipfw.8
 
 Modified: head/sbin/ipfw/ipfw.8
 ==============================================================================
 --- head/sbin/ipfw/ipfw.8	Thu Nov 10 11:17:40 2011	(r227418)
 +++ head/sbin/ipfw/ipfw.8	Thu Nov 10 12:05:26 2011	(r227419)
 @@ -1,7 +1,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd August 20, 2011
 +.Dd November 10, 2011
  .Dt IPFW 8
  .Os
  .Sh NAME
 @@ -769,7 +769,7 @@ To enable
  .Cm fwd
  a custom kernel needs to be compiled with the option
  .Cd "options IPFIREWALL_FORWARD" .
 -.It Cm nat Ar nat_nr
 +.It Cm nat Ar nat_nr | tablearg
  Pass packet to a
  nat instance
  (for network address translation, address redirect, etc.):
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: freebsd-doc->glebius 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Mar 4 04:32:24 UTC 2012 
Responsible-Changed-Why:  
you committed it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162265 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Sun Mar 4 07:24:55 UTC 2012 
State-Changed-Why:  
Merged to stable/9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162265 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/162265: commit references a PR
Date: Sun,  4 Mar 2012 07:29:46 +0000 (UTC)

 Author: glebius
 Date: Sun Mar  4 07:29:35 2012
 New Revision: 232481
 URL: http://svn.freebsd.org/changeset/base/232481
 
 Log:
   Merge r227419:
     Note that NAT instance argument can be tablearg.
   
     PR:		misc/162265
     Submitted by:	Paul Procacci <pprocacci gmail.com>
 
 Modified:
   stable/9/sbin/ipfw/ipfw.8
 Directory Properties:
   stable/9/sbin/ipfw/   (props changed)
 
 Modified: stable/9/sbin/ipfw/ipfw.8
 ==============================================================================
 --- stable/9/sbin/ipfw/ipfw.8	Sun Mar  4 05:52:26 2012	(r232480)
 +++ stable/9/sbin/ipfw/ipfw.8	Sun Mar  4 07:29:35 2012	(r232481)
 @@ -1,7 +1,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd August 20, 2011
 +.Dd November 10, 2011
  .Dt IPFW 8
  .Os
  .Sh NAME
 @@ -769,7 +769,7 @@ To enable
  .Cm fwd
  a custom kernel needs to be compiled with the option
  .Cd "options IPFIREWALL_FORWARD" .
 -.It Cm nat Ar nat_nr
 +.It Cm nat Ar nat_nr | tablearg
  Pass packet to a
  nat instance
  (for network address translation, address redirect, etc.):
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
