From nobody@FreeBSD.org  Thu Sep  1 16:31:15 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6B57106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  1 Sep 2011 16:31:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A74778FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  1 Sep 2011 16:31:15 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p81GVFdb095646
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 1 Sep 2011 16:31:15 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p81GVFj6095645;
	Thu, 1 Sep 2011 16:31:15 GMT
	(envelope-from nobody)
Message-Id: <201109011631.p81GVFj6095645@red.freebsd.org>
Date: Thu, 1 Sep 2011 16:31:15 GMT
From: Eitan Adler <eadler@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] update sample simple makefile with new conventions
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160369
>Category:       docs
>Synopsis:       [patch] update sample simple makefile with new conventions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gjb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 01 16:40:07 UTC 2011
>Closed-Date:    Fri Aug 31 13:01:47 UTC 2012
>Last-Modified:  Fri Aug 31 13:10:10 UTC 2012
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
I was told by sahil@ and bapt@ that we will now be ISO 8601:2004 form for new ports. 
Additionally, add a license to the sample makefile.
>How-To-Repeat:

>Fix:
Index: book.sgml
===================================================================
RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
retrieving revision 1.1115
diff -u -r1.1115 book.sgml
--- book.sgml	15 Aug 2011 06:06:40 -0000	1.1115
+++ book.sgml	1 Sep 2011 16:28:39 -0000
@@ -120,7 +120,7 @@
 	  like this:</para>
 
 	<programlisting># New ports collection makefile for:   oneko
-# Date created:        5 December 1994
+# Date created:        1994-12-5
 # Whom:                asami
 #
 # &dollar;FreeBSD&dollar;
@@ -134,6 +134,8 @@
 MAINTAINER=    asami@FreeBSD.org
 COMMENT=       A cat chasing a mouse all over the screen
 
+LICENSE=       MIT
+
 MAN1=          oneko.1
 MANCOMPRESSED= yes
 USE_IMAKE=     yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->gjb 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Sep 1 16:46:09 UTC 2011 
Responsible-Changed-Why:  
You know you want it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160369 

From: Sahil Tandon <sahil@FreeBSD.org>
To: Eitan Adler <eadler@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: docs/160369: [patch] update sample simple makefile with new
 conventions
Date: Thu, 1 Sep 2011 16:20:45 -0400

 On Thu, 2011-09-01 at 16:31:15 +0000, Eitan Adler wrote:
 
 > >Description:
 > I was told by sahil@ and bapt@ that we will now be ISO 8601:2004 form
 > for new ports.  Additionally, add a license to the sample makefile.
 
 I do not know if this is being officially adopted by the powers that be,
 but it sure would be nice.  I recall this practice being passed down to
 me by itetcu@ when he was my mentor.
 
 > -# Date created:        5 December 1994
 > +# Date created:        1994-12-5
 
 Hmm, that's wrong; it should be 1994-12-05.
 
 -- 
 Sahil Tandon <sahil@FreeBSD.org>

From: Eitan Adler <eadler@freebsd.org>
To: Sahil Tandon <sahil@freebsd.org>
Cc: bug-followup@freebsd.org, Glen Barber <gjb@freebsd.org>
Subject: Re: docs/160369: [patch] update sample simple makefile with new conventions
Date: Thu, 1 Sep 2011 18:01:25 -0400

 >> -# Date created: =C2=A0 =C2=A0 =C2=A0 =C2=A05 December 1994
 >> +# Date created: =C2=A0 =C2=A0 =C2=A0 =C2=A01994-12-5
 >
 > Hmm, that's wrong; it should be 1994-12-05.
 
 Darnit. I thought I typed that.
 Here is the corrected patch
 
 Index: book.sgml
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v
 retrieving revision 1.1115
 diff -u -r1.1115 book.sgml
 --- book.sgml	15 Aug 2011 06:06:40 -0000	1.1115
 +++ book.sgml	1 Sep 2011 22:00:25 -0000
 @@ -120,7 +120,7 @@
  	  like this:</para>
 
  	<programlisting># New ports collection makefile for:   oneko
 -# Date created:        5 December 1994
 +# Date created:        1994-12-05
  # Whom:                asami
  #
  # &dollar;FreeBSD&dollar;
 @@ -134,6 +134,8 @@
  MAINTAINER=3D    asami@FreeBSD.org
  COMMENT=3D       A cat chasing a mouse all over the screen
 
 +LICENSE=3D       MIT
 +
  MAN1=3D          oneko.1
  MANCOMPRESSED=3D yes
  USE_IMAKE=3D     yes
 
 
 >
 > --
 > Sahil Tandon <sahil@FreeBSD.org>
 >
 
 
 
 --=20
 Eitan Adler
 Ports committer
 Bugbusting team

From: Glen Barber <gjb@FreeBSD.org>
To: Sahil Tandon <sahil@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: docs/160369: [patch] update sample simple makefile with new conventions
Date: Thu, 01 Sep 2011 20:36:02 -0400

 On 9/1/11 4:30 PM, Sahil Tandon wrote:
 >  > >Description:
 >  > I was told by sahil@ and bapt@ that we will now be ISO 8601:2004 form
 >  > for new ports.  Additionally, add a license to the sample makefile.
 >  
 >  I do not know if this is being officially adopted by the powers that be,
 >  but it sure would be nice.  I recall this practice being passed down to
 >  me by itetcu@ when he was my mentor.
 >  
 
 Hi Sahil,
 
 By "powers that be", do you mean portmgr?  If so, I'll ping them before
 making this change to confirm this is the wanted format.
 
 Thanks,
 
 Glen
 
 -- 
 Glen Barber | gjb@FreeBSD.org
 FreeBSD Documentation Project

From: Sahil Tandon <sahil@FreeBSD.org>
To: Glen Barber <gjb@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: docs/160369: [patch] update sample simple makefile with new conventions
Date: Thu, 01 Sep 2011 21:51:18 -0400

 Glen Barber wrote:
 > On 9/1/11 4:30 PM, Sahil Tandon wrote:
 >>   >  >Description:
 >>   >  I was told by sahil@ and bapt@ that we will now be ISO 8601:2004 form
 >>   >  for new ports.  Additionally, add a license to the sample makefile.
 >>
 >>   I do not know if this is being officially adopted by the powers that be,
 >>   but it sure would be nice.  I recall this practice being passed down to
 >>   me by itetcu@ when he was my mentor.
 >>
 >
 > Hi Sahil,
 >
 > By "powers that be", do you mean portmgr?  If so, I'll ping them before
 > making this change to confirm this is the wanted format.
 
 Yes, I am referring to portmgr.  Because itetcu@ was on portmgr, I know 
 *some* of them will be receptive to making this change more prominent 
 throughout the documentation, so it makes sense to ping them before 
 committing this change.
 
 -- 
 Sahil Tandon <sahil@FreeBSD.org>
 
State-Changed-From-To: open->suspended 
State-Changed-By: gjb 
State-Changed-When: Fri Sep 2 23:47:56 UTC 2011 
State-Changed-Why:  
Feedback from portmgr suggests a different solution - excluding 
the non-rcsid comment lines moving forward. 

Suspend this PR for now until the relevant sanity-checking tools 
have been updated accordingly, after which, the Porter's Handbook 
should be updated to note these lines are not necessary. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=160369 

From: Eitan Adler <eadler@freebsd.org>
To: gjb@freebsd.org, bug-followup@freebsd.org
Cc:  
Subject: Re: docs/160369: [patch] update sample simple makefile with new conventions
Date: Fri, 2 Sep 2011 20:02:11 -0400

 This is what I prefer. Original patch came from feedback from sahil@ and bapt@.
 I'm glad portmgr went this route.
 
 On Fri, Sep 2, 2011 at 7:51 PM,  <gjb@freebsd.org> wrote:
 > Synopsis: [patch] update sample simple makefile with new conventions
 >
 > State-Changed-From-To: open->suspended
 > State-Changed-By: gjb
 > State-Changed-When: Fri Sep 2 23:47:56 UTC 2011
 > State-Changed-Why:
 > Feedback from portmgr suggests a different solution - excluding
 > the non-rcsid comment lines moving forward.
 >
 > Suspend this PR for now until the relevant sanity-checking tools
 > have been updated accordingly, after which, the Porter's Handbook
 > should be updated to note these lines are not necessary.
 >
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=160369
 >
 
 
 
 -- 
 Eitan Adler
 Ports committer
 Bugbusting team

From: Beat Gaetzi <beat@FreeBSD.org>
To: bug-followup@FreeBSD.org, eadler@FreeBSD.org, gjb@FreeBSD.org
Cc:  
Subject: Re: docs/160369: [patch] update sample simple makefile with new conventions
Date: Fri, 31 Aug 2012 12:45:55 +0200

 This is a multi-part message in MIME format.
 --------------000601030401040907020406
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 Hi,
 
 Attached a new patch which updates the header to the new format.
 
 Beat
 
 --------------000601030401040907020406
 Content-Type: text/plain; charset=us-ascii;
  name="porters-handbook-header.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="porters-handbook-header.patch"
 
 Index: en_US.ISO8859-1/books/porters-handbook/book.sgml
 ===================================================================
 --- en_US.ISO8859-1/books/porters-handbook/book.sgml	(Revision 39477)
 +++ en_US.ISO8859-1/books/porters-handbook/book.sgml	(Arbeitskopie)
 @@ -120,12 +120,7 @@
        <para>The minimal <filename>Makefile</filename> would look
  	something like this:</para>
  
 -      <programlisting># New ports collection makefile for:	oneko
 -# Date created:        5 December 1994
 -# Whom:                asami
 -#
 -# &dollar;FreeBSD&dollar;
 -#
 +      <programlisting># &dollar;FreeBSD&dollar;
  
  PORTNAME=	oneko
  PORTVERSION=	1.1b
 @@ -16289,20 +16284,10 @@
        <filename>Makefile</filename>.</para>
  
      <programlisting>[the header...just to make it easier for us to identify the ports.]
 -# New ports collection makefile for:   xdvi
 -[the "version required" line is only needed when the PORTVERSION
 - variable is not specific enough to describe the port.]
 -# Date created:                26 May 1995
 -[this is the person who did the original port to FreeBSD, in particular, the
 -person who wrote the first version of this Makefile.  Remember, this should
 -not be changed when upgrading the port later.]
 -# Whom:                        Satoshi Asami &lt;asami@FreeBSD.org&gt;
 -#
  # &dollar;FreeBSD&dollar;
  [ ^^^^^^^^^ This will be automatically replaced with RCS ID string by SVN
  when it is committed to our repository.  If upgrading a port, do not alter
  this line back to "&dollar;FreeBSD&dollar;".  SVN deals with it automatically.]
 -#
  
  [section to describe the port itself and the master site - PORTNAME
   and PORTVERSION are always first, followed by CATEGORIES,
 
 --------------000601030401040907020406--
State-Changed-From-To: suspended->closed 
State-Changed-By: gjb 
State-Changed-When: Fri Aug 31 13:01:24 UTC 2012 
State-Changed-Why:  
Committed, thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=160369 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/160369: commit references a PR
Date: Fri, 31 Aug 2012 13:00:55 +0000 (UTC)

 Author: gjb
 Date: Fri Aug 31 13:00:39 2012
 New Revision: 39479
 URL: http://svn.freebsd.org/changeset/doc/39479
 
 Log:
   Remove the port creation meta-lines from the Porters Handbook.
   
   PR:		160369
   Submitted by:	eadler (original)
   Patched by:	portmgr (beat)
 
 Modified:
   head/en_US.ISO8859-1/books/porters-handbook/book.sgml
 
 Modified: head/en_US.ISO8859-1/books/porters-handbook/book.sgml
 ==============================================================================
 --- head/en_US.ISO8859-1/books/porters-handbook/book.sgml	Fri Aug 31 12:19:04 2012	(r39478)
 +++ head/en_US.ISO8859-1/books/porters-handbook/book.sgml	Fri Aug 31 13:00:39 2012	(r39479)
 @@ -120,12 +120,7 @@
        <para>The minimal <filename>Makefile</filename> would look
  	something like this:</para>
  
 -      <programlisting># New ports collection makefile for:	oneko
 -# Date created:        5 December 1994
 -# Whom:                asami
 -#
 -# &dollar;FreeBSD&dollar;
 -#
 +      <programlisting># &dollar;FreeBSD&dollar;
  
  PORTNAME=	oneko
  PORTVERSION=	1.1b
 @@ -16289,20 +16284,10 @@ IGNORE=	POINTYHAT is not supported
        <filename>Makefile</filename>.</para>
  
      <programlisting>[the header...just to make it easier for us to identify the ports.]
 -# New ports collection makefile for:   xdvi
 -[the "version required" line is only needed when the PORTVERSION
 - variable is not specific enough to describe the port.]
 -# Date created:                26 May 1995
 -[this is the person who did the original port to FreeBSD, in particular, the
 -person who wrote the first version of this Makefile.  Remember, this should
 -not be changed when upgrading the port later.]
 -# Whom:                        Satoshi Asami &lt;asami@FreeBSD.org&gt;
 -#
  # &dollar;FreeBSD&dollar;
  [ ^^^^^^^^^ This will be automatically replaced with RCS ID string by SVN
  when it is committed to our repository.  If upgrading a port, do not alter
  this line back to "&dollar;FreeBSD&dollar;".  SVN deals with it automatically.]
 -#
  
  [section to describe the port itself and the master site - PORTNAME
   and PORTVERSION are always first, followed by CATEGORIES,
 _______________________________________________
 svn-doc-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-doc-all
 To unsubscribe, send any mail to "svn-doc-all-unsubscribe@freebsd.org"
 
>Unformatted:
