From nobody@FreeBSD.org  Tue Jul 19 22:16:00 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 45744106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Jul 2011 22:16:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 351CA8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Jul 2011 22:16:00 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6JMFx13083138
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Jul 2011 22:15:59 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p6JMFx8U083137;
	Tue, 19 Jul 2011 22:15:59 GMT
	(envelope-from nobody)
Message-Id: <201107192215.p6JMFx8U083137@red.freebsd.org>
Date: Tue, 19 Jul 2011 22:15:59 GMT
From: Ben Kaduk <kaduk@mit.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: SRC_BASE is in bsd.port.mk and need not be set in port Makefiles
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         159047
>Category:       docs
>Synopsis:       SRC_BASE is in bsd.port.mk and need not be set in port Makefiles
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    linimon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 19 22:20:11 UTC 2011
>Closed-Date:    Wed Jul 20 04:26:47 UTC 2011
>Last-Modified:  Wed Jul 20 04:30:11 UTC 2011
>Originator:     Ben Kaduk
>Release:        9-current
>Organization:
MIT SIPB
>Environment:
n/a
>Description:
Since r1.662 (Fri Dec 17 03:21:19 2010 UTC (7 months ago) by linimon), SRC_BASE has been defined in bsd.port.mk; individual port Makefiles need not set it themselves.  Update the porter's handbook example for ports that require kernel sources, accordingly.

Prodded-by: zi
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- book.sgml.orig	2011-07-19 18:11:40.000000000 -0400
+++ book.sgml	2011-07-19 18:12:34.000000000 -0400
@@ -8857,9 +8857,7 @@
 	kernel source files so that the port can compile.  Here is the
 	correct way to determine if the user has them installed:</para>
 
-      <programlisting>SRC_BASE?=      /usr/src
-
-.if !exists(${SRC_BASE}/sys/Makefile)
+      <programlisting>.if !exists(${SRC_BASE}/sys/Makefile)
 IGNORE=         requires kernel sources to be installed
 .endif</programlisting>
     </sect1>


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Wed Jul 20 04:26:14 UTC 2011 
State-Changed-Why:  
Good catch.  I should have checked for this when I did the bpm commit. 


Responsible-Changed-From-To: freebsd-doc->linimon 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Jul 20 04:26:14 UTC 2011 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=159047 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/159047: commit references a PR
Date: Wed, 20 Jul 2011 04:26:15 +0000 (UTC)

 linimon     2011-07-20 04:26:06 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/porters-handbook book.sgml 
   Log:
   It is no longer necessary to define SRC_BASE?= in a port Makefile.
   
   PR:             docs/159047
   Submitted by:   Ben Kaduk <kaduk@mit.edu>
   
   Revision  Changes    Path
   1.1113    +1 -3      doc/en_US.ISO8859-1/books/porters-handbook/book.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
