From zeising@daemonic.se  Wed Jun 15 14:14:25 2011
Return-Path: <zeising@daemonic.se>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA316106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jun 2011 14:14:24 +0000 (UTC)
	(envelope-from zeising@daemonic.se)
Received: from mail.lysator.liu.se (unknown [IPv6:2001:6b0:17:f0a0::3])
	by mx1.freebsd.org (Postfix) with ESMTP id 3F8D78FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jun 2011 14:14:22 +0000 (UTC)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
	by mail.lysator.liu.se (Postfix) with ESMTP id 3C34C40014
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jun 2011 16:14:21 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
	id 2F03340016; Wed, 15 Jun 2011 16:14:21 +0200 (CEST)
Received: from mx.daemonic.se (h-90-99.A163.priv.bahnhof.se [79.136.90.99])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.lysator.liu.se (Postfix) with ESMTPSA id D9C0C40014
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jun 2011 16:14:20 +0200 (CEST)
Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2001:470:dca9:0:1::4])
	by mx.daemonic.se (Postfix) with ESMTPS id AF098119C04
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jun 2011 16:14:20 +0200 (CEST)
Received: from vincent.daemonic.se (login.daemonic.se [IPv6:2001:470:dca9:0:1::10])
	by mail.daemonic.se (Postfix) with ESMTPS id 8916D12B0A0
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Jun 2011 16:14:20 +0200 (CEST)
Received: (from zeising@localhost)
	by vincent.daemonic.se (8.14.4/8.14.4/Submit) id p5FEEKSK065106;
	Wed, 15 Jun 2011 16:14:20 +0200 (CEST)
	(envelope-from zeising)
Message-Id: <201106151414.p5FEEKSK065106@vincent.daemonic.se>
Date: Wed, 15 Jun 2011 16:14:20 +0200 (CEST)
From: Niclas Zeising <niclas.zeising@gmail.com>
Reply-To: Niclas Zeising <niclas.zeising@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] grammar and wording fixes to snd_hda.4
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         157901
>Category:       docs
>Synopsis:       [PATCH] grammar and wording fixes to snd_hda.4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bcr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 15 14:20:08 UTC 2011
>Closed-Date:    Sun Jun 19 11:21:03 UTC 2011
>Last-Modified:  Sun Jun 19 11:21:03 UTC 2011
>Originator:     Niclas Zeising
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD vincent.daemonic.se 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Wed Apr 20 17:22:47 CEST 2011 root@vincent.daemonic.se:/usr/obj/usr/src/sys/VINCENT amd64


	
>Description:
	The wording in the BUGS section of snd_hda(4) is a little wierd and not always gramatically correct.
>How-To-Repeat:
	
>Fix:

	Attached patch tries to improve the wording and grammar.

--- snd_hda.4.diff begins here ---
Index: snd_hda.4
===================================================================
--- snd_hda.4	(revision 223108)
+++ snd_hda.4	(working copy)
@@ -668,16 +668,20 @@
 A few Hardware/OEM vendors tend to screw up BIOS settings, thus
 rendering the
 .Nm
-driver useless, which usually results in a state where the
+driver useless.
+This usually results in a state where the
 .Nm
-driver seems to attach and work, but without any sound. Some of
-that cases can be solved by tuning loader.conf variables. But before
-trying to fix problem that way, make sure that problem is really exists
-and the PCM audio device you are using really corresponds to expected
+driver seems to attach and work, but no sound is played.
+Some cases can be solved by tuning
+.Pa loader.conf
+variables.
+Before trying to fix problem that way, make sure that there really is a problem
+and that the PCM audio device in use really corresponds to the expected
 audio connector.
 .Pp
-Some vendors use non-standardized General Purpose I/O (GPIO) pins of codec
-to control external amplifiers. In some cases setting proper combination of
-GPIO bits may be needed to make sound work on specific device.
+Some vendors use non-standardized General Purpose I/O (GPIO) pins of the codec
+to control external amplifiers.
+In some cases setting a combination of GPIO bits may be needed to make
+sound work on a specific device.
 .Pp
 HDMI and DisplayPort audio may also require support from video driver.
--- snd_hda.4.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->bcr 
Responsible-Changed-By: bcr 
Responsible-Changed-When: Wed Jun 15 16:51:26 UTC 2011 
Responsible-Changed-Why:  
Take this PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157901 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/157901: commit references a PR
Date: Thu, 16 Jun 2011 19:57:25 +0000 (UTC)

 Author: bcr (doc committer)
 Date: Thu Jun 16 19:57:07 2011
 New Revision: 223160
 URL: http://svn.freebsd.org/changeset/base/223160
 
 Log:
   Fix some wording and grammar in the BUGS section.
   
   PR:             docs/157901
   Submitted by:   Niclas Zeising (niclas dot zeising at gmail dot com)
   Reviewed by:    mav
   MFC after:      3 days
 
 Modified:
   head/share/man/man4/snd_hda.4
 
 Modified: head/share/man/man4/snd_hda.4
 ==============================================================================
 --- head/share/man/man4/snd_hda.4	Thu Jun 16 19:47:56 2011	(r223159)
 +++ head/share/man/man4/snd_hda.4	Thu Jun 16 19:57:07 2011	(r223160)
 @@ -668,16 +668,20 @@ and
  A few Hardware/OEM vendors tend to screw up BIOS settings, thus
  rendering the
  .Nm
 -driver useless, which usually results in a state where the
 +driver useless.
 +This usually results in a state where the
  .Nm
 -driver seems to attach and work, but without any sound. Some of
 -that cases can be solved by tuning loader.conf variables. But before
 -trying to fix problem that way, make sure that problem is really exists
 -and the PCM audio device you are using really corresponds to expected
 +driver seems to attach and work, but no sound is played.
 +Some cases can be solved by tuning
 +.Pa loader.conf
 +variables.
 +Before trying to fix problem that way, make sure that there really is a problem
 +and that the PCM audio device in use really corresponds to the expected
  audio connector.
  .Pp
 -Some vendors use non-standardized General Purpose I/O (GPIO) pins of codec
 -to control external amplifiers. In some cases setting proper combination of
 -GPIO bits may be needed to make sound work on specific device.
 +Some vendors use non-standardized General Purpose I/O (GPIO) pins of the codec
 +to control external amplifiers.
 +In some cases setting a combination of GPIO bits may be needed to make
 +sound work on a specific device.
  .Pp
  HDMI and DisplayPort audio may also require support from video driver.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: bcr 
State-Changed-When: Thu Jun 16 20:05:27 UTC 2011 
State-Changed-Why:  
Set to state patched until the MFC is through. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157901 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/157901: commit references a PR
Date: Sun, 19 Jun 2011 11:01:53 +0000 (UTC)

 Author: bcr (doc committer)
 Date: Sun Jun 19 11:01:38 2011
 New Revision: 223290
 URL: http://svn.freebsd.org/changeset/base/223290
 
 Log:
   MFC r223160:
   
   Fix some wording and grammar in the BUGS section.
   
   PR:             docs/157901
   Submitted by:   Niclas Zeising (niclas dot zeising at gmail dot com)
   Reviewed by:    mav
 
 Modified:
   stable/8/share/man/man4/snd_hda.4
 Directory Properties:
   stable/8/share/man/man4/   (props changed)
 
 Modified: stable/8/share/man/man4/snd_hda.4
 ==============================================================================
 --- stable/8/share/man/man4/snd_hda.4	Sun Jun 19 08:53:16 2011	(r223289)
 +++ stable/8/share/man/man4/snd_hda.4	Sun Jun 19 11:01:38 2011	(r223290)
 @@ -669,16 +669,20 @@ and
  A few Hardware/OEM vendors tend to screw up BIOS settings, thus
  rendering the
  .Nm
 -driver useless, which usually results in a state where the
 +driver useless.
 +This usually results in a state where the
  .Nm
 -driver seems to attach and work, but without any sound. Some of
 -that cases can be solved by tuning loader.conf variables. But before
 -trying to fix problem that way, make sure that problem is really exists
 -and the PCM audio device you are using really corresponds to expected
 +driver seems to attach and work, but no sound is played.
 +Some cases can be solved by tuning
 +.Pa loader.conf
 +variables.
 +Before trying to fix problem that way, make sure that there really is a problem
 +and that the PCM audio device in use really corresponds to the expected
  audio connector.
  .Pp
 -Some vendors use non-standardized General Purpose I/O (GPIO) pins of codec
 -to control external amplifiers. In some cases setting proper combination of
 -GPIO bits may be needed to make sound work on specific device.
 +Some vendors use non-standardized General Purpose I/O (GPIO) pins of the codec
 +to control external amplifiers.
 +In some cases setting a combination of GPIO bits may be needed to make
 +sound work on a specific device.
  .Pp
  HDMI and DisplayPort audio may also require support from video driver.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/157901: commit references a PR
Date: Sun, 19 Jun 2011 11:14:12 +0000 (UTC)

 Author: bcr (doc committer)
 Date: Sun Jun 19 11:14:02 2011
 New Revision: 223291
 URL: http://svn.freebsd.org/changeset/base/223291
 
 Log:
   MFC r223160:
   
   Fix some wording and grammar in the BUGS section.
   
   PR:             docs/157901
   Submitted by:   Niclas Zeising (niclas dot zeising at gmail dot com)
   Reviewed by:    mav
 
 Modified:
   stable/7/share/man/man4/snd_hda.4
 Directory Properties:
   stable/7/share/man/man4/   (props changed)
 
 Modified: stable/7/share/man/man4/snd_hda.4
 ==============================================================================
 --- stable/7/share/man/man4/snd_hda.4	Sun Jun 19 11:01:38 2011	(r223290)
 +++ stable/7/share/man/man4/snd_hda.4	Sun Jun 19 11:14:02 2011	(r223291)
 @@ -626,17 +626,21 @@ and
  A few Hardware/OEM vendors tend to screw up BIOS settings, thus
  rendering the
  .Nm
 -driver useless, which usually results in a state where the
 +driver useless.
 +This usually results in a state where the
  .Nm
 -driver seems to attach and work, but without any sound. Some of
 -that cases can be solved by tuning loader.conf variables. But before
 -trying to fix problem that way, make sure that problem is really exists
 -and the PCM audio device you are using really corresponds to expected
 +driver seems to attach and work, but no sound is played.
 +Some cases can be solved by tuning
 +.Pa loader.conf
 +variables.
 +Before trying to fix problem that way, make sure that there really is a problem
 +and that the PCM audio device in use really corresponds to the expected
  audio connector.
  .Pp
 -Some vendors use non-standardized General Purpose I/O (GPIO) pins of codec
 -to control external amplifiers. In some cases setting proper combination of
 -GPIO bits may be needed to make sound work on specific device.
 +Some vendors use non-standardized General Purpose I/O (GPIO) pins of the codec
 +to control external amplifiers.
 +In some cases setting a combination of GPIO bits may be needed to make
 +sound work on a specific device.
  .Pp
  HDMI and DisplayPort audio may also require support from video driver.
  .Pp
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: bcr 
State-Changed-When: Sun Jun 19 11:20:20 UTC 2011 
State-Changed-Why:  
MFC is done. Thanks for filing the PR and sending the patch. PR closed! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157901 
>Unformatted:
