From nobody@FreeBSD.org  Sun Feb  6 15:51:09 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA8CC106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 Feb 2011 15:51:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id BA0B88FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  6 Feb 2011 15:51:09 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p16Fp9au045370
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 6 Feb 2011 15:51:09 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p16Fp9cn045369;
	Sun, 6 Feb 2011 15:51:09 GMT
	(envelope-from nobody)
Message-Id: <201102061551.p16Fp9cn045369@red.freebsd.org>
Date: Sun, 6 Feb 2011 15:51:09 GMT
From: Warren Block <wblock@wonkity.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Porter's Handbook Java vendors list update
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         154553
>Category:       docs
>Synopsis:       [patch] Porter's Handbook Java vendors list update
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ryusuke
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 06 16:00:20 UTC 2011
>Closed-Date:    Tue Feb 15 15:42:12 UTC 2011
>Last-Modified:  Tue Feb 15 15:42:12 UTC 2011
>Originator:     Warren Block
>Release:        8.2-PRERELEASE
>Organization:
>Environment:
FreeBSD lightning 8.2-PRERELEASE FreeBSD 8.2-PRERELEASE #0: Fri Feb  4 10:06:26 MST 2011     root@lightning:/usr/obj/usr/src/sys/LIGHTNING  i386
>Description:
The Porter's Handbook JAVA_VENDOR list is out of sync with the actual values in /usr/ports/Mk/bsd.java.mk, line 169:

_JAVA_VENDOR_LIST=              freebsd bsdjava sun blackdown openjdk

Note also that the comment on lines 34-35 of bsd.java.mk is also outdated.  I can submit a separate patch for that if needed.
>How-To-Repeat:
See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-java.html
>Fix:
Apply attached patch.

Patch attached with submission follows:

--- en_US.ISO8859-1/books/porters-handbook/book.sgml.orig	2011-02-06 08:31:01.000000000 -0700
+++ en_US.ISO8859-1/books/porters-handbook/book.sgml	2011-02-06 08:33:19.000000000 -0700
@@ -6179,8 +6179,8 @@
 	    <row>
 	      <entry><makevar>JAVA_VENDOR</makevar></entry>
 	      <entry>List of space-separated suitable JDK port vendors for
-		the port (allowed values: <literal>freebsd bsdjava sun ibm
-		blackdown</literal>).</entry>
+		the port (allowed values: <literal>freebsd bsdjava sun
+		blackdown openjdk</literal>).</entry>
 	    </row>
 
 	    <row>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->ryusuke 
Responsible-Changed-By: ryusuke 
Responsible-Changed-When: Fri Feb 11 05:21:12 UTC 2011 
Responsible-Changed-Why:  
I'll take this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154553 

From: Ryusuke SUZUKI <ryusuke@FreeBSD.org>
To: wblock@wonkity.com
Cc: freebsd-gnats-submit@FreeBSD.org, ryusuke@FreeBSD.org
Subject: Re: docs/154553: [patch] Porter's Handbook Java vendors list update
Date: Fri, 11 Feb 2011 22:28:01 +0900 (JST)

 ----Security_Multipart(Fri_Feb_11_22_28_01_2011_729)--
 Content-Type: Text/Plain; charset=us-ascii
 Content-Transfer-Encoding: 7bit
 
 Hello, Warren-san,
 
 wb> The Porter's Handbook JAVA_VENDOR list is out of sync with the actual values
 wb> in /usr/ports/Mk/bsd.java.mk, line 169:
 wb> _JAVA_VENDOR_LIST= freebsd bsdjava sun blackdown openjdk
 wb> Note also that the comment on lines 34-35 of bsd.java.mk is also outdated.
 wb> I can submit a separate patch for that if needed.
 
  I agree that both porter's handbook and bsd.java.mk are outdated.
 
  I will commit your patch, and also ask responsible person for bsd.java.mk
  to commit following patch.
 
 Regards,
     Ryusuke
 
 --- bsd.java.mk.orig	2011-02-11 22:06:44.000000000 +0900
 +++ bsd.java.mk	2011-02-11 22:07:15.000000000 +0900
 @@ -32,7 +32,7 @@
  #					for the port. (allowed values: native linux)
  #
  # JAVA_VENDOR		List of space-separated suitable JDK port vendors for the
 -#					port. (allowed values: freebsd bsdjava sun blackdown)
 +#					port. (allowed values: freebsd bsdjava sun blackdown openjdk)
  #
  # JAVA_BUILD		When set, it means that the selected JDK port should be
  #					added to build dependencies for the port.
 
 
 
 ----Security_Multipart(Fri_Feb_11_22_28_01_2011_729)--
 Content-Type: application/pgp-signature
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.9 (FreeBSD)
 
 iEYEABECAAYFAk1VOWEACgkQG5rRvmPSlySjNACffWPGLwzDPGK39Jtrtah/BFmk
 e1gAn2nSdyPHYsrhiv/L+ibirVjyOSzo
 =gtgE
 -----END PGP SIGNATURE-----
 
 ----Security_Multipart(Fri_Feb_11_22_28_01_2011_729)----

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/154553: commit references a PR
Date: Fri, 11 Feb 2011 14:22:54 +0000 (UTC)

 ryusuke     2011-02-11 14:22:49 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/porters-handbook book.sgml 
   Log:
   Update JAVA_VENDOR list to sync with the actual values in /usr/ports/Mk/bsd.java.mk.
   
   PR: docs/154553
   Submitted by: Warren Block <wblock _at_ wonkity dot com>
   
   Revision  Changes    Path
   1.1094    +2 -2      doc/en_US.ISO8859-1/books/porters-handbook/book.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/154553: commit references a PR
Date: Sat, 12 Feb 2011 15:48:54 +0000 (UTC)

 hq          2011-02-12 15:48:48 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.java.mk 
   Log:
   Update the list of possible values for JDK vendor in the header comments
   
   PR:             154553
   Submitted by:   Warren Block <wblock@wonkity.com> (PR),
                   ryusuke (patch)
   
   Revision  Changes    Path
   1.87      +3 -2      ports/Mk/bsd.java.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ryusuke 
State-Changed-When: Tue Feb 15 15:40:37 UTC 2011 
State-Changed-Why:  
Porter's handbook and ports/Mk/bsd.java.mk are updated. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154553 
>Unformatted:
