From nobody@FreeBSD.org  Thu Oct  7 14:04:07 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7750B106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  7 Oct 2010 14:04:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B9568FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  7 Oct 2010 14:04:07 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o97E46aZ058045
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 7 Oct 2010 14:04:06 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o97E46AT058044;
	Thu, 7 Oct 2010 14:04:06 GMT
	(envelope-from nobody)
Message-Id: <201010071404.o97E46AT058044@www.freebsd.org>
Date: Thu, 7 Oct 2010 14:04:06 GMT
From: Bas Smeelen <b.smeelen@ose.nl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] man(1) top change pages to bytes in description of memory
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         151283
>Category:       docs
>Synopsis:       [patch] top(1) change pages to bytes in description of memory
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 07 14:10:01 UTC 2010
>Closed-Date:    Tue Nov 16 07:28:25 UTC 2010
>Last-Modified:  Tue Nov 16 07:30:15 UTC 2010
>Originator:     Bas Smeelen
>Release:        8.1-RELEASE
>Organization:
>Environment:
FreeBSD test.ose.nl 8.1-RELEASE FreeBSD 8.1-RELEASE #6: Fri Jul 30 09:08:22 CEST 2010 Freebee@test.ose.nl:/usr/obj/usr/src/sys/GIZMO amd64
>Description:
The top manpage states in the memory discription that the output is in pages. 
The output of top in the memory section is apparantly in bytes, this can be verified in the top source file on lines 430 to 460 at the comment /* conve
rt memory stats to Kbytes */
This has been discussed on freebsd-questions october 2010

>How-To-Repeat:
Execute top and verify the output.
>Fix:
See patch below

Patch attached with submission follows:

--- top.local.1.orig	2010-10-07 15:16:28.000000000 +0200
+++ top.local.1	2010-10-07 15:22:48.000000000 +0200
@@ -6,7 +6,7 @@
 At runtime the 'H' key will toggle this mode. The default is OFF.
 
 .SH DESCRIPTION OF MEMORY 
-Mem: 9220K Active, 1032K Inact, 3284K Wired, 1MB Cache, 2M Buf, 1320K Free
+Mem: 9220K Active, 1032K Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K Free
 Swap:   91M Total, 79M Free, 13% Inuse, 80K In, 104 K Out
 
 .B K:
@@ -19,23 +19,23 @@
 1/100
 .TP
 .B Active:
-number of pages active
+number of bytes active
 .TP
 .B Inact:
-number of pages inactive
+number of bytes inactive
 .TP
 .B Wired:
-number of pages wired down, including cached file data pages
+number of bytes wired down, including cached file data pages
 .TP
 .B Cache:
-number of clean pages caching data that are available for
+number of clean bytes caching data that are available for
 immediate reallocation
 .TP
 .B Buf:
-number of pages used for BIO-level disk caching
+number of bytes used for BIO-level disk caching
 .TP
 .B Free: 
-number of pages free
+number of bytes free
 .TP
 .B Total: 
 total available swap usage
@@ -47,7 +47,7 @@
 swap usage
 .TP 
 .B In: 
-pages paged in from swap devices (last interval)
+bytes paged in from swap devices (last interval)
 .TP
 .B Out: 
-pages paged out to swap devices (last interval)
+bytes paged out to swap devices (last interval)


>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/151283: commit references a PR
Date: Sat, 13 Nov 2010 11:43:27 +0000 (UTC)

 Author: brucec
 Date: Sat Nov 13 11:43:20 2010
 New Revision: 215239
 URL: http://svn.freebsd.org/changeset/base/215239
 
 Log:
   Memory stats are reported in bytes, not pages.
   
   PR:	docs/151283
   Submitted by:	Bas Smeelen <b.smeelen at ose.nl>
   MFC after: 3 days
 
 Modified:
   head/usr.bin/top/top.local.1
 
 Modified: head/usr.bin/top/top.local.1
 ==============================================================================
 --- head/usr.bin/top/top.local.1	Sat Nov 13 11:11:51 2010	(r215238)
 +++ head/usr.bin/top/top.local.1	Sat Nov 13 11:43:20 2010	(r215239)
 @@ -6,8 +6,8 @@ The '-H' option will toggle the display 
  At runtime the 'H' key will toggle this mode. The default is OFF.
  
  .SH DESCRIPTION OF MEMORY 
 -Mem: 9220K Active, 1032K Inact, 3284K Wired, 1MB Cache, 2M Buf, 1320K Free
 -Swap:   91M Total, 79M Free, 13% Inuse, 80K In, 104 K Out
 +Mem: 9220K Active, 1032K Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K Free
 +Swap: 91M Total, 79M Free, 13% Inuse, 80K In, 104K Out
  
  .B K:
  Kilobyte
 @@ -19,23 +19,23 @@ Megabyte
  1/100
  .TP
  .B Active:
 -number of pages active
 +number of bytes active
  .TP
  .B Inact:
 -number of pages inactive
 +number of bytes inactive
  .TP
  .B Wired:
 -number of pages wired down, including cached file data pages
 +number of bytes wired down, including cached file data pages
  .TP
  .B Cache:
 -number of clean pages caching data that are available for
 +number of clean bytes caching data that are available for
  immediate reallocation
  .TP
  .B Buf:
 -number of pages used for BIO-level disk caching
 +number of bytes used for BIO-level disk caching
  .TP
  .B Free: 
 -number of pages free
 +number of bytes free
  .TP
  .B Total: 
  total available swap usage
 @@ -47,7 +47,7 @@ total free swap usage
  swap usage
  .TP 
  .B In: 
 -pages paged in from swap devices (last interval)
 +bytes paged in from swap devices (last interval)
  .TP
  .B Out: 
 -pages paged out to swap devices (last interval)
 +bytes paged out to swap devices (last interval)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched  
State-Changed-By: brucec 
State-Changed-When: Sat Nov 13 12:10:23 UTC 2010 
State-Changed-Why:  
Fixed in HEAD. 


Responsible-Changed-From-To: freebsd-doc->brucec 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Sat Nov 13 12:10:23 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151283 
State-Changed-From-To: patched->closed 
State-Changed-By: brucec 
State-Changed-When: Tue Nov 16 07:28:02 UTC 2010 
State-Changed-Why:  
Merged to stable/7 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151283 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/151283: commit references a PR
Date: Tue, 16 Nov 2010 07:24:25 +0000 (UTC)

 Author: brucec
 Date: Tue Nov 16 07:24:17 2010
 New Revision: 215380
 URL: http://svn.freebsd.org/changeset/base/215380
 
 Log:
   MFC r215239:
   
   Memory stats are reported in bytes, not pages.
   
   PR:	docs/151283
   Submitted by:	Bas Smeelen <b.smeelen at ose.nl>
 
 Modified:
   stable/8/usr.bin/top/top.local.1
 Directory Properties:
   stable/8/usr.bin/top/   (props changed)
 
 Modified: stable/8/usr.bin/top/top.local.1
 ==============================================================================
 --- stable/8/usr.bin/top/top.local.1	Tue Nov 16 07:19:05 2010	(r215379)
 +++ stable/8/usr.bin/top/top.local.1	Tue Nov 16 07:24:17 2010	(r215380)
 @@ -6,8 +6,8 @@ The '-H' option will toggle the display 
  At runtime the 'H' key will toggle this mode. The default is OFF.
  
  .SH DESCRIPTION OF MEMORY 
 -Mem: 9220K Active, 1032K Inact, 3284K Wired, 1MB Cache, 2M Buf, 1320K Free
 -Swap:   91M Total, 79M Free, 13% Inuse, 80K In, 104 K Out
 +Mem: 9220K Active, 1032K Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K Free
 +Swap: 91M Total, 79M Free, 13% Inuse, 80K In, 104K Out
  
  .B K:
  Kilobyte
 @@ -19,23 +19,23 @@ Megabyte
  1/100
  .TP
  .B Active:
 -number of pages active
 +number of bytes active
  .TP
  .B Inact:
 -number of pages inactive
 +number of bytes inactive
  .TP
  .B Wired:
 -number of pages wired down, including cached file data pages
 +number of bytes wired down, including cached file data pages
  .TP
  .B Cache:
 -number of clean pages caching data that are available for
 +number of clean bytes caching data that are available for
  immediate reallocation
  .TP
  .B Buf:
 -number of pages used for BIO-level disk caching
 +number of bytes used for BIO-level disk caching
  .TP
  .B Free: 
 -number of pages free
 +number of bytes free
  .TP
  .B Total: 
  total available swap usage
 @@ -47,7 +47,7 @@ total free swap usage
  swap usage
  .TP 
  .B In: 
 -pages paged in from swap devices (last interval)
 +bytes paged in from swap devices (last interval)
  .TP
  .B Out: 
 -pages paged out to swap devices (last interval)
 +bytes paged out to swap devices (last interval)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/151283: commit references a PR
Date: Tue, 16 Nov 2010 07:26:55 +0000 (UTC)

 Author: brucec
 Date: Tue Nov 16 07:26:49 2010
 New Revision: 215381
 URL: http://svn.freebsd.org/changeset/base/215381
 
 Log:
   MFC r215239:
   
   Memory stats are reported in bytes, not pages.
   
   PR:	docs/151283
   Submitted by:	Bas Smeelen <b.smeelen at ose.nl>
 
 Modified:
   stable/7/usr.bin/top/top.local.1
 Directory Properties:
   stable/7/usr.bin/top/   (props changed)
 
 Modified: stable/7/usr.bin/top/top.local.1
 ==============================================================================
 --- stable/7/usr.bin/top/top.local.1	Tue Nov 16 07:24:17 2010	(r215380)
 +++ stable/7/usr.bin/top/top.local.1	Tue Nov 16 07:26:49 2010	(r215381)
 @@ -6,8 +6,8 @@ The '-H' option will toggle the display 
  At runtime the 'H' key will toggle this mode. The default is OFF.
  
  .SH DESCRIPTION OF MEMORY 
 -Mem: 9220K Active, 1032K Inact, 3284K Wired, 1MB Cache, 2M Buf, 1320K Free
 -Swap:   91M Total, 79M Free, 13% Inuse, 80K In, 104 K Out
 +Mem: 9220K Active, 1032K Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K Free
 +Swap: 91M Total, 79M Free, 13% Inuse, 80K In, 104K Out
  
  .B K:
  Kilobyte
 @@ -19,23 +19,23 @@ Megabyte
  1/100
  .TP
  .B Active:
 -number of pages active
 +number of bytes active
  .TP
  .B Inact:
 -number of pages inactive
 +number of bytes inactive
  .TP
  .B Wired:
 -number of pages wired down, including cached file data pages
 +number of bytes wired down, including cached file data pages
  .TP
  .B Cache:
 -number of clean pages caching data that are available for
 +number of clean bytes caching data that are available for
  immediate reallocation
  .TP
  .B Buf:
 -number of pages used for BIO-level disk caching
 +number of bytes used for BIO-level disk caching
  .TP
  .B Free: 
 -number of pages free
 +number of bytes free
  .TP
  .B Total: 
  total available swap usage
 @@ -47,7 +47,7 @@ total free swap usage
  swap usage
  .TP 
  .B In: 
 -pages paged in from swap devices (last interval)
 +bytes paged in from swap devices (last interval)
  .TP
  .B Out: 
 -pages paged out to swap devices (last interval)
 +bytes paged out to swap devices (last interval)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
