From foreignuser@eitanadler.com  Sat Sep 11 15:08:47 2010
Return-Path: <foreignuser@eitanadler.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F1D57106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Sep 2010 15:08:47 +0000 (UTC)
	(envelope-from foreignuser@eitanadler.com)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id B21F38FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Sep 2010 15:08:47 +0000 (UTC)
Received: by qwg5 with SMTP id 5so2571415qwg.13
        for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Sep 2010 08:08:46 -0700 (PDT)
Received: by 10.224.54.72 with SMTP id p8mr1394076qag.51.1284217726368;
        Sat, 11 Sep 2010 08:08:46 -0700 (PDT)
Received: from AlphaBeta.local (ool-182fc857.dyn.optonline.net [24.47.200.87])
        by mx.google.com with ESMTPS id r36sm4054775qcs.27.2010.09.11.08.08.43
        (version=SSLv3 cipher=RC4-MD5);
        Sat, 11 Sep 2010 08:08:45 -0700 (PDT)
Received: by AlphaBeta.local (sSMTP sendmail emulation); Sat, 11 Sep 2010 11:08:37 -0400
Message-Id: <4c8b9b7d.6482e50a.22d0.ffff945c@mx.google.com>
Date: Sat, 11 Sep 2010 11:08:37 -0400
From: Eitan Adler <foreignuser@eitanadler.com>
Reply-To: Eitan Adler <lists@eitanadler.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: newfs man page clarification
X-Send-Pr-Version: 3.1415926535897932384626433832795028841971693993751058209749445923078164062862089986280348253421170679
X-GNATS-Notify:

>Number:         150490
>Category:       docs
>Synopsis:       [patch] newfs man page clarification
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gjb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 11 15:10:02 UTC 2010
>Closed-Date:    Sun Feb 27 17:38:33 UTC 2011
>Last-Modified:  Sun Feb 27 17:38:33 UTC 2011
>Originator:     Eitan Adler
>Release:        N/A
>Organization:
>Environment:
N/A

>Description:
Index: newfs.8
===================================================================
--- newfs.8	(revision 209815)
+++ newfs.8	(working copy)
@@ -82,7 +82,7 @@
 This is a relevant option for flash based storage devices that use
 wear levelling algorithms.
 
-NB: Erasing may take as long time as writing every sector on the disk.
+NB: Erasing may take as long time as it writes to every sector on the disk.
 .It Fl J
 Enable journaling on the new file system via gjournal.
 See

>How-To-Repeat:
>Fix:

>Release-Note:
>Audit-Trail:

From: Peter Pentchev <roam@ringlet.net>
To: Eitan Adler <lists@eitanadler.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: docs/150490: newfs man page clarification
Date: Sat, 11 Sep 2010 18:17:32 +0300

 --k+w/mQv8wyuph6w0
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sat, Sep 11, 2010 at 11:08:37AM -0400, Eitan Adler wrote:
 > >Number:         150490
 > >Category:       docs
 > >Synopsis:       newfs man page clarification
 [snip]
 > -NB: Erasing may take as long time as writing every sector on the disk.
 > +NB: Erasing may take as long time as it writes to every sector on the di=
 sk.
 
 Uhm, I believe the original wording is correct.  The "as" in "as writing" h=
 ere
 does not stand for "because"; it's part of a "as ... as ..." construction
 which... oh, well, all right :)  I guess it might be a bit clearer to say
 something like:
 
   Erasing may take time as long as writing every sector on the disk.
 
 =2E..or something like that, though it's not much clearer than the original=
  :)
 The original author's point here is that the time that erasing takes is
 as long (a time) as (the time it takes) writing every sector on the disk.
 
 Or something like that :)
 
 G'luck,
 Peter
 
 --=20
 Peter Pentchev	roam@space.bg    roam@ringlet.net    roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 "yields falsehood, when appended to its quotation." yields falsehood, when =
 appended to its quotation.
 
 --k+w/mQv8wyuph6w0
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: Digital signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (GNU/Linux)
 
 iQIcBAEBCgAGBQJMi52IAAoJEGUe77AlJ98TPP8P/i5TaiQIQ4ycrTKRzcwxGvIE
 pIYyXwS4cOJYBOPmOlVhPp0ofKPgNJAncIw1PI2YxYkozPpo8VZwgN8hm/8WgM6D
 U2PnDCg+oS5bp39w2Ktcdqaf73yp3LP8/OnpG9A00/6soA+kkb1RUYN4EQjEzuZ/
 B6i91/wleOlj6YpSzNjxuZyqdsVyJQvF4k0aAqmGA/ycTXkFUGH4kGYr+zFBQeus
 uH/OKWVjFswlZJm5lBsWSGqynJbaIcIiLbzDt8kZAljTAr5ml61MnSH6o4BG7dO4
 9WhxYaSKMyk6BytBo+lLplCx2bMo3riYpumR7i+R5LLah4Yi+ZQy8flmecelWfTV
 VLQxtPXFOemfNhyttmb5dFs6hdLIHDhyHu/FtFBEL8eklMCxh+vX6a81SzgqGH7w
 4umUZnp4AkJLD3WSeCzX/tDnGoq6tNZLEkXOzABMuyih6MDNXdHQS5gGvXN5PTCY
 N2z3ZuvMrqfYugQsFHZrlD53Fu5v80WeEANJCj+naRh01/GxhrbFJxhdd/GYZJ+X
 2G1x4IoXXXEKYtnYUiSXYqytr/t4xzRz462RZFtfQ08Ldrq/FoA0kwv7cCGk1jyn
 sDrH5rtqnS38OlLo5dXdkS0zDLppyJhCUtem6WMywFzCIy3PjRLyWCa7anHmBIHf
 +o78DGrBIXZhsUKs7Ci2
 =yFkz
 -----END PGP SIGNATURE-----
 
 --k+w/mQv8wyuph6w0--

From: Warren Block <wblock@wonkity.com>
To: Eitan Adler <lists@eitanadler.com>
Cc: FreeBSD-gnats-submit@freebsd.org, freebsd-doc@freebsd.org
Subject: Re: docs/150490: newfs man page clarification
Date: Sat, 11 Sep 2010 09:16:52 -0600 (MDT)

 On Sat, 11 Sep 2010, Eitan Adler wrote:
 
 >> Description:
 > Index: newfs.8
 > ===================================================================
 > --- newfs.8	(revision 209815)
 > +++ newfs.8	(working copy)
 > @@ -82,7 +82,7 @@
 > This is a relevant option for flash based storage devices that use
 > wear levelling algorithms.
 >
 > -NB: Erasing may take as long time as writing every sector on the disk.
 > +NB: Erasing may take as long time as it writes to every sector on the disk.
                          ^^
 Should be "a" instead of "as".

From: Eitan Adler <lists@eitanadler.com>
To: Peter Pentchev <roam@ringlet.net>
Cc: bug-followup@freebsd.org
Subject: Re: docs/150490: newfs man page clarification
Date: Sat, 11 Sep 2010 11:20:06 -0400

 > [snip]
 >> -NB: Erasing may take as long time as writing every sector on the disk.
 >> +NB: Erasing may take as long time as it writes to every sector on the d=
 isk.
 >
 > Uhm, I believe the original wording is correct. =C2=A0The "as" in "as wri=
 ting" here
 > does not stand for "because"; it's part of a "as ... as ..." construction
 > which... oh, well, all right :) =C2=A0I guess it might be a bit clearer t=
 o say
 > something like:
 >
 > =C2=A0Erasing may take time as long as writing every sector on the disk.
 >
 > ...or something like that, though it's not much clearer than the original=
  :)
 > The original author's point here is that the time that erasing takes is
 > as long (a time) as (the time it takes) writing every sector on the disk.
 >
 > Or something like that :)
 >
 
 Erasing the disk will take as much time as it takes to write to every
 sector on the disk.
 Erasing may take a long time as it writes to every sector on the disk.
 Erasing will take as much time as writing every sector to disk takes.
 
 Take your pick ;-)
 
 If it matters I'm a native speaker and the original sentence does not
 make sense to me as is.
 
 --=20
 Eitan Adler
Responsible-Changed-From-To: freebsd-doc->gjb 
Responsible-Changed-By: gjb 
Responsible-Changed-When: Sat Sep 11 16:27:28 UTC 2010 
Responsible-Changed-Why:  
I'll take this. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=150490 
State-Changed-From-To: open->patched 
State-Changed-By: gjb 
State-Changed-When: Sun Sep 12 17:50:26 UTC 2010 
State-Changed-Why:  
Patched in HEAD.  MFC in 1 week. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=150490 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/150490: commit references a PR
Date: Sun, 12 Sep 2010 17:50:15 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Sun Sep 12 17:50:07 2010
 New Revision: 212498
 URL: http://svn.freebsd.org/changeset/base/212498
 
 Log:
   Rewording and typo fixes in newfs(8).
   
   PR:		150490
   Submitted by:	Eitan Adler <foreignuser at eitanadler com>
   Additional fixes by:	Warren Block <wblock at wonkity com>, keramida
   Approved by:	keramida (mentor)
   MFC after:	1 week
 
 Modified:
   head/sbin/newfs/newfs.8
 
 Modified: head/sbin/newfs/newfs.8
 ==============================================================================
 --- head/sbin/newfs/newfs.8	Sun Sep 12 17:04:51 2010	(r212497)
 +++ head/sbin/newfs/newfs.8	Sun Sep 12 17:50:07 2010	(r212498)
 @@ -79,10 +79,10 @@ The following options define the general
  Erase the content of the disk before making the filesystem.
  The reserved area in front of the superblock (for bootcode) will not be erased.
  .Pp
 -This is a relevant option for flash based storage devices that use
 -wear levelling algorithms.
 +This option is only relevant for flash based storage devices that use
 +wear-leveling algorithms.
  .Pp
 -NB: Erasing may take as long time as writing every sector on the disk.
 +Erasing may take a long time as it writes to every sector on the disk.
  .It Fl J
  Enable journaling on the new file system via gjournal.
  See
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gjb 
State-Changed-When: Sun Feb 27 17:38:07 UTC 2011 
State-Changed-Why:  
MFC'd to stable/8.  Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=150490 
>Unformatted:
