From nobody@FreeBSD.org  Tue Sep  7 21:01:30 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 38A001065673
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Sep 2010 21:01:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 26ADE8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Sep 2010 21:01:30 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o87L1TsE072164
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 7 Sep 2010 21:01:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o87L1Trp072163;
	Tue, 7 Sep 2010 21:01:29 GMT
	(envelope-from nobody)
Message-Id: <201009072101.o87L1Trp072163@www.freebsd.org>
Date: Tue, 7 Sep 2010 21:01:29 GMT
From: Alexander Best <arundel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [make.conf] [patch] remove BDECFLAGS from make.conf(5) manual and change their description in share/examples/etc/make.conf
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         150365
>Category:       docs
>Synopsis:       [make.conf] [patch] remove BDECFLAGS from make.conf(5) manual and change their description in share/examples/etc/make.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    arundel
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 07 21:10:06 UTC 2010
>Closed-Date:    
>Last-Modified:  Mon Nov 21 23:22:34 UTC 2011
>Originator:     Alexander Best
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r212123=732762f-dirty: Thu Sep  2 02:18:13 CEST 2010     root@otaku:/usr/obj/usr/src/sys/ARUNDEL  amd64
>Description:
BDECFLAGS is being referenced in make.conf(5), although it's been completely removed from the src tree. also the description in share/examples/etc/make.conf on how to enable BDECFLAGS needs to be changed.

thanks go out to pluknet for hacking up the 'share/examples/etc/make.conf'-patch. i've only changed a few bits of his initial version here and there.

also i've corrected a few syntax mistakes in make.conf(5). i'm not sure however what caused the diff entry "@@ -269,14 +271,14 @@" in share/examples/etc/make.conf. i couldn't find any changes.

cheers.
alex
>How-To-Repeat:
man make.conf
cat /usr/share/examples/etc/make.conf
>Fix:
apply the attach patched.

Patch attached with submission follows:

diff --git a/share/examples/etc/make.conf b/share/examples/etc/make.conf
index 128a04a..385a4df 100644
--- a/share/examples/etc/make.conf
+++ b/share/examples/etc/make.conf
@@ -72,9 +72,11 @@
 #MAKE_SHELL?=sh
 #
 # BDECFLAGS are a set of gcc warning settings that Bruce Evans has suggested
-# for use in developing FreeBSD and testing changes.  They can be used by
-# putting "CFLAGS+=${BDECFLAGS}" in /etc/make.conf.  -Wconversion is not
-# included here due to compiler bugs, e.g., mkdir()'s mode_t argument.
+# for use in developing FreeBSD and testing changes.  They should *not* be used
+# in a production envirement.
+# They can be used by adding the definition shown below to /etc/make.conf.  To
+# enable BDECFLAGS put "CFLAGS+=${BDECFLAGS}" in /etc/make.conf.  -Wconversion
+# is not included here due to compiler bugs, e.g., mkdir()'s mode_t argument.
 #
 #BDECFLAGS=	-W -Wall -ansi -pedantic -Wbad-function-cast -Wcast-align \
 #		-Wcast-qual -Wchar-subscripts -Winline \
@@ -269,14 +271,14 @@
 # /etc/mail/Makefile.  Defaults to 0640.
 #
 #SENDMAIL_MAP_PERMS=
-#
-#
-# It is also possible to set variables in make.conf which will only be
-# used when compiling a specific port.  For more details see make(1).
-#
-#.if ${.CURDIR:M*/irc/irssi-devel*}
-#WITH_DEBUG=YES
-#.endif
-#
-# Another approach is to use /usr/ports/ports-mgmt/portconf which has
-# its own config file for port specific options.
+#
+#
+# It is also possible to set variables in make.conf which will only be
+# used when compiling a specific port.  For more details see make(1).
+#
+#.if ${.CURDIR:M*/irc/irssi-devel*}
+#WITH_DEBUG=YES
+#.endif
+#
+# Another approach is to use /usr/ports/ports-mgmt/portconf which has
+# its own config file for port specific options.
diff --git a/share/man/man5/make.conf.5 b/share/man/man5/make.conf.5
index 9cc3c1d..e9856d5 100644
--- a/share/man/man5/make.conf.5
+++ b/share/man/man5/make.conf.5
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd December 15, 2009
+.Dd September 7, 2010
 .Dt MAKE.CONF 5
 .Os
 .Sh NAME
@@ -141,17 +141,6 @@ Optimization levels other than
 and
 .Fl O2
 are not supported.
-.Va BDECFLAGS
-is provided as a set of
-.Xr gcc 1
-settings suggested by
-.An "Bruce Evans" Aq bde@FreeBSD.org
-for developing and testing changes.
-They can be used, if set, by:
-.Pp
-.Bd -literal -offset indent
-CFLAGS+=${BDECFLAGS}
-.Ed
 .It Va CPUTYPE
 .Pq Vt str
 Controls which processor should be targeted for generated
@@ -307,7 +296,7 @@ The flag for the
 command when doing
 .Dq Li "make update" .
 This defaults to
-.Op Fl g L Ar 2 .
+.Fl g L Ar 2 .
 .It Va SUPHOST
 .Pq Vt str
 The hostname of the sup server to use when doing
@@ -344,7 +333,7 @@ set to 0.
 Controls the compiler settings when building the
 kernel.
 Optimization levels above
-.Oo Fl O ( O2 , No ...\& ) Oc
+.Fl O ( O2 , No ...\& )
 are not guaranteed to work.
 .It Va KERNCONF
 .Pq Vt str
@@ -479,7 +468,7 @@ rather than load the server's kernel.
 .Pq Vt bool
 Defining this and recompiling
 .Pa /usr/src/sys/boot/i386
-will add 
+will add
 .Xr dcons 4
 console driver to
 .Xr loader 8
@@ -619,7 +608,7 @@ The default value is 0640.
 .Pq Vt str
 Additional maps to rebuild when using
 .Pa /etc/mail/Makefile .
-The 
+The
 .Pa access ,
 .Pa bitdomain ,
 .Pa domaintable ,


>Release-Note:
>Audit-Trail:

From: Alexander Best <arundel@freebsd.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: docs/150365: [make.conf] [patch] remove BDECFLAGS from make.conf(5) manual and change their description in share/examples/etc/make.conf
Date: Tue, 7 Sep 2010 21:40:31 +0000

 ok i think the reason for the "@@ -269,14 +271,14 @@" changes are the fact that
 those lines were using CR+LF (Windows), instead of just LF (Unix). seems my
 editor converted those automatically. so those lines should in fact be changed,
 since we don't want extra CRs in text files.
 
 cheers.
 alex
 
 -- 
 a13x
Responsible-Changed-From-To: freebsd-doc->arundel 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Mon Nov 21 23:21:53 UTC 2011 
Responsible-Changed-Why:  
Assign to me. Although i don't have commit rights to src, 
i'm working on this issue atm. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150365 
>Unformatted:
