From nobody@FreeBSD.org  Sun Apr 25 19:34:22 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF5B8106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Apr 2010 19:34:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BDE058FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Apr 2010 19:34:22 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o3PJYM1q019456
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Apr 2010 19:34:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o3PJYMTg019455;
	Sun, 25 Apr 2010 19:34:22 GMT
	(envelope-from nobody)
Message-Id: <201004251934.o3PJYMTg019455@www.freebsd.org>
Date: Sun, 25 Apr 2010 19:34:22 GMT
From: Alexander Best <alexbestms@wwu.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [kld] [patch] the kldstat(2) manual needs to be more precise about the purpose of kld_file_stat.size
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         146047
>Category:       docs
>Synopsis:       [kld] [patch] the kldstat(2) manual needs to be more precise about the purpose of kld_file_stat.size
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gjb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 25 19:40:02 UTC 2010
>Closed-Date:    Tue Apr 26 13:11:19 UTC 2011
>Last-Modified:  Tue Apr 26 13:20:05 UTC 2011
>Originator:     Alexander Best
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r207154M: Sat Apr 24 21:14:37 CEST 2010     root@otaku:/usr/obj/usr/src/sys/ARUNDEL  amd64
>Description:
the kldstat(2) manual states that kld_file_stat.size contains "the size of the file". what kld_file_stat.size actually contains is the amount of memory taken up by the file.
>How-To-Repeat:

>Fix:
apply the attached patch.

Patch attached with submission follows:

Index: lib/libc/sys/kldstat.2
===================================================================
--- lib/libc/sys/kldstat.2	(revision 207014)
+++ lib/libc/sys/kldstat.2	(working copy)
@@ -25,7 +25,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd March 3, 1999
+.Dd April 2, 2010
 .Dt KLDSTAT 2
 .Os
 .Sh NAME
@@ -77,7 +77,7 @@
 .It address
 The load address of the kld file.
 .It size
-The size of the file.
+The amount of memory allocated for the file.
 .It pathname
 The full name of the file referred to by
 .Fa fileid ,


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-doc->gjb 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Fri Apr 22 00:01:19 UTC 2011 
Responsible-Changed-Why:  
Hi Glen, 

any chance you could commit the following patch? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146047 

From: Alexander Best <arundel@freebsd.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: docs/146047: [kld] [patch] the kldstat(2) manual needs to be more precise about the purpose of kld_file_stat.size
Date: Fri, 22 Apr 2011 00:00:57 +0000

 --6c2NcOVqGQ03X4Wi
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 here's a revised patch.
 
 -- 
 a13x
 
 --6c2NcOVqGQ03X4Wi
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="kldstat.2.diff"
 
 diff --git a/lib/libc/sys/kldstat.2 b/lib/libc/sys/kldstat.2
 index 0d28928..199f95c 100644
 --- a/lib/libc/sys/kldstat.2
 +++ b/lib/libc/sys/kldstat.2
 @@ -25,7 +25,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd March 3, 1999
 +.Dd April 22, 2011
  .Dt KLDSTAT 2
  .Os
  .Sh NAME
 @@ -76,7 +76,7 @@ The id of the file specified in
  .It address
  The load address of the kld file.
  .It size
 -The size of the file.
 +The size of the file in memory.
  .It pathname
  The full name of the file referred to by
  .Fa fileid ,
 
 --6c2NcOVqGQ03X4Wi--

From: Glen Barber <gjb@FreeBSD.org>
To: bug-followup@FreeBSD.org, alexbestms@wwu.de
Cc:  
Subject: Re: docs/146047: [kld] [patch] the kldstat(2) manual needs to be
 more precise about the purpose of kld_file_stat.size
Date: Thu, 21 Apr 2011 20:11:00 -0400

 Hi Alex,
 
 Yep, I'll make sure this one doesn't have an anniversary.
 
 -- 
 Glen Barber | gjb@FreeBSD.org
 FreeBSD Documentation Project
 
State-Changed-From-To: open->patched 
State-Changed-By: gjb 
State-Changed-When: Sat Apr 23 21:00:37 UTC 2011 
State-Changed-Why:  
Patched in HEAD.  MFC in 3 days. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=146047 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/146047: commit references a PR
Date: Sat, 23 Apr 2011 21:00:36 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Sat Apr 23 20:59:58 2011
 New Revision: 220975
 URL: http://svn.freebsd.org/changeset/base/220975
 
 Log:
   - Clarification on kld_file_stat.size
   - While here, remove a few C comments that don't seem to contribute
     anything additional to the man page.
   
   PR:		146047
   Submitted by:	arundel
   MFC after:	3 days
 
 Modified:
   head/lib/libc/sys/kldstat.2
 
 Modified: head/lib/libc/sys/kldstat.2
 ==============================================================================
 --- head/lib/libc/sys/kldstat.2	Sat Apr 23 17:37:14 2011	(r220974)
 +++ head/lib/libc/sys/kldstat.2	Sat Apr 23 20:59:58 2011	(r220975)
 @@ -25,7 +25,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd March 3, 1999
 +.Dd April 23, 2011
  .Dt KLDSTAT 2
  .Os
  .Sh NAME
 @@ -51,8 +51,8 @@ struct kld_file_stat {
  	char        name[MAXPATHLEN];
  	int         refs;
  	int         id;
 -	caddr_t     address;        /* load address */
 -	size_t      size;           /* size in bytes */
 +	caddr_t     address;
 +	size_t      size;
  	char        pathname[MAXPATHLEN];
  };
  .Ed
 @@ -76,7 +76,7 @@ The id of the file specified in
  .It address
  The load address of the kld file.
  .It size
 -The size of the file.
 +The amount of memory in bytes allocated by the file.
  .It pathname
  The full name of the file referred to by
  .Fa fileid ,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/146047: commit references a PR
Date: Tue, 26 Apr 2011 13:09:38 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Tue Apr 26 13:09:19 2011
 New Revision: 221064
 URL: http://svn.freebsd.org/changeset/base/221064
 
 Log:
   MFC 220975:
   - Clarification on kld_file_stat.size
   - While here, remove a few C comments that don't seem to contribute
     anything additional to the man page.
   
   PR:		146047
 
 Modified:
   stable/8/lib/libc/sys/kldstat.2
 Directory Properties:
   stable/8/lib/libc/   (props changed)
   stable/8/lib/libc/stdtime/   (props changed)
 
 Modified: stable/8/lib/libc/sys/kldstat.2
 ==============================================================================
 --- stable/8/lib/libc/sys/kldstat.2	Tue Apr 26 12:50:26 2011	(r221063)
 +++ stable/8/lib/libc/sys/kldstat.2	Tue Apr 26 13:09:19 2011	(r221064)
 @@ -25,7 +25,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd March 3, 1999
 +.Dd April 23, 2011
  .Dt KLDSTAT 2
  .Os
  .Sh NAME
 @@ -51,8 +51,8 @@ struct kld_file_stat {
  	char        name[MAXPATHLEN];
  	int         refs;
  	int         id;
 -	caddr_t     address;        /* load address */
 -	size_t      size;           /* size in bytes */
 +	caddr_t     address;
 +	size_t      size;
  	char        pathname[MAXPATHLEN];
  };
  .Ed
 @@ -77,7 +77,7 @@ The id of the file specified in
  .It address
  The load address of the kld file.
  .It size
 -The size of the file.
 +The amount of memory in bytes allocated by the file.
  .It pathname
  The full name of the file referred to by
  .Fa fileid ,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gjb 
State-Changed-When: Tue Apr 26 13:10:50 UTC 2011 
State-Changed-Why:  
MFCd to stable/8 and stable/7.  Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=146047 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/146047: commit references a PR
Date: Tue, 26 Apr 2011 13:10:18 +0000 (UTC)

 Author: gjb (doc committer)
 Date: Tue Apr 26 13:09:54 2011
 New Revision: 221065
 URL: http://svn.freebsd.org/changeset/base/221065
 
 Log:
   MFC 220975:
   - Clarification on kld_file_stat.size
   - While here, remove a few C comments that don't seem to contribute
     anything additional to the man page.
   
   PR:		146047
 
 Modified:
   stable/7/lib/libc/sys/kldstat.2
 Directory Properties:
   stable/7/lib/libc/   (props changed)
   stable/7/lib/libc/stdtime/   (props changed)
 
 Modified: stable/7/lib/libc/sys/kldstat.2
 ==============================================================================
 --- stable/7/lib/libc/sys/kldstat.2	Tue Apr 26 13:09:19 2011	(r221064)
 +++ stable/7/lib/libc/sys/kldstat.2	Tue Apr 26 13:09:54 2011	(r221065)
 @@ -25,7 +25,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd March 3, 1999
 +.Dd April 23, 2011
  .Dt KLDSTAT 2
  .Os
  .Sh NAME
 @@ -51,8 +51,8 @@ struct kld_file_stat {
  	char        name[MAXPATHLEN];
  	int         refs;
  	int         id;
 -	caddr_t     address;        /* load address */
 -	size_t      size;           /* size in bytes */
 +	caddr_t     address;
 +	size_t      size;
  };
  .Ed
  .Pp
 @@ -76,7 +76,7 @@ The id of the file specified in
  .It address
  The load address of the kld file.
  .It size
 -The size of the file.
 +The amount of memory in bytes allocated by the file.
  .El
  .Sh RETURN VALUES
  .Rv -std kldstat
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
