From nobody@FreeBSD.org  Mon Apr 12 23:59:43 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 618C3106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Apr 2010 23:59:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 5194F8FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Apr 2010 23:59:43 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o3CNxhZM082805
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Apr 2010 23:59:43 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o3CNxhpl082803;
	Mon, 12 Apr 2010 23:59:43 GMT
	(envelope-from nobody)
Message-Id: <201004122359.o3CNxhpl082803@www.freebsd.org>
Date: Mon, 12 Apr 2010 23:59:43 GMT
From: Warren Block <wblock@wonkity.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Porter's Handbook missing semicolon in desktop entries example
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         145662
>Category:       docs
>Synopsis:       [patch] Porter's Handbook missing semicolon in desktop entries example
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 13 00:00:09 UTC 2010
>Closed-Date:    Sun Jul 04 19:23:10 UTC 2010
>Last-Modified:  Sun Jul 04 19:23:10 UTC 2010
>Originator:     Warren Block
>Release:        FreeBSD-8
>Organization:
>Environment:
FreeBSD lightning 8.0-STABLE FreeBSD 8.0-STABLE #0: Wed Apr  7 17:47:58 MDT 2010     root@lightning:/usr/obj/usr/src/sys/LIGHTNING  i386
>Description:
Porter's Handbook DESKTOP_ENTRIES example is missing a semicolon after the last category ("Application;Game;RolePlaying") but ports structure requires semicolons after each category.
>How-To-Repeat:
Compare DESKTOP_ENTRIES example in Porter's Handbook to the real entry in the actual port (/usr/ports/games/tome/Makefile):

Example: "Application;Game;RolePlaying"
Actual:  "Application;Game;RolePlaying;"
>Fix:
Apply attached patch to Porter's Handbook book.sgml.

Patch attached with submission follows:

--- book.sgml.orig	2010-04-12 17:45:24.000000000 -0600
+++ book.sgml	2010-04-12 17:46:59.000000000 -0600
@@ -5409,7 +5409,7 @@
 
 	<programlisting>DESKTOP_ENTRIES=  "ToME" "Roguelike game based on JRR Tolkien's work" \
                   "${DATADIR}/xtra/graf/tome-128.png" \
-                  "tome -v -g" "Application;Game;RolePlaying" \
+                  "tome -v -g" "Application;Game;RolePlaying;" \
                   false</programlisting>
 
       </sect2>


>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/145662: commit references a PR
Date: Sun,  4 Jul 2010 19:08:27 +0000 (UTC)

 bcr         2010-07-04 19:08:18 UTC
 
   FreeBSD doc repository
 
   Modified files:
     en_US.ISO8859-1/books/porters-handbook book.sgml 
   Log:
   Fix the DESKTOP_ENTRIES example that was missing a semicolon after the
   last category.
   
   PR:             docs/145662
   Submitted by:   Warren Block (wblock at wonkity dot com)
   Approved by:    jkois (mentor)
   
   Revision  Changes    Path
   1.1064    +1 -1      doc/en_US.ISO8859-1/books/porters-handbook/book.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: bcr 
State-Changed-When: Sun Jul 4 19:21:37 UTC 2010 
State-Changed-Why:  
Patch committed, thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145662 
>Unformatted:
