From nobody@FreeBSD.org  Mon Apr 12 15:10:02 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 282D3106567A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Apr 2010 15:10:02 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1474F8FC1C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Apr 2010 15:10:02 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o3CFA1xm047976
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Apr 2010 15:10:01 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o3CFA1a4047969;
	Mon, 12 Apr 2010 15:10:01 GMT
	(envelope-from nobody)
Message-Id: <201004121510.o3CFA1a4047969@www.freebsd.org>
Date: Mon, 12 Apr 2010 15:10:01 GMT
From: Armin Pirkovitsch <armin@frozen-zone.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Add an example to /usr/share/examples/etc/make.conf
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         145655
>Category:       docs
>Synopsis:       Add an example to /usr/share/examples/etc/make.conf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 12 15:20:00 UTC 2010
>Closed-Date:    Sun Aug 01 11:24:38 UTC 2010
>Last-Modified:  Sun Aug 01 11:24:38 UTC 2010
>Originator:     Armin Pirkovitsch
>Release:        9.0-CURRENT
>Organization:
>Environment:
>Description:
Add an useful example to make.conf to encourage people to look at make(1) to see what else is possible.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- make.conf.orig	2010-04-06 17:50:16.000000000 +0200
+++ make.conf	2010-04-12 19:00:45.000000000 +0200
@@ -269,3 +269,15 @@
 # /etc/mail/Makefile.  Defaults to 0640.
 #
 #SENDMAIL_MAP_PERMS=
+#
+#
+# It is also possible to set variables in make.conf which will only be
+# used when compiling a eg. specific port.
+# For more details have a look at make(1).
+#
+# Example:
+#
+#.if ${.CURDIR:M*/irc/irssi-devel*}
+#WITH_DEBUG=YES
+#.endif
+#


>Release-Note:
>Audit-Trail:

From: Doug Barton <dougb@FreeBSD.org>
To: Armin Pirkovitsch <armin@frozen-zone.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/145655: Add an example to /usr/share/examples/etc/make.conf
Date: Mon, 12 Apr 2010 10:25:59 -0700

 IMO it would be more useful to include a pointer to
 ports/ports-mgmt/portconf.
 
 Doug
 
 -- 
 
 	... and that's just a little bit of history repeating.
 			-- Propellerheads
 
 	Improve the effectiveness of your Internet presence with
 	a domain name makeover!    http://SupersetSolutions.com/
 

From: Armin Pirkovitsch <armin@frozen-zone.org>
To: Doug Barton <dougb@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/145655: Add an example to
 /usr/share/examples/etc/make.conf
Date: Wed, 14 Apr 2010 19:19:23 +0200

 I would suggest to include it additional to the already proposed content
 - that way people can choose whether to use a port or simply make.conf
   itself for it.
 
 Armin

From: Doug Barton <dougb@FreeBSD.org>
To: Armin Pirkovitsch <armin@frozen-zone.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/145655: Add an example to /usr/share/examples/etc/make.conf
Date: Wed, 14 Apr 2010 11:06:12 -0700

 On 4/14/2010 10:19 AM, Armin Pirkovitsch wrote:
 > On Mon 12 Apr 2010, Doug Barton wrote:
 > 
 >> IMO it would be more useful to include a pointer to
 >> ports/ports-mgmt/portconf.
 >>
 >>
 >> Doug
 > 
 > I would suggest to include it additional to the already proposed content
 > - that way people can choose whether to use a port or simply make.conf
 >   itself for it.
 
 That's fine as long as the text doesn't become so confusing as to be
 unhelpful. :)
 
 
 Doug
 
 -- 
 
 	... and that's just a little bit of history repeating.
 			-- Propellerheads
 
 	Improve the effectiveness of your Internet presence with
 	a domain name makeover!    http://SupersetSolutions.com/
 

From: Armin Pirkovitsch <armin@frozen-zone.org>
To: Doug Barton <dougb@FreeBSD.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/145655: Add an example to
 /usr/share/examples/etc/make.conf
Date: Wed, 14 Apr 2010 20:44:13 +0200

 --IJpNTDwzlM2Ie8A6
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 My suggestion would be the attached patch. However I'm not really the
 person who writes great and/or understandable documentations.
 
 Armin
 
 
 --IJpNTDwzlM2Ie8A6
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch-examples-etc-make.txt"
 
 --- make.conf.orig	2010-04-14 17:05:26.000000000 +0200
 +++ make.conf	2010-04-14 20:39:58.000000000 +0200
 @@ -269,3 +269,18 @@
  # /etc/mail/Makefile.  Defaults to 0640.
  #
  #SENDMAIL_MAP_PERMS=
 +#
 +#
 +# It is also possible to set variables in make.conf which will only be
 +# used when compiling e.g. a specific port.
 +# For more details have a look at make(1).
 +#
 +# Example:
 +#
 +#.if ${.CURDIR:M*/irc/irssi-devel*}
 +#WITH_DEBUG=YES
 +#.endif
 +#
 +# Another approach to do this is by using the port ports-mgmt/portconf
 +# which uses its own config file for port specific options.
 +#
 
 --IJpNTDwzlM2Ie8A6--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/145655: commit references a PR
Date: Sun, 25 Jul 2010 20:21:52 +0000 (UTC)

 Author: bcr (doc committer)
 Date: Sun Jul 25 20:21:32 2010
 New Revision: 210482
 URL: http://svn.freebsd.org/changeset/base/210482
 
 Log:
   Add an example to encourage people to have a look at either
   make(1) or /usr/ports/ports-mgmt/portconf for port-specific
   variables/options to compile a port.
   
   PR:		docs/145655
   Submitted by:	Armin Pirkovitsch (armin at frozen dash zone dot org)
   Discussed with:	dougb
   MFC after:	7 days
 
 Modified:
   head/share/examples/etc/make.conf
 
 Modified: head/share/examples/etc/make.conf
 ==============================================================================
 --- head/share/examples/etc/make.conf	Sun Jul 25 20:08:07 2010	(r210481)
 +++ head/share/examples/etc/make.conf	Sun Jul 25 20:21:32 2010	(r210482)
 @@ -269,3 +269,14 @@
  # /etc/mail/Makefile.  Defaults to 0640.
  #
  #SENDMAIL_MAP_PERMS=
 +#
 +#
 +# It is also possible to set variables in make.conf which will only be
 +# used when compiling a specific port.  For more details see make(1).
 +#
 +#.if ${.CURDIR:M*/irc/irssi-devel*}
 +#WITH_DEBUG=YES
 +#.endif
 +#
 +# Another approach is to use /usr/ports/ports-mgmt/portconf which has
 +# its own config file for port specific options.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: bcr 
State-Changed-When: Sun Jul 25 20:36:12 UTC 2010 
State-Changed-Why:  
A patch was committed to HEAD, waiting for MFC until closing this PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145655 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/145655: commit references a PR
Date: Sun,  1 Aug 2010 11:12:56 +0000 (UTC)

 Author: bcr (doc committer)
 Date: Sun Aug  1 11:12:42 2010
 New Revision: 210728
 URL: http://svn.freebsd.org/changeset/base/210728
 
 Log:
   MFC r210482:
   
   Add an example to encourage people to have a look at either
   make(1) or /usr/ports/ports-mgmt/portconf for port-specific
   variables/options to compile a port.
   
   PR:                 docs/145655
   Submitted by:       Armin Pirkovitsch (armin at frozen dash zone dot org)
   Discussed with:     dougb
 
 Modified:
   stable/8/share/examples/etc/make.conf
 Directory Properties:
   stable/8/share/examples/etc/   (props changed)
 
 Modified: stable/8/share/examples/etc/make.conf
 ==============================================================================
 --- stable/8/share/examples/etc/make.conf	Sun Aug  1 11:09:14 2010	(r210727)
 +++ stable/8/share/examples/etc/make.conf	Sun Aug  1 11:12:42 2010	(r210728)
 @@ -270,3 +270,14 @@
  # /etc/mail/Makefile.  Defaults to 0640.
  #
  #SENDMAIL_MAP_PERMS=
 +#
 +#
 +# It is also possible to set variables in make.conf which will only be
 +# used when compiling a specific port.  For more details see make(1).
 +#
 +#.if ${.CURDIR:M*/irc/irssi-devel*}
 +#WITH_DEBUG=YES
 +#.endif
 +#
 +# Another approach is to use /usr/ports/ports-mgmt/portconf which has
 +# its own config file for port specific options.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: bcr 
State-Changed-When: Sun Aug 1 11:23:31 UTC 2010 
State-Changed-Why:  
MFC is done, PR closed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145655 
>Unformatted:
