From nobody@FreeBSD.org  Tue Mar  2 01:31:10 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D6D3E1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  2 Mar 2010 01:31:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id AB07B8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  2 Mar 2010 01:31:10 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o221VAwA025267
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 2 Mar 2010 01:31:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o221V9M9025253;
	Tue, 2 Mar 2010 01:31:09 GMT
	(envelope-from nobody)
Message-Id: <201003020131.o221V9M9025253@www.freebsd.org>
Date: Tue, 2 Mar 2010 01:31:09 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] update makefs(8) (remove device option)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         144408
>Category:       docs
>Synopsis:       [patch] update makefs(8) (remove device option)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 02 01:40:04 UTC 2010
>Closed-Date:    Wed Jan 04 02:07:41 UTC 2012
>Last-Modified:  Sun Feb 03 22:28:08 UTC 2013
>Originator:     Garrett Cooper
>Release:        RELENG_8
>Organization:
Cisco Systems, Inc
>Environment:
FreeBSD garrcoop-fbsd.cisco.com 8.0-STABLE FreeBSD 8.0-STABLE #2: Wed Feb  3 16:57:07 PST 2010     garrcoop@garrcoop-fbsd.cisco.com:/usr/obj/usr/src/sys/LAPPY_X86  i386
>Description:
device isn't a supported keyword in mtree(8) [makefs(8) references the device keyword]:

[root@garrcoop-fbsd /home/garrcoop]# mtree -k device
mtree: line 0: unknown keyword device

     -F specfile
           Use specfile as an mtree(8) `specfile' specification.

           If a specfile entry exists in the underlying file system, its per-
           missions and modification time will be used unless specifically
           overridden by the specfile.  An error will be raised if the type of
           entry in the specfile conflicts with that of an existing entry.

           In the opposite case (where a specfile entry does not have an entry
           in the underlying file system) the following occurs: If the spec-
           file entry is marked optional, the specfile entry is ignored.  Oth-
           erwise, the entry will be created in the image, and it is necessary
           to specify at least the following parameters in the specfile: type,
           mode, gname or gid, and uname or uid, device (in the case of block
                                                 ^^^^^^
           or character devices), and link (in the case of symbolic links).
           If time isn't provided, the current time will be used.  If flags
           isn't provided, the current file flags will be used.  Missing regu-
           lar file entries will be created as zero-length files.

This patch removes that reference.
>How-To-Repeat:
n/a
>Fix:
See patch.

Patch attached with submission follows:

Index: head/usr.sbin/makefs/makefs.8
===================================================================
--- head/usr.sbin/makefs/makefs.8	(revision 204532)
+++ head/usr.sbin/makefs/makefs.8	(working copy)
@@ -192,8 +192,7 @@
 .Sy uname
 or
 .Sy uid ,
-.Sy device
-(in the case of block or character devices), and
+and
 .Sy link
 (in the case of symbolic links).
 If


>Release-Note:
>Audit-Trail:

From: Benedict Reuschling <bcr@FreeBSD.org>
To: bug-followup@FreeBSD.org, gcooper@FreeBSD.org
Cc:  
Subject: Re: docs/144408: [patch] update makefs(8) (remove device option)
Date: Wed, 25 May 2011 10:57:07 +0200

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 I checked with NetBSD whether they have to fix that issue in their tree
 as well. Apparently, their mtree has the 'device' definition:
 
 http://netbsd.gw.com/cgi-bin/man-cgi?mtree++NetBSD-current
 
 Question is: does it make sense to add it to our mtree as well?
 
 Benedict Reuschling
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.8 (Darwin)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
 iEYEARECAAYFAk3cxGMACgkQTSZQLkqBk0gSlACeIHoWrF8GgWa58K9JWe23RlbR
 /pwAoJ+NyetacCf0yfywVC5YiASPikBc
 =+bSs
 -----END PGP SIGNATURE-----
Responsible-Changed-From-To: freebsd-doc->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Oct 17 01:03:52 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144408 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/144408: commit references a PR
Date: Mon, 17 Oct 2011 21:31:12 +0000 (UTC)

 Author: eadler (ports committer)
 Date: Mon Oct 17 21:31:03 2011
 New Revision: 226482
 URL: http://svn.freebsd.org/changeset/base/226482
 
 Log:
   - remove device keyword from makefs manpage
   
   PR:		docs/144408
   Submitted by:	gcooper
   Approved by:	gjb
   Approved by:	sahil (mentor)
   MFC after:	1 week
 
 Modified:
   head/usr.sbin/makefs/makefs.8
 
 Modified: head/usr.sbin/makefs/makefs.8
 ==============================================================================
 --- head/usr.sbin/makefs/makefs.8	Mon Oct 17 20:03:38 2011	(r226481)
 +++ head/usr.sbin/makefs/makefs.8	Mon Oct 17 21:31:03 2011	(r226482)
 @@ -134,8 +134,7 @@ and
  .Sy uname
  or
  .Sy uid ,
 -.Sy device
 -(in the case of block or character devices), and
 +and
  .Sy link
  (in the case of symbolic links).
  If
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Tue Oct 18 00:01:19 UTC 2011 
State-Changed-Why:  
commited in r226482 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144408 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Wed Jan 4 02:07:40 UTC 2012 
State-Changed-Why:  
MFCed in r229458 r229457 and r229456. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144408 
>Unformatted:
