From nobody@FreeBSD.org  Sat Feb 13 09:06:05 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B98A2106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Feb 2010 09:06:05 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A83EC8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Feb 2010 09:06:05 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o1D965AF079319
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Feb 2010 09:06:05 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o1D9651P079318;
	Sat, 13 Feb 2010 09:06:05 GMT
	(envelope-from nobody)
Message-Id: <201002130906.o1D9651P079318@www.freebsd.org>
Date: Sat, 13 Feb 2010 09:06:05 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Incorrect char number for del
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143869
>Category:       docs
>Synopsis:       [PATCH] od(1)/hexdump(1): Incorrect char number for del
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gavin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 13 09:10:02 UTC 2010
>Closed-Date:    Wed Mar 10 13:43:21 UTC 2010
>Last-Modified:  Sun Feb 03 22:28:02 UTC 2013
>Originator:     Garrett Cooper
>Release:        9-CURRENT
>Organization:
Ironport
>Environment:
FreeBSD optimus.local 9.0-CURRENT FreeBSD 9.0-CURRENT #1: Sat Jan 23 20:43:11 PST 2010     root@optimus.zenmetsuhitotuyaneshita.net:/usr/obj/usr/src/sys/OPTIMUS  amd64
>Description:
hexdump(1) and od(1) both state that the humanized conversion character for del is 0xff (255), when the ascii value for DEL is actually 0x7f (127).

The code in conv.c is correct however (from line 169-171):

        } else if (*p == 0x7f) {
                *pr->cchar = 's';
                (void)printf(pr->fmt, "del");
>How-To-Repeat:
n/a
>Fix:
See attached patch.

Patch attached with submission follows:

Index: od.1
===================================================================
--- od.1	(revision 203332)
+++ od.1	(working copy)
@@ -155,7 +155,7 @@
 .It "00c FF	00d CR	00e SO	00f SI	010 DLE	011 DC1"
 .It "012 DC2	013 DC3	014 DC4	015 NAK	016 SYN	017 ETB"
 .It "018 CAN	019 EM	01a SUB	01b ESC	01c FS	01d GS"
-.It "01e RS	01f US	020 SP	0ff DEL"
+.It "01e RS	01f US	020 SP	07f DEL"
 .El
 .It Cm c
 Characters in the default character set.
Index: hexdump.1
===================================================================
--- hexdump.1	(revision 203332)
+++ hexdump.1	(working copy)
@@ -258,7 +258,7 @@
 .It "\&00C\ FF\t00D\ CR\t00E\ SO\t00F\ SI\t010\ DLE\t011\ DC1
 .It "\&012\ DC2\t013\ DC3\t014\ DC4\t015\ NAK\t016\ SYN\t017\ ETB
 .It "\&018\ CAN\t019\ EM\t01A\ SUB\t01B\ ESC\t01C\ FS\t01D\ GS
-.It "\&01E\ RS\t01F\ US\t0FF\ DEL
+.It "\&01E\ RS\t01F\ US\t07F\ DEL
 .El
 .El
 .Pp


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Thu Feb 18 19:00:58 UTC 2010 
State-Changed-Why:  
Fixed in head, r204053.  MFC in 2 weeks. 


Responsible-Changed-From-To: freebsd-doc->gavin 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Thu Feb 18 19:00:58 UTC 2010 
Responsible-Changed-Why:  
Mine 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143869 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/143869: commit references a PR
Date: Thu, 18 Feb 2010 19:08:22 +0000 (UTC)

 Author: gavin
 Date: Thu Feb 18 19:06:30 2010
 New Revision: 204053
 URL: http://svn.freebsd.org/changeset/base/204053
 
 Log:
   The correct value of DEL is 0x7f, not 0xff.  This is purely a documentation
   issue - od(1) and hexdump(1) behave as expected.
   
   PR:		docs/143869
   Submitted by:	gcooper
   MFC after:	2 weeks
 
 Modified:
   head/usr.bin/hexdump/hexdump.1
   head/usr.bin/hexdump/od.1
 
 Modified: head/usr.bin/hexdump/hexdump.1
 ==============================================================================
 --- head/usr.bin/hexdump/hexdump.1	Thu Feb 18 19:02:33 2010	(r204052)
 +++ head/usr.bin/hexdump/hexdump.1	Thu Feb 18 19:06:30 2010	(r204053)
 @@ -32,7 +32,7 @@
  .\"	@(#)hexdump.1	8.2 (Berkeley) 4/18/94
  .\" $FreeBSD$
  .\"
 -.Dd July 10, 2004
 +.Dd February 18, 2010
  .Dt HEXDUMP 1
  .Os
  .Sh NAME
 @@ -258,7 +258,7 @@ strings.
  .It "\&00C\ FF\t00D\ CR\t00E\ SO\t00F\ SI\t010\ DLE\t011\ DC1
  .It "\&012\ DC2\t013\ DC3\t014\ DC4\t015\ NAK\t016\ SYN\t017\ ETB
  .It "\&018\ CAN\t019\ EM\t01A\ SUB\t01B\ ESC\t01C\ FS\t01D\ GS
 -.It "\&01E\ RS\t01F\ US\t0FF\ DEL
 +.It "\&01E\ RS\t01F\ US\t07F\ DEL
  .El
  .El
  .Pp
 
 Modified: head/usr.bin/hexdump/od.1
 ==============================================================================
 --- head/usr.bin/hexdump/od.1	Thu Feb 18 19:02:33 2010	(r204052)
 +++ head/usr.bin/hexdump/od.1	Thu Feb 18 19:06:30 2010	(r204053)
 @@ -32,7 +32,7 @@
  .\"	@(#)od.1	8.1 (Berkeley) 6/6/93
  .\" $FreeBSD$
  .\"
 -.Dd December 24, 2006
 +.Dd February 18, 2010
  .Os
  .Dt OD 1
  .Sh NAME
 @@ -155,7 +155,7 @@ Control characters are displayed using t
  .It "00c FF	00d CR	00e SO	00f SI	010 DLE	011 DC1"
  .It "012 DC2	013 DC3	014 DC4	015 NAK	016 SYN	017 ETB"
  .It "018 CAN	019 EM	01a SUB	01b ESC	01c FS	01d GS"
 -.It "01e RS	01f US	020 SP	0ff DEL"
 +.It "01e RS	01f US	020 SP	07f DEL"
  .El
  .It Cm c
  Characters in the default character set.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Wed Mar 10 13:42:51 UTC 2010 
State-Changed-Why:  
Merged to stable/8 and stable/7.  Thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143869 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/143869: commit references a PR
Date: Wed, 10 Mar 2010 13:40:47 +0000 (UTC)

 Author: gavin
 Date: Wed Mar 10 13:40:37 2010
 New Revision: 204951
 URL: http://svn.freebsd.org/changeset/base/204951
 
 Log:
   Merge r204053 from head:
   
     The correct value of DEL is 0x7f, not 0xff.  This is purely a documentation
     issue - od(1) and hexdump(1) behave as expected.
   
   PR:		docs/143869
   Submitted by:	gcooper
 
 Modified:
   stable/8/usr.bin/hexdump/hexdump.1
   stable/8/usr.bin/hexdump/od.1
 Directory Properties:
   stable/8/usr.bin/hexdump/   (props changed)
 
 Modified: stable/8/usr.bin/hexdump/hexdump.1
 ==============================================================================
 --- stable/8/usr.bin/hexdump/hexdump.1	Wed Mar 10 13:23:25 2010	(r204950)
 +++ stable/8/usr.bin/hexdump/hexdump.1	Wed Mar 10 13:40:37 2010	(r204951)
 @@ -32,7 +32,7 @@
  .\"	@(#)hexdump.1	8.2 (Berkeley) 4/18/94
  .\" $FreeBSD$
  .\"
 -.Dd July 10, 2004
 +.Dd February 18, 2010
  .Dt HEXDUMP 1
  .Os
  .Sh NAME
 @@ -258,7 +258,7 @@ strings.
  .It "\&00C\ FF\t00D\ CR\t00E\ SO\t00F\ SI\t010\ DLE\t011\ DC1
  .It "\&012\ DC2\t013\ DC3\t014\ DC4\t015\ NAK\t016\ SYN\t017\ ETB
  .It "\&018\ CAN\t019\ EM\t01A\ SUB\t01B\ ESC\t01C\ FS\t01D\ GS
 -.It "\&01E\ RS\t01F\ US\t0FF\ DEL
 +.It "\&01E\ RS\t01F\ US\t07F\ DEL
  .El
  .El
  .Pp
 
 Modified: stable/8/usr.bin/hexdump/od.1
 ==============================================================================
 --- stable/8/usr.bin/hexdump/od.1	Wed Mar 10 13:23:25 2010	(r204950)
 +++ stable/8/usr.bin/hexdump/od.1	Wed Mar 10 13:40:37 2010	(r204951)
 @@ -32,7 +32,7 @@
  .\"	@(#)od.1	8.1 (Berkeley) 6/6/93
  .\" $FreeBSD$
  .\"
 -.Dd December 24, 2006
 +.Dd February 18, 2010
  .Os
  .Dt OD 1
  .Sh NAME
 @@ -155,7 +155,7 @@ Control characters are displayed using t
  .It "00c FF	00d CR	00e SO	00f SI	010 DLE	011 DC1"
  .It "012 DC2	013 DC3	014 DC4	015 NAK	016 SYN	017 ETB"
  .It "018 CAN	019 EM	01a SUB	01b ESC	01c FS	01d GS"
 -.It "01e RS	01f US	020 SP	0ff DEL"
 +.It "01e RS	01f US	020 SP	07f DEL"
  .El
  .It Cm c
  Characters in the default character set.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/143869: commit references a PR
Date: Wed, 10 Mar 2010 13:42:57 +0000 (UTC)

 Author: gavin
 Date: Wed Mar 10 13:42:37 2010
 New Revision: 204952
 URL: http://svn.freebsd.org/changeset/base/204952
 
 Log:
   Merge r204053 from head:
   
     The correct value of DEL is 0x7f, not 0xff.  This is purely a documentation
     issue - od(1) and hexdump(1) behave as expected.
   
   PR:		docs/143869
   Submitted by:	gcooper
 
 Modified:
   stable/7/usr.bin/hexdump/hexdump.1
   stable/7/usr.bin/hexdump/od.1
 Directory Properties:
   stable/7/usr.bin/hexdump/   (props changed)
 
 Modified: stable/7/usr.bin/hexdump/hexdump.1
 ==============================================================================
 --- stable/7/usr.bin/hexdump/hexdump.1	Wed Mar 10 13:40:37 2010	(r204951)
 +++ stable/7/usr.bin/hexdump/hexdump.1	Wed Mar 10 13:42:37 2010	(r204952)
 @@ -32,7 +32,7 @@
  .\"	@(#)hexdump.1	8.2 (Berkeley) 4/18/94
  .\" $FreeBSD$
  .\"
 -.Dd July 10, 2004
 +.Dd February 18, 2010
  .Dt HEXDUMP 1
  .Os
  .Sh NAME
 @@ -258,7 +258,7 @@ strings.
  .It "\&00C\ FF\t00D\ CR\t00E\ SO\t00F\ SI\t010\ DLE\t011\ DC1
  .It "\&012\ DC2\t013\ DC3\t014\ DC4\t015\ NAK\t016\ SYN\t017\ ETB
  .It "\&018\ CAN\t019\ EM\t01A\ SUB\t01B\ ESC\t01C\ FS\t01D\ GS
 -.It "\&01E\ RS\t01F\ US\t0FF\ DEL
 +.It "\&01E\ RS\t01F\ US\t07F\ DEL
  .El
  .El
  .Pp
 
 Modified: stable/7/usr.bin/hexdump/od.1
 ==============================================================================
 --- stable/7/usr.bin/hexdump/od.1	Wed Mar 10 13:40:37 2010	(r204951)
 +++ stable/7/usr.bin/hexdump/od.1	Wed Mar 10 13:42:37 2010	(r204952)
 @@ -32,7 +32,7 @@
  .\"	@(#)od.1	8.1 (Berkeley) 6/6/93
  .\" $FreeBSD$
  .\"
 -.Dd December 24, 2006
 +.Dd February 18, 2010
  .Os
  .Dt OD 1
  .Sh NAME
 @@ -155,7 +155,7 @@ Control characters are displayed using t
  .It "00c FF	00d CR	00e SO	00f SI	010 DLE	011 DC1"
  .It "012 DC2	013 DC3	014 DC4	015 NAK	016 SYN	017 ETB"
  .It "018 CAN	019 EM	01a SUB	01b ESC	01c FS	01d GS"
 -.It "01e RS	01f US	020 SP	0ff DEL"
 +.It "01e RS	01f US	020 SP	07f DEL"
  .El
  .It Cm c
  Characters in the default character set.
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
