From nobody@FreeBSD.org  Tue Nov 10 21:46:34 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 06F7A106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Nov 2009 21:46:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id EB0368FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Nov 2009 21:46:33 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nAALkXg5049999
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Nov 2009 21:46:33 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nAALkXOw049998;
	Tue, 10 Nov 2009 21:46:33 GMT
	(envelope-from nobody)
Message-Id: <200911102146.nAALkXOw049998@www.freebsd.org>
Date: Tue, 10 Nov 2009 21:46:33 GMT
From: Jeremy Huddleston <jeremyhu@apple.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Grammar fix for isspace(3)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         140457
>Category:       docs
>Synopsis:       [patch] Grammar fix for isspace(3)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wblock
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 10 21:50:02 UTC 2009
>Closed-Date:    Sun Jul 22 22:55:05 UTC 2012
>Last-Modified:  Sun Jul 22 22:55:05 UTC 2012
>Originator:     Jeremy Huddleston
>Release:        8.0
>Organization:
Apple
>Environment:
NA
>Description:
Grammar fix for src/lib/libc/locale/isspace.3
>How-To-Repeat:

>Fix:
--- isspace.3.bsdnew	2009-11-10 13:13:10.000000000 -0800
+++ isspace.3	2009-11-10 13:45:41.000000000 -0800
@@ -54,9 +54,9 @@ For any locale, this includes the follow
 .It "\&``\et''\t``\en''\t``\ev''\t``\ef''\t``\er''\t`` ''"
 .El
 .Pp
-In the "C" locale
+In the "C" locale,
 .Fn isspace
-successful test is limited to this characters only.
+successful test is limited to these characters only.
 The value of the argument must be representable as an
 .Vt "unsigned char"
 or the value of


>Release-Note:
>Audit-Trail:

From: Bruce Evans <brde@optusnet.com.au>
To: Jeremy Huddleston <jeremyhu@apple.com>
Cc: freebsd-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Subject: Re: misc/140457: Grammar fix for isspace(3)
Date: Wed, 11 Nov 2009 23:08:28 +1100 (EST)

 On Tue, 10 Nov 2009, Jeremy Huddleston wrote:
 
 >> Fix:
 > --- isspace.3.bsdnew	2009-11-10 13:13:10.000000000 -0800
 > +++ isspace.3	2009-11-10 13:45:41.000000000 -0800
 > @@ -54,9 +54,9 @@ For any locale, this includes the follow
 > .It "\&``\et''\t``\en''\t``\ev''\t``\ef''\t``\er''\t`` ''"
 > .El
 > .Pp
 > -In the "C" locale
 > +In the "C" locale,
 
 This and the other commas you want to add are improvements, but is this
 because they are required by grammar or style?
 
 > .Fn isspace
 > -successful test is limited to this characters only.
 > +successful test is limited to these characters only.
 > The value of the argument must be representable as an
 > .Vt "unsigned char"
 > or the value of
 
 isspace.3 has several more grammar errors.  In FreeBSD changes, I noticed:
 
 % Index: isspace.3
 % ===================================================================
 % RCS file: /home/ncvs/src/lib/libc/locale/isspace.3,v
 % retrieving revision 1.1
 % retrieving revision 1.22
 % diff -u -2 -r1.1 -r1.22
 % --- isspace.3	27 May 1994 04:56:44 -0000	1.1
 % +++ isspace.3	4 Sep 2009 07:44:58 -0000	1.22
 % ...
 %  .Sh DESCRIPTION
 %  The
 %  .Fn isspace
 % -function tests for the standard white-space characters.
 % -In the ASCII character set, this includes the following characters:
 % -.sp
 % -.Bl -column \&000_``0''__ \&000_``0''__ \&000_``0''__ \&000_``0''__ \&000_``0''__
 % -.It \&011\ ht \t012\ nl \t013\ vt \t014\ np \t015\ cr
 % -.It \&040\ sp
 % +function tests for the white-space characters.
 
 This got mangled by removing "standard" without removing "the".  The
 latter applies to "standard", not the the white-space characters, and
 not removing it defeats the point of removing "standard" (by suggesting
 that there is a single set of white-space characters, instead of a
 standard set and nonstandard extensions).
 
 % +For any locale, this includes the following standard characters:
 % +.Pp
 % +.Bl -column \&`\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___
 % +.It "\&``\et''\t``\en''\t``\ev''\t``\ef''\t``\er''\t`` ''"
 %  .El
 % +.Pp
 % +In the "C" locale
 % +.Fn isspace
 % +successful test is limited to this characters only.
 
 "isspace successful test" still has a couple of grammar errors.
 
 The C standard has much better wording for this, of course.  POSIX.1
 (which FreeBSD has permission to copy) unfortunately doesn't copy the
 C standard, and it has grammatically correct but otherwise poor wording
 (at least in a draft 2001 version) (it refers to the C standard and a
 generic section), so copying it wouldn't be useful.
 
 The C standard says "standard white space" like the above used to, but
 doesn't say "the standard", and it handles the bug fixed in the above
 better by saying "standard ... or ... locale-specific...".  Then it
 lists the standard white-space characters (hopefully the same set as
 above).  Then it has very good wording instead of "successful test is
 limited to this [sic] characters".
 
 isblank.3 has the same bugs.
 
 Bruce
Responsible-Changed-From-To: freebsd-bugs->freebsd-doc 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Nov 11 17:24:41 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140457 
State-Changed-From-To: open->patched 
State-Changed-By: schweikh 
State-Changed-When: Tue Sep 27 17:54:41 UTC 2011 
State-Changed-Why:  
Patched in HEAD. Await MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140457 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/140457: commit references a PR
Date: Tue, 27 Sep 2011 17:54:19 +0000 (UTC)

 Author: schweikh
 Date: Tue Sep 27 17:54:10 2011
 New Revision: 225808
 URL: http://svn.freebsd.org/changeset/base/225808
 
 Log:
   Fix grammar.
   
   PR:		140457
   Submitted by:	jeremyhu AT apple.com
   MFC after:	2 weeks
 
 Modified:
   head/lib/libc/locale/isspace.3
 
 Modified: head/lib/libc/locale/isspace.3
 ==============================================================================
 --- head/lib/libc/locale/isspace.3	Tue Sep 27 17:41:48 2011	(r225807)
 +++ head/lib/libc/locale/isspace.3	Tue Sep 27 17:54:10 2011	(r225808)
 @@ -47,16 +47,16 @@
  .Sh DESCRIPTION
  The
  .Fn isspace
 -function tests for the white-space characters.
 +function tests for white-space characters.
  For any locale, this includes the following standard characters:
  .Pp
  .Bl -column \&`\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___
  .It "\&``\et''\t``\en''\t``\ev''\t``\ef''\t``\er''\t`` ''"
  .El
  .Pp
 -In the "C" locale
 +In the "C" locale,
  .Fn isspace
 -successful test is limited to this characters only.
 +returns non-zero for these characters only.
  The value of the argument must be representable as an
  .Vt "unsigned char"
  or the value of
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/140457: commit references a PR
Date: Mon, 25 Jun 2012 23:39:54 +0000 (UTC)

 Author: wblock (doc committer)
 Date: Mon Jun 25 23:39:35 2012
 New Revision: 237584
 URL: http://svn.freebsd.org/changeset/base/237584
 
 Log:
   MFC r225808:
   
   Fix grammar.
   
   PR:		140457
   Submitted by:	jeremyhu AT apple.com
   Approved by:	gjb (mentor)
 
 Modified:
   stable/9/lib/libc/locale/isspace.3
 Directory Properties:
   stable/9/lib/libc/   (props changed)
 
 Modified: stable/9/lib/libc/locale/isspace.3
 ==============================================================================
 --- stable/9/lib/libc/locale/isspace.3	Mon Jun 25 23:22:43 2012	(r237583)
 +++ stable/9/lib/libc/locale/isspace.3	Mon Jun 25 23:39:35 2012	(r237584)
 @@ -47,16 +47,16 @@
  .Sh DESCRIPTION
  The
  .Fn isspace
 -function tests for the white-space characters.
 +function tests for white-space characters.
  For any locale, this includes the following standard characters:
  .Pp
  .Bl -column \&`\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___
  .It "\&``\et''\t``\en''\t``\ev''\t``\ef''\t``\er''\t`` ''"
  .El
  .Pp
 -In the "C" locale
 +In the "C" locale,
  .Fn isspace
 -successful test is limited to this characters only.
 +returns non-zero for these characters only.
  The value of the argument must be representable as an
  .Vt "unsigned char"
  or the value of
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/140457: commit references a PR
Date: Mon, 25 Jun 2012 23:40:33 +0000 (UTC)

 Author: wblock (doc committer)
 Date: Mon Jun 25 23:40:19 2012
 New Revision: 237585
 URL: http://svn.freebsd.org/changeset/base/237585
 
 Log:
   MFC r225808:
   
   Fix grammar.
   
   PR:		140457
   Submitted by:	jeremyhu AT apple.com
   Approved by:	gjb (mentor)
 
 Modified:
   stable/8/lib/libc/locale/isspace.3
 Directory Properties:
   stable/8/lib/libc/   (props changed)
 
 Modified: stable/8/lib/libc/locale/isspace.3
 ==============================================================================
 --- stable/8/lib/libc/locale/isspace.3	Mon Jun 25 23:39:35 2012	(r237584)
 +++ stable/8/lib/libc/locale/isspace.3	Mon Jun 25 23:40:19 2012	(r237585)
 @@ -47,16 +47,16 @@
  .Sh DESCRIPTION
  The
  .Fn isspace
 -function tests for the white-space characters.
 +function tests for white-space characters.
  For any locale, this includes the following standard characters:
  .Pp
  .Bl -column \&`\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___
  .It "\&``\et''\t``\en''\t``\ev''\t``\ef''\t``\er''\t`` ''"
  .El
  .Pp
 -In the "C" locale
 +In the "C" locale,
  .Fn isspace
 -successful test is limited to this characters only.
 +returns non-zero for these characters only.
  The value of the argument must be representable as an
  .Vt "unsigned char"
  or the value of
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: docs/140457: commit references a PR
Date: Mon, 25 Jun 2012 23:41:06 +0000 (UTC)

 Author: wblock (doc committer)
 Date: Mon Jun 25 23:40:58 2012
 New Revision: 237586
 URL: http://svn.freebsd.org/changeset/base/237586
 
 Log:
   MFC r225808:
   
   Fix grammar.
   
   PR:		140457
   Submitted by:	jeremyhu AT apple.com
   Approved by:	gjb (mentor)
 
 Modified:
   stable/7/lib/libc/locale/isspace.3
 Directory Properties:
   stable/7/lib/libc/   (props changed)
 
 Modified: stable/7/lib/libc/locale/isspace.3
 ==============================================================================
 --- stable/7/lib/libc/locale/isspace.3	Mon Jun 25 23:40:19 2012	(r237585)
 +++ stable/7/lib/libc/locale/isspace.3	Mon Jun 25 23:40:58 2012	(r237586)
 @@ -47,16 +47,16 @@
  .Sh DESCRIPTION
  The
  .Fn isspace
 -function tests for the white-space characters.
 +function tests for white-space characters.
  For any locale, this includes the following standard characters:
  .Pp
  .Bl -column \&`\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___ \&``\et''___
  .It "\&``\et''\t``\en''\t``\ev''\t``\ef''\t``\er''\t`` ''"
  .El
  .Pp
 -In the "C" locale
 +In the "C" locale,
  .Fn isspace
 -successful test is limited to this characters only.
 +returns non-zero for these characters only.
  The value of the argument must be representable as an
  .Vt "unsigned char"
  or the value of
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: freebsd-doc->wblock 
Responsible-Changed-By: wblock 
Responsible-Changed-When: Sun Jul 22 22:52:53 UTC 2012 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140457 
State-Changed-From-To: patched->closed 
State-Changed-By: wblock 
State-Changed-When: Sun Jul 22 22:53:25 UTC 2012 
State-Changed-Why:  
Patch committed to head and MFCed to 9, 8, and 7.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140457 
>Unformatted:
